)]}'
{"stack.sh":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8865a6d90c9be12067b8b3fea35b82acc9c6385d","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"\tDIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"},{"line_number":299,"context_line":"\tDIST_BIN_DIR\u003d/usr/local/bin"},{"line_number":300,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAM3%2F%2Fd7g%3D","line":297,"updated":"2013-01-21 12:59:19.000000000","message":"Please convert tabs into spaces here to be consistent with the rest of the file","commit_id":"f435804fcb40f73427db80b21e159ecba11e6b38"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8865a6d90c9be12067b8b3fea35b82acc9c6385d","unresolved":false,"context_lines":[{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"\tDIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"},{"line_number":299,"context_line":"\tDIST_BIN_DIR\u003d/usr/local/bin"},{"line_number":300,"context_line":"fi"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"# Configure Projects"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAM3%2F%2Fd7c%3D","line":299,"updated":"2013-01-21 12:59:19.000000000","message":"Ditto","commit_id":"f435804fcb40f73427db80b21e159ecba11e6b38"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"d88126ed7856626f547585a588852cfb6c58ae01","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Service startup timeout"},{"line_number":293,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"    DIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAM3%2F%2FZ2Q%3D","line":295,"updated":"2013-01-23 20:51:18.000000000","message":"This needs to be set for more than just stack.sh, please move it to stackrc just after DATA_DIR is set.","commit_id":"024d48dcb1f6df2e15e7f6ee33b2238f39664c3b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1607e91e110fc8e76c4971c715e6eda2b144b7a8","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Service startup timeout"},{"line_number":293,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"    DIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAM3%2F%2FYsg%3D","line":295,"in_reply_to":"AAAAM3%2F%2FY%2Bk%3D","updated":"2013-01-24 15:56:26.000000000","message":"If we\u0027re going to introduce a variable for this, then:\n* there must be exactly one place to set the default value\n* there should be one place for modifying that default value\n* those places need to be a prerequisite for the places where it is used\n\nstackrc is the correct place:\n* is is already a prerequisite for the lib/* files\n* sourcing functions is already a prerequisite for sourcing stackrc (see the enable_service() and disable_service() functions for a precedent)\n\nstackrc is not designed to be used in an interactive shell, although it could work if you first source functions.","commit_id":"024d48dcb1f6df2e15e7f6ee33b2238f39664c3b"},{"author":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"change_message_id":"664966ee1bff9e7f3539ceb22e815ed39b98800d","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Service startup timeout"},{"line_number":293,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"    DIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAM3%2F%2FXg0%3D","line":295,"in_reply_to":"AAAAM3%2F%2FYmM%3D","updated":"2013-01-25 09:00:37.000000000","message":"What other solution than env var do you suggest? Making it a function?","commit_id":"024d48dcb1f6df2e15e7f6ee33b2238f39664c3b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b5a8bf02f6b20dc472044a3bcbd5f1bfd6a00d16","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Service startup timeout"},{"line_number":293,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"    DIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAM3%2F%2FYmM%3D","line":295,"in_reply_to":"AAAAM3%2F%2FYn8%3D","updated":"2013-01-24 16:49:03.000000000","message":"* stack.sh is not the only script that uses the lib/* files.\n* stackrc already has a dependency on functions; just because you don\u0027t use enabled_serivce() doesn\u0027t mean nobody else also doesn\u0027t\n* I don\u0027t like the idea of doing this in an env var to begin with","commit_id":"024d48dcb1f6df2e15e7f6ee33b2238f39664c3b"},{"author":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"change_message_id":"fe21d33dfd18be41baba7676a9f82c14522e37a5","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Service startup timeout"},{"line_number":293,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"    DIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAM3%2F%2FYn8%3D","line":295,"in_reply_to":"AAAAM3%2F%2FYsg%3D","updated":"2013-01-24 16:34:26.000000000","message":"That would certainly be correct for a config variable. The question is if this really is really the case. I think it\u0027s more of an internal system-dependent value that needs to be detected but never changed.\n\nIn which case might a user want to modify this? After manually installing openstack packages into a non-standard location? Why would anyone want to do that AND use devstack afterwards? I don\u0027t see any gains by making this variable user editable, only downsides.\n\nI don\u0027t like putting it into stackrc because \u0027functions\u0027 have to be included which is an extra (and IMHO needless) dependency. Although stackrc was not designed to be used in an interactive shell, it now works great without manually sourcing additional files which is cool.","commit_id":"024d48dcb1f6df2e15e7f6ee33b2238f39664c3b"},{"author":{"_account_id":6717,"name":"Jakub Ruzicka","email":"jruzicka@redhat.com","username":"jruzicka"},"change_message_id":"fab041281cec4e5bc69ca1d4390635539c54de14","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Service startup timeout"},{"line_number":293,"context_line":"SERVICE_TIMEOUT\u003d${SERVICE_TIMEOUT:-60}"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"# Distribution specific binary direcotry (where setuptools puts binaries)"},{"line_number":296,"context_line":"if is_fedora; then"},{"line_number":297,"context_line":"    DIST_BIN_DIR\u003d/usr/bin"},{"line_number":298,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAM3%2F%2FY%2Bk%3D","line":295,"in_reply_to":"AAAAM3%2F%2FZ2Q%3D","updated":"2013-01-24 12:06:42.000000000","message":"\u0027functions\u0027 is not sourced in \u0027stackrc\u0027 and thus manually sourcing \u0027stackrc\u0027 from shell won\u0027t work:\n\n$ . ./stackrc\n\n./stackrc:13: command not found: is_fedora\n\nIt doesn\u0027t really appear to me like a config option as it\u0027s determined by platform so \u0027stackrc\u0027 seems to be wrong place anyway.\n\nHaving reduntant is_fedora check in \u0027stackrc\u0027 sounds even more evil.\n\nWhere exactly might this value be needed? It can be inferred from environment anytime independently on devstack/openstack.","commit_id":"024d48dcb1f6df2e15e7f6ee33b2238f39664c3b"}]}