)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8e53caa3f44601613a596f0f8ee852ffa6aab0b9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"added to IMAGE_URLS. But since uploading duplicated image will cause a"},{"line_number":11,"context_line":"\"409 Conflict\" error, IMAGE_URLS needs to be deduplicated when all the"},{"line_number":12,"context_line":"settings are done. Otherwise if user follows the steps suggested by"},{"line_number":13,"context_line":"tools/xen/README.md, the problem will definitely occur."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3ca4e576aa3fb8992c08ca44900a8c53dd4b4163"},{"line_number":16,"context_line":"Closes-Bug: #1473432"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_b8187e1f","line":13,"updated":"2015-07-22 06:07:28.000000000","message":"I think the Xen instructions assume that IMAGE_URLS will *overwrite* the defaults?\n\nWith this, the default cirros image will be added, so that should just be removed from the Xen readme?","commit_id":"64ad2536a46b08e58f5e5235465822fc47dd6a59"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"7438cffdfb3b43b1ea08e1244410efedb4948444","unresolved":false,"context_lines":[{"line_number":10,"context_line":"added to IMAGE_URLS. But since uploading duplicated image will cause a"},{"line_number":11,"context_line":"\"409 Conflict\" error, IMAGE_URLS needs to be deduplicated when all the"},{"line_number":12,"context_line":"settings are done. Otherwise if user follows the steps suggested by"},{"line_number":13,"context_line":"tools/xen/README.md, the problem will definitely occur."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3ca4e576aa3fb8992c08ca44900a8c53dd4b4163"},{"line_number":16,"context_line":"Closes-Bug: #1473432"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_e4a8a022","line":13,"in_reply_to":"3a50d1a3_b8187e1f","updated":"2015-07-22 07:38:09.000000000","message":"The Xen instructions were intended to provide an image that we knew would work.  Perhaps one fix for them would to be to add DOWNLOAD_DEFAULT_IMAGES\u003dFalse.\nEither way, I think we should be able to set IMAGE_URLS in localrc (to most values) and the default should be for stackrc to not break the value (see my other comment)","commit_id":"64ad2536a46b08e58f5e5235465822fc47dd6a59"}],"doc/source/configuration.rst":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d2ab5c612b5cc08847acd18f4dc9cb825292ce6c","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    |  Built-in guest images could be configured in ``local.conf`` or"},{"line_number":403,"context_line":"       ``localrc`` by setting IMAGE_URLS, while there are one or many default"},{"line_number":404,"context_line":"       images predefined in ``stack.sh`` according to the type of hypervisor."},{"line_number":405,"context_line":"       You could choose to download those default images still by setting "},{"line_number":406,"context_line":"       ``DOWNLOAD_DEFAULT_IMAGES\u003dTrue`` as well as overwrite them by setting"},{"line_number":407,"context_line":"       ``DOWNLOAD_DEFAULT_IMAGES\u003dFalse``. In either way, destack will remove"},{"line_number":408,"context_line":"       the duplicated images."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a50d1a3_ec81a94e","line":405,"updated":"2015-07-26 17:49:36.000000000","message":"please remove the whitespace","commit_id":"2f82b453e9ea6187dc460c9f87c0baf24b315840"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8aa62bb6dbdfa6b6bbff1e65115e5bd2343e5c78","unresolved":false,"context_lines":[{"line_number":399,"context_line":"--------------------"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    | *Default: ``DOWNLOAD_DEFAULT_IMAGES\u003dTrue``*"},{"line_number":402,"context_line":"    |  Built-in guest images could be configured in ``local.conf`` or"},{"line_number":403,"context_line":"       ``localrc`` by setting IMAGE_URLS, while there are one or many default"},{"line_number":404,"context_line":"       images predefined in ``stack.sh`` according to the type of hypervisor."},{"line_number":405,"context_line":"       You could choose to download those default images still by setting"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a50d1a3_76adb0e9","line":402,"updated":"2015-07-30 01:43:41.000000000","message":"The tense of this comment seems wrong.  \"guest images can be\", etc","commit_id":"e41edf8fd30afbcd5b7707af46a33a4d4057d38f"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"2489cf19d2166a83b43d3e7aab63fb1108531be7","unresolved":false,"context_lines":[{"line_number":405,"context_line":"       You could choose to download those default images still by setting"},{"line_number":406,"context_line":"       ``DOWNLOAD_DEFAULT_IMAGES\u003dTrue`` as well as overwrite them by setting"},{"line_number":407,"context_line":"       ``DOWNLOAD_DEFAULT_IMAGES\u003dFalse``. In either way, destack will remove"},{"line_number":408,"context_line":"       the duplicated images."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    ::"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a50d1a3_4b3cb592","line":408,"updated":"2015-07-29 13:28:43.000000000","message":"Recommended to change to: In either case, devstack will remove duplicate URLs to try and avoid duplicate images.","commit_id":"e41edf8fd30afbcd5b7707af46a33a4d4057d38f"}],"stackrc":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8e53caa3f44601613a596f0f8ee852ffa6aab0b9","unresolved":false,"context_lines":[{"line_number":557,"context_line":"# Set default image based on ``VIRT_DRIVER`` and ``LIBVIRT_TYPE``, either of"},{"line_number":558,"context_line":"# which may be set in ``local.conf``.  Also allow ``DEFAULT_IMAGE_NAME`` and"},{"line_number":559,"context_line":"# ``IMAGE_URLS`` to be set in the `localrc` section of ``local.conf``."},{"line_number":560,"context_line":"DOWNLOAD_DEFAULT_IMAGES\u003d${DOWNLOAD_DEFAULT_IMAGES:-True}"},{"line_number":561,"context_line":"if [[ \"$DOWNLOAD_DEFAULT_IMAGES\" \u003d\u003d \"True\" ]]; then"},{"line_number":562,"context_line":"    if [ -n $IMAGE_URLS ]; then"},{"line_number":563,"context_line":"        IMAGE_URLS+\u003d\",\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a50d1a3_d88b0a67","line":560,"updated":"2015-07-22 06:07:28.000000000","message":"please use trueorfalse\n\nplease separate it out into the globals section and document why you would want to disable DOWNLOAD_DEFAULT_IMAGES.  presumably you would be doing this to do something like test a new version of cirros so are happy to setup the image list by hand (although, you can just twiddle the version of that above...)","commit_id":"64ad2536a46b08e58f5e5235465822fc47dd6a59"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"7438cffdfb3b43b1ea08e1244410efedb4948444","unresolved":false,"context_lines":[{"line_number":557,"context_line":"# Set default image based on ``VIRT_DRIVER`` and ``LIBVIRT_TYPE``, either of"},{"line_number":558,"context_line":"# which may be set in ``local.conf``.  Also allow ``DEFAULT_IMAGE_NAME`` and"},{"line_number":559,"context_line":"# ``IMAGE_URLS`` to be set in the `localrc` section of ``local.conf``."},{"line_number":560,"context_line":"DOWNLOAD_DEFAULT_IMAGES\u003d${DOWNLOAD_DEFAULT_IMAGES:-True}"},{"line_number":561,"context_line":"if [[ \"$DOWNLOAD_DEFAULT_IMAGES\" \u003d\u003d \"True\" ]]; then"},{"line_number":562,"context_line":"    if [ -n $IMAGE_URLS ]; then"},{"line_number":563,"context_line":"        IMAGE_URLS+\u003d\",\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a50d1a3_a4337813","line":560,"in_reply_to":"3a50d1a3_d88b0a67","updated":"2015-07-22 07:38:09.000000000","message":"Agreed with the above - but I think that there are lots more uses for setting IMAGE_URLS.  We\u0027d like to use it to add more types of images to import in parallel for a custom test working with different image types.\nIn this case, DOWNLOAD_DEFAULT_IMAGES could be False as.","commit_id":"64ad2536a46b08e58f5e5235465822fc47dd6a59"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8e53caa3f44601613a596f0f8ee852ffa6aab0b9","unresolved":false,"context_lines":[{"line_number":610,"context_line":"fi"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"# Remove duplicated image urls"},{"line_number":613,"context_line":"IMAGE_URLS\u003d`echo $IMAGE_URLS | tr \u0027,\u0027 \u0027\\n\u0027 | sort | uniq | tr \u0027\\n\u0027 \u0027,\u0027`"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"# 10Gb default volume backing file size"},{"line_number":616,"context_line":"VOLUME_BACKING_FILE_SIZE\u003d${VOLUME_BACKING_FILE_SIZE:-10250M}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a50d1a3_788af61c","line":613,"updated":"2015-07-22 06:07:28.000000000","message":"As mentioned in the prior comment, not sure if this is needed.  the xen instructions should just remove the setting of IMAGE_URLS?","commit_id":"64ad2536a46b08e58f5e5235465822fc47dd6a59"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"7438cffdfb3b43b1ea08e1244410efedb4948444","unresolved":false,"context_lines":[{"line_number":610,"context_line":"fi"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"# Remove duplicated image urls"},{"line_number":613,"context_line":"IMAGE_URLS\u003d`echo $IMAGE_URLS | tr \u0027,\u0027 \u0027\\n\u0027 | sort | uniq | tr \u0027\\n\u0027 \u0027,\u0027`"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"# 10Gb default volume backing file size"},{"line_number":616,"context_line":"VOLUME_BACKING_FILE_SIZE\u003d${VOLUME_BACKING_FILE_SIZE:-10250M}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a50d1a3_671ed260","line":613,"in_reply_to":"3a50d1a3_788af61c","updated":"2015-07-22 07:38:09.000000000","message":"I think we need to ensure that stackrc doesn\u0027t break IMAGES_URL as it\u0027s opaque to debug.  From the error you get it isn\u0027t obvious that the problem is you added an image to localrc that you didn\u0027t need to add.\n\nI therefore argue that this line should be kept, then it doesn\u0027t matter if someone is following the instructions from xen\u0027s readme or John Doe\u0027s blog, or instructions that used to work (e.g. importing newer version of cirros for vsphere) now don\u0027t because we bumped the default version.","commit_id":"64ad2536a46b08e58f5e5235465822fc47dd6a59"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c3054b9f352c0ceba5b32b1de1909595fd154999","unresolved":false,"context_lines":[{"line_number":560,"context_line":"# Set default image based on ``VIRT_DRIVER`` and ``LIBVIRT_TYPE``, either of"},{"line_number":561,"context_line":"# which may be set in ``local.conf``.  Also allow ``DEFAULT_IMAGE_NAME`` and"},{"line_number":562,"context_line":"# ``IMAGE_URLS`` to be set in the `localrc` section of ``local.conf``."},{"line_number":563,"context_line":"DOWNLOAD_DEFAULT_IMAGES\u003d$(trueorfalse False DOWNLOAD_DEFAULT_IMAGES)"},{"line_number":564,"context_line":"if [[ \"$DOWNLOAD_DEFAULT_IMAGES\" \u003d\u003d \"True\" ]]; then"},{"line_number":565,"context_line":"    if [ -n $IMAGE_URLS ]; then"},{"line_number":566,"context_line":"        IMAGE_URLS+\u003d\",\""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"da20952f_35f3940c","line":563,"updated":"2015-08-27 05:37:42.000000000","message":"\"False\" isn\u0027t right here ... we want to download the default images","commit_id":"e8d03a81a1b219472737c30e13305c92bfe56b1c"}]}