)]}'
{"roles/sync-devstack-data/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6feb33c39a05bc5d9df608ee0cd7157b07226be0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    mode: 0755"},{"line_number":9,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Ensure the CA folder exists"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  file:"},{"line_number":14,"context_line":"    path: \"{{ devstack_base_dir }}/data/CA\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_27eb8adc","line":11,"updated":"2018-04-20 01:29:04.000000000","message":"this is the same thing but without the recurse?","commit_id":"72c4951ac2627dc574eeaf6b73954b99a4c6f1f6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"622fb4c0aa2426b38affdc84cce28be58d623c8c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- name: Ensure the CA folder has the correct permissions"},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  file:"},{"line_number":53,"context_line":"    path: \"{{ devstack_base_dir }}/data/CA\""},{"line_number":54,"context_line":"    state: directory"},{"line_number":55,"context_line":"    owner: stack"},{"line_number":56,"context_line":"    group: stack"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_02c4095e","line":53,"updated":"2019-06-12 10:17:57.000000000","message":"From the error\n\nhttp://logs.openstack.org/98/203698/15/check/devstack-multinode/053d26f/compute1/logs/devstacklog.txt.gz#_2019-06-04_21_38_21_110\n\nI\u0027d think you have to omit the \"/CA\" part.","commit_id":"bc63ac21a370f4dba677fc790f84285128ec811d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"690b722ffd7e5afbd7b4dda3562ab363692122e4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- name: Ensure the CA folder has the correct permissions"},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  file:"},{"line_number":53,"context_line":"    path: \"{{ devstack_base_dir }}/data\""},{"line_number":54,"context_line":"    state: directory"},{"line_number":55,"context_line":"    owner: stack"},{"line_number":56,"context_line":"    group: stack"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_fe55c0fa","line":53,"updated":"2019-06-12 21:48:29.000000000","message":"Actually you should reference devstack_data_base_dir here, like in the other tasks above. It defaults to devstack_base_dir, but might get overridden to some other value.","commit_id":"25ca17df0cf0c5dc996384983cc76ab3951783dd"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b7a5662b68354b13471dd6db5918188241adaec1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- name: Ensure the CA folder has the correct permissions"},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  file:"},{"line_number":53,"context_line":"    path: \"{{ devstack_base_dir }}/data\""},{"line_number":54,"context_line":"    state: directory"},{"line_number":55,"context_line":"    owner: stack"},{"line_number":56,"context_line":"    group: stack"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9fb8cfa7_d458d831","line":53,"in_reply_to":"9fb8cfa7_fe55c0fa","updated":"2019-06-13 08:34:50.000000000","message":"Done","commit_id":"25ca17df0cf0c5dc996384983cc76ab3951783dd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c4006607a386198cbb68bdc00b11c77a576b55f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Ensure the data folder exists"},{"line_number":2,"context_line":"  become: true"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ devstack_data_base_dir }}/data\""},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    owner: stack"},{"line_number":7,"context_line":"    group: stack"},{"line_number":8,"context_line":"    mode: 0755"},{"line_number":9,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Ensure the CA folder exists"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_671b1673","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":14},"updated":"2019-07-24 14:15:39.000000000","message":"this is ensuring the permission part so do we need the part you added ?","commit_id":"138d6bf54750debfd2a628cce6526f1433fb8041"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"9dc7c68c090d16aaf00b696bbad38dc6e40a9dc5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Ensure the data folder exists"},{"line_number":2,"context_line":"  become: true"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ devstack_data_base_dir }}/data\""},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    owner: stack"},{"line_number":7,"context_line":"    group: stack"},{"line_number":8,"context_line":"    mode: 0755"},{"line_number":9,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Ensure the CA folder exists"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_76016a04","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":14},"in_reply_to":"7faddb67_671b1673","updated":"2019-07-26 10:32:14.000000000","message":"Ah, no it does - it is missing \"recurse\", and the CA folder is created after it is run.\n\nI will remove this one, and then update the name of the one below, and that should fix it.","commit_id":"138d6bf54750debfd2a628cce6526f1433fb8041"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"fb32e6512141a9a2628c83dc93c3dbaeb48fd0b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Ensure the data folder exists"},{"line_number":2,"context_line":"  become: true"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ devstack_data_base_dir }}/data\""},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    owner: stack"},{"line_number":7,"context_line":"    group: stack"},{"line_number":8,"context_line":"    mode: 0755"},{"line_number":9,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Ensure the CA folder exists"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_b6b92216","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":14},"in_reply_to":"7faddb67_76016a04","updated":"2019-07-26 10:48:11.000000000","message":"ah, actually, no - both are needed. this ensures the dir exists so that it can have sub dirs and contents added, and the last one ensures the correct permissions are in place, so we need both.","commit_id":"138d6bf54750debfd2a628cce6526f1433fb8041"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cf74b83ccc8b632f4b3028a4cab8dc0c27ab2e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Ensure the data folder exists"},{"line_number":2,"context_line":"  become: true"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ devstack_data_base_dir }}/data\""},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    owner: stack"},{"line_number":7,"context_line":"    group: stack"},{"line_number":8,"context_line":"    mode: 0755"},{"line_number":9,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Ensure the CA folder exists"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_060eb68c","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":14},"in_reply_to":"7faddb67_b6b92216","updated":"2019-07-27 10:47:22.000000000","message":"yeah for subfolder we need to set permissions later which is clear now after clear \u0027name\u0027.","commit_id":"138d6bf54750debfd2a628cce6526f1433fb8041"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c4006607a386198cbb68bdc00b11c77a576b55f3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    mode: push"},{"line_number":48,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Ensure the CA folder has the correct permissions"},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  file:"},{"line_number":53,"context_line":"    path: \"{{ devstack_data_base_dir }}/data\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_a7110e56","line":50,"range":{"start_line":50,"start_character":19,"end_line":50,"end_character":28},"updated":"2019-07-24 14:15:39.000000000","message":"this is for complete data dir not just CA folder.","commit_id":"138d6bf54750debfd2a628cce6526f1433fb8041"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"6dda9601a8817cf0bbd9c4d453f7c54364ae7624","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    mode: push"},{"line_number":48,"context_line":"  when: \u0027inventory_hostname in groups[\"subnode\"]|default([])\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Ensure the CA folder has the correct permissions"},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  file:"},{"line_number":53,"context_line":"    path: \"{{ devstack_data_base_dir }}/data\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_76396aa1","line":50,"range":{"start_line":50,"start_character":19,"end_line":50,"end_character":28},"in_reply_to":"7faddb67_a7110e56","updated":"2019-07-26 10:48:27.000000000","message":"Done","commit_id":"138d6bf54750debfd2a628cce6526f1433fb8041"}],"stack.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71558bcd13045470e0bcb87fc929934951c9d567","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"# Create the destination directory and ensure it is writable by the user"},{"line_number":351,"context_line":"# and read/executable by everybody for daemons (e.g. apache run for horizon)"},{"line_number":352,"context_line":"# If file exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf659307_e437d1af","line":352,"updated":"2018-03-28 16:58:25.000000000","message":"s/file/directory/ ?","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d2981cabd192eed5a854b4142de95e2adceb3fba","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"# Create the destination directory and ensure it is writable by the user"},{"line_number":351,"context_line":"# and read/executable by everybody for daemons (e.g. apache run for horizon)"},{"line_number":352,"context_line":"# If file exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_9221dba2","line":352,"in_reply_to":"bf659307_e437d1af","updated":"2018-04-16 15:48:46.000000000","message":"Done","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71558bcd13045470e0bcb87fc929934951c9d567","unresolved":false,"context_lines":[{"line_number":350,"context_line":"# Create the destination directory and ensure it is writable by the user"},{"line_number":351,"context_line":"# and read/executable by everybody for daemons (e.g. apache run for horizon)"},{"line_number":352,"context_line":"# If file exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"},{"line_number":356,"context_line":"    safe_chmod 0755 $DEST"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf659307_e4d2715c","line":353,"updated":"2018-03-28 16:58:25.000000000","message":"This looks incomplete, \"-n\" only checks the length of the string. Also the :- doesn\u0027t do anything here, does it? How about\n\nif [[ -n $DEST \u0026\u0026 ! -d $DEST ]]; then","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d2981cabd192eed5a854b4142de95e2adceb3fba","unresolved":false,"context_lines":[{"line_number":350,"context_line":"# Create the destination directory and ensure it is writable by the user"},{"line_number":351,"context_line":"# and read/executable by everybody for daemons (e.g. apache run for horizon)"},{"line_number":352,"context_line":"# If file exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"},{"line_number":356,"context_line":"    safe_chmod 0755 $DEST"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_b2265fb7","line":353,"in_reply_to":"bf659307_e4d2715c","updated":"2018-04-16 15:48:46.000000000","message":"Done","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71558bcd13045470e0bcb87fc929934951c9d567","unresolved":false,"context_lines":[{"line_number":352,"context_line":"# If file exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"},{"line_number":356,"context_line":"    safe_chmod 0755 $DEST"},{"line_number":357,"context_line":"fi"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf659307_246e2995","line":355,"range":{"start_line":355,"start_character":15,"end_line":355,"end_character":17},"updated":"2018-03-28 16:58:25.000000000","message":"Since we can now be pretty sure that we only have the directory that we just created at this location, it should be safe to drop the \"-R\".","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d2981cabd192eed5a854b4142de95e2adceb3fba","unresolved":false,"context_lines":[{"line_number":352,"context_line":"# If file exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"},{"line_number":356,"context_line":"    safe_chmod 0755 $DEST"},{"line_number":357,"context_line":"fi"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_523b43d0","line":355,"range":{"start_line":355,"start_character":15,"end_line":355,"end_character":17},"in_reply_to":"bf659307_246e2995","updated":"2018-04-16 15:48:46.000000000","message":"Done","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71558bcd13045470e0bcb87fc929934951c9d567","unresolved":false,"context_lines":[{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"},{"line_number":356,"context_line":"    safe_chmod 0755 $DEST"},{"line_number":357,"context_line":"fi"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# Destination path for devstack logs"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf659307_c4e08dfd","line":356,"range":{"start_line":356,"start_character":4,"end_line":356,"end_character":25},"updated":"2018-03-28 16:58:25.000000000","message":"While we are at it, we might consider whether this is really useful. If we are really running with a umask that is more restrictive than 022, we are bound to run into trouble with all the files we will be creating later anyway, won\u0027t we?","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d2981cabd192eed5a854b4142de95e2adceb3fba","unresolved":false,"context_lines":[{"line_number":353,"context_line":"if [[ -n ${DEST:-} ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"},{"line_number":356,"context_line":"    safe_chmod 0755 $DEST"},{"line_number":357,"context_line":"fi"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# Destination path for devstack logs"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_1235cbda","line":356,"range":{"start_line":356,"start_character":4,"end_line":356,"end_character":25},"in_reply_to":"bf659307_c4e08dfd","updated":"2018-04-16 15:48:46.000000000","message":"I am not sure - I don\u0027t really know why this was added personally, but I can remove it if people are sure it is fine without it.","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71558bcd13045470e0bcb87fc929934951c9d567","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"# Destination path for service data"},{"line_number":365,"context_line":"DATA_DIR\u003d${DATA_DIR:-${DEST}/data}"},{"line_number":366,"context_line":"if [[ -n ${DATA_DIR:-} ]]; then"},{"line_number":367,"context_line":"    sudo mkdir -p $DATA_DIR"},{"line_number":368,"context_line":"    safe_chown -R $STACK_USER $DATA_DIR"},{"line_number":369,"context_line":"    safe_chmod 0755 $DATA_DIR"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf659307_44a8fd75","line":366,"updated":"2018-03-28 16:58:25.000000000","message":"Same as above, except I think the -n check isn\u0027t needed at all here.","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"d2981cabd192eed5a854b4142de95e2adceb3fba","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"# Destination path for service data"},{"line_number":365,"context_line":"DATA_DIR\u003d${DATA_DIR:-${DEST}/data}"},{"line_number":366,"context_line":"if [[ -n ${DATA_DIR:-} ]]; then"},{"line_number":367,"context_line":"    sudo mkdir -p $DATA_DIR"},{"line_number":368,"context_line":"    safe_chown -R $STACK_USER $DATA_DIR"},{"line_number":369,"context_line":"    safe_chmod 0755 $DATA_DIR"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f6a8fd7_d275139a","line":366,"in_reply_to":"bf659307_44a8fd75","updated":"2018-04-16 15:48:46.000000000","message":"I left in the check just to be sure, - I am not sure what happens if you have a DATA_DIR not in the default location","commit_id":"5a5ac29539adc562290411c7c23dc0777c2c3b38"},{"author":{"_account_id":12482,"name":"Noel McLoughlin","email":"noel.mcloughlin@gmail.com","username":"enoemcl"},"change_message_id":"02185d2cb13a0fe90c7640259f96cd6c7ec30473","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"# Create the destination directory and ensure it is writable by the user"},{"line_number":351,"context_line":"# and read/executable by everybody for daemons (e.g. apache run for horizon)"},{"line_number":352,"context_line":"# If directory exists do not modify the permissions."},{"line_number":353,"context_line":"if [[ ! -d $DEST ]]; then"},{"line_number":354,"context_line":"    sudo mkdir -p $DEST"},{"line_number":355,"context_line":"    safe_chown -R $STACK_USER $DEST"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3f79a3b5_f82ca2b2","line":352,"updated":"2018-11-30 20:05:27.000000000","message":"Just a minor comment.\n\nAnother option would be to only run chown if, and only if, touching a file in DEST fails?   \n\nAnd/or checking target file system type:\n\ndf -P -T / | tail -n +2 | awk \u0027{print $2}\u0027","commit_id":"371cf8f8875fed63d587e3c5d83df48d276ab370"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"690b722ffd7e5afbd7b4dda3562ab363692122e4","unresolved":false,"context_lines":[{"line_number":367,"context_line":"fi"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"# Destination path for devstack logs"},{"line_number":370,"context_line":"if [[  -n ${LOGDIR:-} ]]; then"},{"line_number":371,"context_line":"    mkdir -p $LOGDIR"},{"line_number":372,"context_line":"fi"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"9fb8cfa7_9e44c448","line":370,"updated":"2019-06-12 21:48:29.000000000","message":"This has crept in some time ago, but seems unrelated and unnecessary.","commit_id":"25ca17df0cf0c5dc996384983cc76ab3951783dd"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"b7a5662b68354b13471dd6db5918188241adaec1","unresolved":false,"context_lines":[{"line_number":367,"context_line":"fi"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"# Destination path for devstack logs"},{"line_number":370,"context_line":"if [[  -n ${LOGDIR:-} ]]; then"},{"line_number":371,"context_line":"    mkdir -p $LOGDIR"},{"line_number":372,"context_line":"fi"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"9fb8cfa7_b45524fc","line":370,"in_reply_to":"9fb8cfa7_9e44c448","updated":"2019-06-13 08:34:50.000000000","message":"Done","commit_id":"25ca17df0cf0c5dc996384983cc76ab3951783dd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"27650d45beccc6fffee05825190cbf0dfbc0ec89","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    LOGFILE_NAME\u003d\"${LOGFILE##*/}\"         # basename"},{"line_number":484,"context_line":"    mkdir -p $LOGFILE_DIR"},{"line_number":485,"context_line":"    find $LOGFILE_DIR -maxdepth 1 -name $LOGFILE_NAME.\\* -mtime +$LOGDAYS -exec rm {} \\;"},{"line_number":486,"context_line":"    LOGFILE\u003d$LOGFILE.${CURRENT_LOG_TIME}"},{"line_number":487,"context_line":"    SUMFILE\u003d$LOGFILE.summary.${CURRENT_LOG_TIME}"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    # Redirect output according to config"}],"source_content_type":"text/x-sh","patch_set":19,"id":"7faddb67_a85cec18","line":486,"updated":"2019-08-02 19:18:53.000000000","message":"I think you need to do the same here for bug 1838811.","commit_id":"352d58a7afd9e2261e639af78e4fb4c99d8f9f81"}]}