)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"658d7fc3fcd4ab5f9b937c22249a14a5b56b1678","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    echo $host_ip"},{"line_number":615,"context_line":"}"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"function check_host_ip {"},{"line_number":618,"context_line":"    local host_ip\u003d$1"},{"line_number":619,"context_line":"    local host_ip_iface\u003d$2"},{"line_number":620,"context_line":"    local af\u003d$3"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a50d1a3_e3b6a489","line":617,"updated":"2015-07-21 00:50:38.000000000","message":"function documentation please","commit_id":"b187084b8e5e7e96b7fbd27ddfcc814c50340c60"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bae76466a1b485e77ec98acd0205a52d5fd29204","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    local host_ip\u003d$1"},{"line_number":623,"context_line":"    local host_ip_iface\u003d$2"},{"line_number":624,"context_line":"    local af\u003d$3"},{"line_number":625,"context_line":"    host_ip_iface\u003d${host_ip_iface:-$(ip -f $af route | awk \u0027/default/ {print $5}\u0027 | head -1)}"},{"line_number":626,"context_line":"    for ip in $(get_host_ips \"$host_ip_iface\" \"$af\"); do"},{"line_number":627,"context_line":"        if [[ \"$ip\" \u003d\u003d \"$host_ip\" ]]; then"},{"line_number":628,"context_line":"            return"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a50d1a3_23d79724","line":625,"updated":"2015-07-21 10:24:24.000000000","message":"Why do you assume that HOST_IP needs to be on the same interface that the default route points to? I fail to see the reasoning for that. There could be the default route via eth0 and my HOST_IP existing on eth1.","commit_id":"97e1a199c4f992bb9d79d4bb10a030a814aba908"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3736d8f327cb7bbc47947d45a012bc2caba31454","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    local host_ip\u003d$1"},{"line_number":623,"context_line":"    local host_ip_iface\u003d$2"},{"line_number":624,"context_line":"    local af\u003d$3"},{"line_number":625,"context_line":"    host_ip_iface\u003d${host_ip_iface:-$(ip -f $af route | awk \u0027/default/ {print $5}\u0027 | head -1)}"},{"line_number":626,"context_line":"    for ip in $(get_host_ips \"$host_ip_iface\" \"$af\"); do"},{"line_number":627,"context_line":"        if [[ \"$ip\" \u003d\u003d \"$host_ip\" ]]; then"},{"line_number":628,"context_line":"            return"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a50d1a3_36f0ec90","line":625,"in_reply_to":"3a50d1a3_1848c15a","updated":"2015-07-22 12:39:47.000000000","message":"This is not true, if I set HOST_IP to an address on eth1 currently, stack.sh will just run fine. With your change, it will die.","commit_id":"97e1a199c4f992bb9d79d4bb10a030a814aba908"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"30e817bbbe375f74d6593d14fcf685f8bd6b9b9a","unresolved":false,"context_lines":[{"line_number":622,"context_line":"    local host_ip\u003d$1"},{"line_number":623,"context_line":"    local host_ip_iface\u003d$2"},{"line_number":624,"context_line":"    local af\u003d$3"},{"line_number":625,"context_line":"    host_ip_iface\u003d${host_ip_iface:-$(ip -f $af route | awk \u0027/default/ {print $5}\u0027 | head -1)}"},{"line_number":626,"context_line":"    for ip in $(get_host_ips \"$host_ip_iface\" \"$af\"); do"},{"line_number":627,"context_line":"        if [[ \"$ip\" \u003d\u003d \"$host_ip\" ]]; then"},{"line_number":628,"context_line":"            return"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a50d1a3_1848c15a","line":625,"in_reply_to":"3a50d1a3_23d79724","updated":"2015-07-21 12:58:46.000000000","message":"The code assumes that currently, that\u0027s not a new change.  If it\u0027s on a non-default-route interface, you have to specify HOST_IP_IFACE.","commit_id":"97e1a199c4f992bb9d79d4bb10a030a814aba908"}],"stack.sh":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6f721d83fcc925e0ac7298d07639c8e2ecfcfc73","unresolved":false,"context_lines":[{"line_number":117,"context_line":"# ``os_RELEASE``, ``os_UPDATE``, ``os_PACKAGE``, ``os_CODENAME``"},{"line_number":118,"context_line":"# and ``DISTRO``"},{"line_number":119,"context_line":"GetDistro"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Global Settings"},{"line_number":122,"context_line":"# ---------------"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a50d1a3_23cb3355","line":120,"updated":"2015-07-20 20:54:10.000000000","message":"oops","commit_id":"6717de68a264efeb7d7792fc5c8e4bfd36c56e76"}]}