)]}'
{"README.md":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8e52d20737f625d7996fd92990485aa609fc3c2d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"`local.conf`.  It is likely that you will need to provide and modify"},{"line_number":95,"context_line":"this file if you want anything other than the most basic setup.  Start"},{"line_number":96,"context_line":"by reading the [configuration guide](doc/source/configuration.rst) for"},{"line_number":97,"context_line":"details of the configuration file and the many available options."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":10,"id":"da20952f_a74812b4","line":97,"updated":"2015-09-01 04:04:36.000000000","message":"i think this got messed up in a rebase, please just remove the file from this change","commit_id":"ee8b169d4e5f3d47e8846df741b1f79a3e3a5744"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"69bdefe7d0019e72650fba8eabee0a5ffc1a9979","unresolved":false,"context_lines":[{"line_number":94,"context_line":"`local.conf`.  It is likely that you will need to provide and modify"},{"line_number":95,"context_line":"this file if you want anything other than the most basic setup.  Start"},{"line_number":96,"context_line":"by reading the [configuration guide](doc/source/configuration.rst) for"},{"line_number":97,"context_line":"details of the configuration file and the many available options."},{"line_number":98,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":10,"id":"da20952f_e0558bf9","line":97,"in_reply_to":"da20952f_a74812b4","updated":"2015-09-01 07:52:35.000000000","message":"Sure","commit_id":"ee8b169d4e5f3d47e8846df741b1f79a3e3a5744"}],"lib/cinder":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93f9f49413cf50e92add2701dd613069c8847a2c","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        s|%SSLCERTFILE%|$cinder_certfile|g;"},{"line_number":240,"context_line":"        s|%SSLKEYFILE%|$cinder_keyfile|g;"},{"line_number":241,"context_line":"        s|%USER%|$STACK_USER|g;"},{"line_number":242,"context_line":"        s|%VIRTUALENV%|$venv_path|g"},{"line_number":243,"context_line":"    \" -i $cinder_apache_conf"},{"line_number":244,"context_line":"}"},{"line_number":245,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a4dcd0f_76abc075","line":242,"range":{"start_line":242,"start_character":11,"end_line":242,"end_character":21},"updated":"2015-08-06 12:30:03.000000000","message":"This variable is unused. You don\u0027t have a %VIRTUALENV% placeholder in your apache-cinder-api.template.","commit_id":"bd9c16233c9a87bc7aa14603357299d26e90c7d9"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"17058b41bcd0fc577849ba25e68d0fd8806465ea","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        s|%SSLCERTFILE%|$cinder_certfile|g;"},{"line_number":240,"context_line":"        s|%SSLKEYFILE%|$cinder_keyfile|g;"},{"line_number":241,"context_line":"        s|%USER%|$STACK_USER|g;"},{"line_number":242,"context_line":"        s|%VIRTUALENV%|$venv_path|g"},{"line_number":243,"context_line":"    \" -i $cinder_apache_conf"},{"line_number":244,"context_line":"}"},{"line_number":245,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a4dcd0f_9653ec38","line":242,"in_reply_to":"1a4dcd0f_76abc075","updated":"2015-08-06 12:39:06.000000000","message":"thanks, missed it, I\u0027ll add it","commit_id":"bd9c16233c9a87bc7aa14603357299d26e90c7d9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"52a8a39eace0dde6558fffaf26d91295e031f6d9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    return 1"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# cleanup_apache_wsgi() - Remove wsgi files, disable and remove apache vhost file"},{"line_number":152,"context_line":"function cleanup_apache_wsgi {"},{"line_number":153,"context_line":"    sudo rm -f $CINDER_WSGI_DIR/*"},{"line_number":154,"context_line":"    sudo rm -f $(apache_site_config_for osapi-volume)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a4dcd0f_2b0b207f","line":151,"updated":"2015-08-10 02:38:30.000000000","message":"again private namespace","commit_id":"c39fa17a347cd2354a59eee3d97a633b59c7dcf2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2f6f24fbc24ef2b432c4d649f7cac280f720130b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    return 1"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# cleanup_apache_wsgi() - Remove wsgi files, disable and remove apache vhost file"},{"line_number":152,"context_line":"function cleanup_apache_wsgi {"},{"line_number":153,"context_line":"    sudo rm -f $CINDER_WSGI_DIR/*"},{"line_number":154,"context_line":"    sudo rm -f $(apache_site_config_for osapi-volume)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a4dcd0f_94fdac70","line":151,"in_reply_to":"1a4dcd0f_2b0b207f","updated":"2015-08-10 09:04:54.000000000","message":"I\u0027ll rename","commit_id":"c39fa17a347cd2354a59eee3d97a633b59c7dcf2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"52a8a39eace0dde6558fffaf26d91295e031f6d9","unresolved":false,"context_lines":[{"line_number":207,"context_line":"}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# config_apache_wsgi() - Set WSGI config files"},{"line_number":210,"context_line":"function config_apache_wsgi {"},{"line_number":211,"context_line":"    sudo mkdir -p $CINDER_WSGI_DIR"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    local cinder_apache_conf\u003d$(apache_site_config_for osapi-volume)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a4dcd0f_eb1f7807","line":210,"updated":"2015-08-10 02:38:30.000000000","message":"this should be something in a private namespace like _cinder_config_apache_wsgi","commit_id":"c39fa17a347cd2354a59eee3d97a633b59c7dcf2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2f6f24fbc24ef2b432c4d649f7cac280f720130b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# config_apache_wsgi() - Set WSGI config files"},{"line_number":210,"context_line":"function config_apache_wsgi {"},{"line_number":211,"context_line":"    sudo mkdir -p $CINDER_WSGI_DIR"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    local cinder_apache_conf\u003d$(apache_site_config_for osapi-volume)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a4dcd0f_9425ac5d","line":210,"in_reply_to":"1a4dcd0f_eb1f7807","updated":"2015-08-10 09:04:54.000000000","message":"sure, I\u0027ll rename","commit_id":"c39fa17a347cd2354a59eee3d97a633b59c7dcf2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"52a8a39eace0dde6558fffaf26d91295e031f6d9","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    local enabled_site_file\u003d$(apache_site_config_for osapi-volume)"},{"line_number":520,"context_line":"    if [ -f ${enabled_site_file} ] \u0026\u0026 [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":521,"context_line":"        enable_apache_site osapi-volume"},{"line_number":522,"context_line":"        restart_apache_server"},{"line_number":523,"context_line":"        tail_log c-api /var/log/$APACHE_NAME/c-api.log"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a4dcd0f_0be4240b","line":520,"updated":"2015-08-10 02:38:30.000000000","message":"what\u0027s the -f bit checking for?","commit_id":"c39fa17a347cd2354a59eee3d97a633b59c7dcf2"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2f6f24fbc24ef2b432c4d649f7cac280f720130b","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    local enabled_site_file\u003d$(apache_site_config_for osapi-volume)"},{"line_number":520,"context_line":"    if [ -f ${enabled_site_file} ] \u0026\u0026 [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":521,"context_line":"        enable_apache_site osapi-volume"},{"line_number":522,"context_line":"        restart_apache_server"},{"line_number":523,"context_line":"        tail_log c-api /var/log/$APACHE_NAME/c-api.log"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a4dcd0f_54d164fa","line":520,"in_reply_to":"1a4dcd0f_0be4240b","updated":"2015-08-10 09:04:54.000000000","message":"Check if cinder conf for apache exists","commit_id":"c39fa17a347cd2354a59eee3d97a633b59c7dcf2"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8f8cbc6e01514d5d57ad5a0f63a0c62f090c2a20","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    local enabled_site_file\u003d$(apache_site_config_for osapi-volume)"},{"line_number":520,"context_line":"    if [ -f ${enabled_site_file} ] \u0026\u0026 [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":521,"context_line":"        enable_apache_site osapi-volume"},{"line_number":522,"context_line":"        restart_apache_server"},{"line_number":523,"context_line":"        tail_log c-api /var/log/$APACHE_NAME/c-api.log"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1a4dcd0f_e7d3fbd3","line":520,"updated":"2015-08-10 23:28:57.000000000","message":"still not sure why we want this check in here?  if CINDER_USE_MOD_WSGI is true, then the apache config should be there; if it isn\u0027t that would be an error condition?","commit_id":"6dbeb9453b6cae51282a86ab5556404a24aa6b9a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"86b335458c88fe48d2956463727c89fe4df12167","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    local enabled_site_file\u003d$(apache_site_config_for osapi-volume)"},{"line_number":520,"context_line":"    if [ -f ${enabled_site_file} ] \u0026\u0026 [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":521,"context_line":"        enable_apache_site osapi-volume"},{"line_number":522,"context_line":"        restart_apache_server"},{"line_number":523,"context_line":"        tail_log c-api /var/log/$APACHE_NAME/c-api.log"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1a4dcd0f_9eca6319","line":520,"in_reply_to":"1a4dcd0f_748305cd","updated":"2015-08-11 12:01:19.000000000","message":"this case shouldn\u0027t happen; i think it\u0027s confusing to leave it here because it seems like it\u0027s added to handle some expected case","commit_id":"6dbeb9453b6cae51282a86ab5556404a24aa6b9a"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0c5f497398bb842208a473f446baf12d2dbdc0cc","unresolved":false,"context_lines":[{"line_number":517,"context_line":""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    local enabled_site_file\u003d$(apache_site_config_for osapi-volume)"},{"line_number":520,"context_line":"    if [ -f ${enabled_site_file} ] \u0026\u0026 [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":521,"context_line":"        enable_apache_site osapi-volume"},{"line_number":522,"context_line":"        restart_apache_server"},{"line_number":523,"context_line":"        tail_log c-api /var/log/$APACHE_NAME/c-api.log"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"1a4dcd0f_748305cd","line":520,"in_reply_to":"1a4dcd0f_e7d3fbd3","updated":"2015-08-11 07:56:02.000000000","message":"Yes, you are right, it would be error during apache start, if we want that I\u0027ll delete this check","commit_id":"6dbeb9453b6cae51282a86ab5556404a24aa6b9a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"58ede8e5a1b7a481eaf3864462097315fa13cc09","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    fi"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    # copy proxy vhost and wsgi helper files"},{"line_number":227,"context_line":"    sudo cp $CINDER_DIR/cinder/wsgi/wsgi.py $CINDER_WSGI_DIR/c-api"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    sudo cp $FILES/apache-cinder-api.template $cinder_apache_conf"},{"line_number":230,"context_line":"    sudo sed -e \""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ba15a1d1_ed22f8a2","line":227,"updated":"2015-09-22 11:38:22.000000000","message":"I don\u0027t want to add more wsgi bits in until things are using pbr wsgi_scripts to build standard wsgi entry points.","commit_id":"ee9a9338e73e923c048b3e06c48110c619c56814"}]}