)]}'
{"id":"openstack%2Fdevstack~2047","triplet_id":"openstack%2Fdevstack~master~Iaf9effcc7e0ea5cdfad7bb180e67089e7f8b3583","project":"openstack/devstack","branch":"master","topic":"fix-vg-clear","hashtags":[],"change_id":"Iaf9effcc7e0ea5cdfad7bb180e67089e7f8b3583","subject":"Clean out old volumes from an existing VOLUME_GROUP if present","status":"MERGED","created":"2011-12-02 20:11:30.000000000","updated":"2011-12-13 21:15:57.000000000","submitted":"2011-12-13 21:15:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"08b1316ed780ba7f156b20a165a5ac288af518ab","_number":2047,"virtual_id_number":2047,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":1,"date":"2011-12-13 21:15:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"all":[{"value":2,"date":"2011-12-13 21:15:52.000000000","_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":1,"date":"2011-12-12 22:32:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"date":"2011-12-13 21:15:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-12 22:32:51.000000000","updated_by":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"reviewer":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"state":"REVIEWER"},{"updated":"2011-12-13 21:15:52.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2011-12-13 21:15:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"776095f0a4387d3572f530a6d0341adc3bb59d5a","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-05 17:55:54.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"bb9bb3ba5cd2a5248239ca00b46d641676490c43","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-05 23:21:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0a528b816cb9fcb79458c00a5cf84154aef07d22","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2011-12-09 17:52:35.000000000","message":"Patch Set 2:\n\nIf we are going to use VOLUME_NAME_TEMPLATE, what do you think about taking it all the way and make use of:\n\nnova/db/api.py:flags.DEFINE_string(\u0027volume_name_template\u0027, \u0027volume-%08x\u0027,","accounts_in_message":[],"_revision_number":2},{"id":"bb2b8e797f29d96e8ebc99ffd9b849b4a125e22b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-09 18:16:59.000000000","message":"Patch Set 2:\n\nI\u0027m not sure how to get the default value for volume_name_template before nova starts running if it isn\u0027t in the flags file.  The alternative of always needing to set it in the flags file based on VOLUME_NAME_TEMPLATE occurred to me and is probably the right solution but it felt like overkill for something that will rarely be changed in practice.","accounts_in_message":[],"_revision_number":2},{"id":"c6e5a02d45ac7acd7fc0011710bac3afc51fa86d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2011-12-12 17:16:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4e9b21f81dc3cd057bf54e4115644bf0aae5b432","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2011-12-12 22:32:51.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nHey dean - I like the way you added the nova flag - kinda provides documentation for an otherwise obscure but important config option","accounts_in_message":[],"_revision_number":3},{"id":"fe5a322bab05b68dbba6898ccd5698e8c3367789","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-13 21:15:52.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"5593c35069d31b768bebe929f593721c166d5a94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-13 21:15:57.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-devstack-merge/28/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"77b9f1f8cd3a50be0ebf5c0d6ff637343b622dbc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-13 21:15:57.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2229a6e34b0c31994bb1ae5525708c55cdc6d28a","revisions":{"f2d143a89c4fcf4c69be93889684415857932be1":{"kind":"REWORK","_number":1,"created":"2011-12-02 20:11:30.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/47/2047/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/47/2047/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/47/2047/1"}}},"commit":{"parents":[{"commit":"ef4e5367d20cfeadb77e706bf81cd8401e36feb4","subject":"Allow individual services to specify dependencies.  Also fixes lp897879: https://bugs.launchpad.net/bugs/897879","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ef4e5367d20cfeadb77e706bf81cd8401e36feb4"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-01 23:02:07.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-02 20:09:47.000000000","tz":-360},"subject":"Clean out existing VOLUME_GROUP if present","message":"Clean out existing VOLUME_GROUP if present\n\nOn subsequent runs of stack.sh clean out the contents of $VOLUME_GROUP\nif it exists.  Also clean up the handling when using a backing file\nrather than a physical disk for the PV.\n\nChange-Id: Iaf9effcc7e0ea5cdfad7bb180e67089e7f8b3583\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2d143a89c4fcf4c69be93889684415857932be1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2d143a89c4fcf4c69be93889684415857932be1"}]},"branch":"refs/heads/master"},"ee44f1a393d39b8b054698f519404f81b5a9907e":{"kind":"REWORK","_number":2,"created":"2011-12-05 23:21:44.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/47/2047/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/47/2047/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/47/2047/2"}}},"commit":{"parents":[{"commit":"ef4e5367d20cfeadb77e706bf81cd8401e36feb4","subject":"Allow individual services to specify dependencies.  Also fixes lp897879: https://bugs.launchpad.net/bugs/897879","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ef4e5367d20cfeadb77e706bf81cd8401e36feb4"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-01 23:02:07.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-05 23:13:43.000000000","tz":-360},"subject":"Clean out old volumes from an existing VOLUME_GROUP if present","message":"Clean out old volumes from an existing VOLUME_GROUP if present\n\nOn subsequent runs of stack.sh clean out old volumes from $VOLUME_GROUP\n(if it exists) and remove the iSCSI targets.  Also clean up the handling\nwhen using a backing file rather than a physical disk for the PV.\n\nChange-Id: Iaf9effcc7e0ea5cdfad7bb180e67089e7f8b3583\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ee44f1a393d39b8b054698f519404f81b5a9907e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ee44f1a393d39b8b054698f519404f81b5a9907e"}]},"branch":"refs/heads/master"},"2229a6e34b0c31994bb1ae5525708c55cdc6d28a":{"kind":"REWORK","_number":3,"created":"2011-12-12 17:16:44.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/47/2047/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/47/2047/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/2047/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/47/2047/3"}}},"commit":{"parents":[{"commit":"30172cc8abf96ab5c47ecbb2b715548b4cec2d48","subject":"Merge \"Support rsyslog and RELP protocol\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/30172cc8abf96ab5c47ecbb2b715548b4cec2d48"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-01 23:02:07.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2011-12-12 17:15:53.000000000","tz":-360},"subject":"Clean out old volumes from an existing VOLUME_GROUP if present","message":"Clean out old volumes from an existing VOLUME_GROUP if present\n\nOn subsequent runs of stack.sh clean out old volumes from $VOLUME_GROUP\n(if it exists) and remove the iSCSI targets.  Also clean up the handling\nwhen using a backing file rather than a physical disk for the PV.\n\nVOLUME_NAME_PREFIX is used to determine which volumes to delete and to\nset volume_name_template in nova.conf.\n\nChange-Id: Iaf9effcc7e0ea5cdfad7bb180e67089e7f8b3583\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2229a6e34b0c31994bb1ae5525708c55cdc6d28a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2229a6e34b0c31994bb1ae5525708c55cdc6d28a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}