)]}'
{"id":"openstack%2Fdevstack~205901","triplet_id":"openstack%2Fdevstack~master~Ie98502e0747670eec468aad75b47d52961e674a6","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"Ie98502e0747670eec468aad75b47d52961e674a6","subject":"Set secret key for metadata access via md proxy","status":"ABANDONED","created":"2015-07-27 04:54:34.000000000","updated":"2015-07-30 08:34:08.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f12976c745f0fa9ca8c9b9433dff1ac78e1b1efe","_number":205901,"virtual_id_number":205901,"owner":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"date":"2015-07-29 12:11:35.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":1,"date":"2015-07-29 13:45:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},{"date":"2015-07-30 05:47:16.000000000","_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"all":[{"value":-1,"date":"2015-07-29 12:18:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2015-07-29 14:56:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":-1,"date":"2015-07-29 21:41:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-28 08:40:34.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-07-29 12:11:35.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-07-29 12:18:38.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2015-07-29 13:45:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-07-29 14:56:09.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2015-07-29 21:41:31.000000000","updated_by":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"reviewer":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"state":"REVIEWER"}],"messages":[{"id":"af7aa6474ad4fae14c4712d361a214d9d2bd8301","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-27 04:54:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08512ed7978f7af442272dcd75abbc0ef50136d6","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-27 05:54:39.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/01/205901/1/5821/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"97e4a655286d263f1bc320902e6f3e4b5a529781","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-27 05:54:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-full/77ca2c7/ : SUCCESS in 50m 43s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-postgres-full/31a55c3/ : SUCCESS in 51m 24s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-neutron-full/f86f104/ : SUCCESS in 1h 00m 01s\n- gate-grenade-dsvm http://logs.openstack.org/01/205901/1/check/gate-grenade-dsvm/908ce50/ : SUCCESS in 48m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-large-ops/c9d9699/ : SUCCESS in 26m 01s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-neutron-large-ops/e4a6678/ : SUCCESS in 38m 20s\n- gate-devstack-bashate http://logs.openstack.org/01/205901/1/check/gate-devstack-bashate/8bf0f98/ : SUCCESS in 23s\n- gate-devstack-unit-tests http://logs.openstack.org/01/205901/1/check/gate-devstack-unit-tests/ea86a6f/ : SUCCESS in 20s\n- gate-devstack-dsvm-cells http://logs.openstack.org/01/205901/1/check/gate-devstack-dsvm-cells/16ec247/ : SUCCESS in 29m 41s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/01/205901/1/check/gate-grenade-dsvm-partial-ncpu/67d2ccc/ : SUCCESS in 49m 40s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-ironic-pxe_ssh/74239fe/ : SUCCESS in 39m 18s\n- gate-devstack-dsvm-updown http://logs.openstack.org/01/205901/1/check/gate-devstack-dsvm-updown/eb3dadc/ : SUCCESS in 26m 40s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-f21/7a1bb2c/ : FAILURE in 52m 30s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-centos7/1412042/ : SUCCESS in 39m 41s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/01/205901/1/check/gate-devstack-publish-docs/a6ddc07//doc/build/html/ : SUCCESS in 1m 51s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/01/205901/1/check/gate-swift-dsvm-functional-nv/0116f28/ : SUCCESS in 31m 48s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/01/205901/1/check/gate-grenade-dsvm-neutron/ea90233/ : SUCCESS in 52m 58s\n- gate-tempest-dsvm-multinode-smoke http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-multinode-smoke/ee64b40/ : SUCCESS in 35m 47s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/01/205901/1/check/gate-tempest-dsvm-neutron-multinode-smoke/500b9ca/ : SUCCESS in 37m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"51aa42a394d95b5e173970aae4aecf475ede698b","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-07-27 07:25:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d2092426eb72bdd805e3d89a21ba30ef646ace8c","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-27 13:54:35.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73bcbaad9c389452012252fe959b79116cc0f1c5","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-27 14:00:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1a52a05f9d16ee276f2d8bc01451dfb362cd52d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-27 16:42:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-full/7122540/ : SUCCESS in 39m 33s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-postgres-full/f5c74e2/ : SUCCESS in 51m 52s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-neutron-full/6f45401/ : SUCCESS in 58m 33s\n- gate-grenade-dsvm http://logs.openstack.org/01/205901/2/check/gate-grenade-dsvm/00d3a34/ : SUCCESS in 49m 50s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-large-ops/08cb173/ : SUCCESS in 40m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-neutron-large-ops/6ac42ef/ : SUCCESS in 25m 39s\n- gate-devstack-bashate http://logs.openstack.org/01/205901/2/check/gate-devstack-bashate/8f188d0/ : SUCCESS in 17s\n- gate-devstack-unit-tests http://logs.openstack.org/01/205901/2/check/gate-devstack-unit-tests/5d22585/ : SUCCESS in 21s\n- gate-devstack-dsvm-cells http://logs.openstack.org/01/205901/2/check/gate-devstack-dsvm-cells/d619454/ : SUCCESS in 27m 16s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/01/205901/2/check/gate-grenade-dsvm-partial-ncpu/d913a2f/ : SUCCESS in 54m 19s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-ironic-pxe_ssh/c69bb55/ : SUCCESS in 51m 56s\n- gate-devstack-dsvm-updown http://logs.openstack.org/01/205901/2/check/gate-devstack-dsvm-updown/c7ee052/ : SUCCESS in 29m 56s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-f21/0cbdca5/ : FAILURE in 56m 07s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-centos7/53bb54d/ : SUCCESS in 37m 50s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/01/205901/2/check/gate-devstack-publish-docs/914ba36//doc/build/html/ : SUCCESS in 2m 50s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/01/205901/2/check/gate-swift-dsvm-functional-nv/b76e73f/ : SUCCESS in 32m 53s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/01/205901/2/check/gate-grenade-dsvm-neutron/a11c7e6/ : SUCCESS in 54m 07s\n- gate-tempest-dsvm-multinode-smoke http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-multinode-smoke/5fd133d/ : SUCCESS in 44m 08s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/01/205901/2/check/gate-tempest-dsvm-neutron-multinode-smoke/5697aec/ : SUCCESS in 46m 06s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4a43c3006aa696e6ab51b2d9aaca41842507532d","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-07-27 22:04:40.000000000","message":"Patch Set 2: Code-Review-1\n\nI guess that we don\u0027t need metadata_proxy_shared_secret variable. If users need it, they can set into local.conf.","accounts_in_message":[],"_revision_number":2},{"id":"53ad24166f83eaf7964340d479b92e416741e468","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-28 00:41:38.000000000","message":"Patch Set 2:\n\n\u003e Hirofumi Ichihara\n\u003e I guess that we don\u0027t need metadata_proxy_shared_secret variable. If users need it, they can set into local.conf.\n\nBut, \"If users need it, they can set into local.conf\", this is not the case as devstack doesn\u0027t provide a way to set this config w/o this patch. \n\nAre you suggesting to make it optional so it sets it only when you configure local.conf?","accounts_in_message":[],"_revision_number":2},{"id":"a15e3944da2544229819445912e7ee94160ff8d1","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-28 06:10:30.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/01/205901/2/5918/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":2},{"id":"a3dac7c0e9de8958c07c44eab502b8f1a0093432","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-07-28 07:40:13.000000000","message":"Patch Set 2:\n\nDevstack enable user to set any variable to config as described below.\n\n [[post-config|$Q_META_CONF_FILE]]\n [DEFAULT]\n metadata_proxy_shared_secret\u003dmd-shared-secret\n [[post-config|$NOVA_CONF]]\n [neutron]\n metadata_proxy_shared_secret\u003dmd-shared-secret","accounts_in_message":[],"_revision_number":2},{"id":"f233380210af78fde23a16cae45911d75b83d915","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-28 08:28:04.000000000","message":"Patch Set 2:\n\n\u003e Hirofumi Ichihara\n\nThanks for letting me know. I did not know that.\n\nI would still prefer to configure it by default to exercise the code path for this encryption logic so the code would  be executed at gates. \nRight now it is vulnerable for regressions.","accounts_in_message":[],"_revision_number":2},{"id":"019f746be89e12f7217d8f16eb269eebea2dddbf","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-07-28 08:40:34.000000000","message":"Patch Set 2: Code-Review-1\n\ni think it makes more sense to use a generated key\nas it isn\u0027t supposed to be manipulated by human beings at all.\n\n(grep generate_hex_string)","accounts_in_message":[],"_revision_number":2},{"id":"677e212744cc0662132cfb259b7336892f189ea2","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-07-28 14:36:56.000000000","message":"Patch Set 2:\n\nI\u0027m not sure why we need it in gate. The default value is empty in neutron. Should it be first set default value in neutron if we always need the configuration?","accounts_in_message":[],"_revision_number":2},{"id":"27d4da90f11bbb1963304f0f714464e337bee29c","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-29 04:27:05.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"195ff625e60fd4ceff672fb8ed4bf211143a0c02","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-29 12:11:35.000000000","message":"Patch Set 3:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/01/205901/3/6253/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":3},{"id":"e891cb461fa2a767e74af83723e1f2af0b41a6bc","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2015-07-29 12:18:38.000000000","message":"Patch Set 3: Code-Review-1\n\nThis may be a design question that is way after the fact, but why is this secret between Nova and Neutron being populated in config files? Isn\u0027t barbican supposed to be for this kind of thing? I\u0027d prefer to see this happen in Nova and Neutron rather than yet another config knob in DevStack","accounts_in_message":[],"_revision_number":3},{"id":"f109a67a27d2101d47979ae432e7dc9cd289bfff","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2015-07-29 12:22:31.000000000","message":"Patch Set 3:\n\nAnswering my own question - shared secret was waaaaay before Barbican came along.\n\nStill don\u0027t know if we benefit from more config knobs","accounts_in_message":[],"_revision_number":3},{"id":"292ec7e34eacca8ba5c4a57968f17f5e5666fe7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-29 13:45:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-full/2642fed/ : SUCCESS in 39m 16s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-postgres-full/e560333/ : SUCCESS in 36m 53s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-neutron-full/2fdbf70/ : SUCCESS in 49m 46s\n- gate-grenade-dsvm http://logs.openstack.org/01/205901/3/check/gate-grenade-dsvm/cc848a5/ : SUCCESS in 45m 52s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-large-ops/a7b0c7b/ : SUCCESS in 27m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-neutron-large-ops/2288632/ : SUCCESS in 25m 56s\n- gate-devstack-bashate http://logs.openstack.org/01/205901/3/check/gate-devstack-bashate/4d518ed/ : SUCCESS in 19s\n- gate-devstack-unit-tests http://logs.openstack.org/01/205901/3/check/gate-devstack-unit-tests/18e31e6/ : SUCCESS in 1m 14s\n- gate-devstack-dsvm-cells http://logs.openstack.org/01/205901/3/check/gate-devstack-dsvm-cells/47f12fa/ : SUCCESS in 22m 33s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/01/205901/3/check/gate-grenade-dsvm-partial-ncpu/ed29224/ : SUCCESS in 44m 07s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-ironic-pxe_ssh/9636aa1/ : SUCCESS in 41m 24s\n- gate-devstack-dsvm-updown http://logs.openstack.org/01/205901/3/check/gate-devstack-dsvm-updown/718d7ad/ : SUCCESS in 26m 32s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-f21/0ac25f5/ : FAILURE in 46m 26s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-centos7/c666c79/ : SUCCESS in 33m 43s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/01/205901/3/check/gate-devstack-publish-docs/cb382d8//doc/build/html/ : SUCCESS in 1m 50s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/01/205901/3/check/gate-swift-dsvm-functional-nv/a1b1ed4/ : SUCCESS in 26m 37s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/01/205901/3/check/gate-grenade-dsvm-neutron/b722f59/ : SUCCESS in 47m 29s\n- gate-tempest-dsvm-multinode-smoke http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-multinode-smoke/ad6ae7a/ : SUCCESS in 36m 16s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/01/205901/3/check/gate-tempest-dsvm-neutron-multinode-smoke/b018f32/ : SUCCESS in 48m 53s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"828fb060409575108dfdc077b328a82c1bb83fd9","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-07-29 14:56:09.000000000","message":"Patch Set 3: Code-Review-1\n\nI\u0027ve not gotten the necessity in devstack.","accounts_in_message":[],"_revision_number":3},{"id":"58283f63f7b72171d3f854b72d083f4c65f050bf","author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"date":"2015-07-29 21:41:31.000000000","message":"Patch Set 3: Code-Review-1\n\nIf we only want it exercised, let\u0027s just generate a random one each time. Then if a user actually wants to set it, they can use the local.conf method which would override it.\n\nThat way we avoid more options.","accounts_in_message":[],"_revision_number":3},{"id":"3873bdb656bba0603014c0269c8a71b0a8237d65","author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"date":"2015-07-29 21:50:09.000000000","message":"Patch Set 3:\n\nI meant, \"that way we don\u0027t* provide more options\"","accounts_in_message":[],"_revision_number":3},{"id":"19773baeaaf1db6f2649e21d762b0b145c6139f2","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-30 05:47:16.000000000","message":"Patch Set 3:\n\nThanks for all the comments. \n\ni response to these comments:\n\n\u003e Still don\u0027t know if we benefit from more config knobs\n\n\u003e I meant, \"that way we don\u0027t* provide more options\"\n\nThe latest patch populates nova.conf and metadata_agent.ini automatically with an auto generated secret string when you have q-meta enabled. Optionally you can configure the secret string with Q_META_SECRET env variable. \n\nActually, it was misleading that I said the code for [en|de]cryption is not exercised. It gets exercised with empty string (default value) as its secret. \n\nI thought it\u0027d be good and wouldn\u0027t hurt to have it configured with random string to exercise the code as having this configured should be a recommended setting.","accounts_in_message":[],"_revision_number":3},{"id":"13ae6131f2eb514f1a4fc44c5f12e735903cbdae","author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"date":"2015-07-30 05:58:38.000000000","message":"Patch Set 3:\n\nRight. I would vote for not having the Q_META_SECRET option though since people can use the local.conf method to override it if they want.","accounts_in_message":[],"_revision_number":3},{"id":"118cb0266cc1bf4a459bb25cca36715a2ba920a3","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-30 07:29:06.000000000","message":"Patch Set 3:\n\nKevin,\n\nWould you agree that this patch would be useful if the secret string is auto generated and not exposed as an option for devstack?","accounts_in_message":[],"_revision_number":3},{"id":"cf599094a4e32ce9b3a9de1a44cf79f1c1e1c84d","author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"date":"2015-07-30 07:39:35.000000000","message":"Patch Set 3:\n\nI see that even if it\u0027s blank, that\u0027s still treated as a secret and an hmac signature is generated based on that. So I\u0027m not sure it gains us much other than rotating the key.\n\nHowever, it does have a downside. Since it\u0027s randomly generated, a multi-node devstack setup will now break since each run will produce different keys.\n\nWith that in mind, I don\u0027t think it\u0027s a good idea to go forward with this.","accounts_in_message":[],"_revision_number":3},{"id":"e04c50987b6d86e4bb282dd9d9ac6f00546b00df","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-30 08:33:54.000000000","message":"Patch Set 3:\n\nAbandoning this change. Thanks guys for the feedback.","accounts_in_message":[],"_revision_number":3},{"id":"f12976c745f0fa9ca8c9b9433dff1ac78e1b1efe","author":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"date":"2015-07-30 08:34:08.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f56f6de914e87513e2f97018ff3fd4361264e82a","revisions":{"61f3c9da7ee1685f650a9601e519ff73652823c0":{"kind":"REWORK","_number":1,"created":"2015-07-27 04:54:34.000000000","uploader":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"ref":"refs/changes/01/205901/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/01/205901/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/01/205901/1"}}},"commit":{"parents":[{"commit":"c90656a4a3ca148cd3eec8b4792215f735f9c75d","subject":"Merge \"Explicitly set bind_ip in Swift server config files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c90656a4a3ca148cd3eec8b4792215f735f9c75d"}]}],"author":{"name":"Tomoe Sugihara","email":"tomoe@midokura.com","date":"2015-07-27 04:42:06.000000000","tz":0},"committer":{"name":"Tomoe Sugihara","email":"tomoe@midokura.com","date":"2015-07-27 04:54:19.000000000","tz":0},"subject":"Set secret key for metadata access via md proxy","message":"Set secret key for metadata access via md proxy\n\nBetween nova-api and neutron-metadata-agent, there\nis a mechanism to encrypt the data with\nshared secret. This patch sets a secret\nin nova.conf and metadata_agent.ini in order to\nexcercise the code path for the encryption.\n\nChange-Id: Ie98502e0747670eec468aad75b47d52961e674a6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/61f3c9da7ee1685f650a9601e519ff73652823c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/61f3c9da7ee1685f650a9601e519ff73652823c0"}]},"branch":"refs/heads/master"},"06bd8f356b7ba48ef5328e766bb7b70f702b422b":{"kind":"REWORK","_number":2,"created":"2015-07-27 14:00:31.000000000","uploader":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"ref":"refs/changes/01/205901/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/01/205901/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/01/205901/2"}}},"commit":{"parents":[{"commit":"c90656a4a3ca148cd3eec8b4792215f735f9c75d","subject":"Merge \"Explicitly set bind_ip in Swift server config files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c90656a4a3ca148cd3eec8b4792215f735f9c75d"}]}],"author":{"name":"Tomoe Sugihara","email":"tomoe@midokura.com","date":"2015-07-27 04:42:06.000000000","tz":0},"committer":{"name":"Tomoe Sugihara","email":"tomoe@midokura.com","date":"2015-07-27 13:59:12.000000000","tz":0},"subject":"Set secret key for metadata access via md proxy","message":"Set secret key for metadata access via md proxy\n\nBetween nova-api and neutron-metadata-agent, there\nis a mechanism to encrypt the data with\nshared secret. This patch sets a secret\nin nova.conf and metadata_agent.ini in order to\nexcercise the code path for the encryption.\n\nChange-Id: Ie98502e0747670eec468aad75b47d52961e674a6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/06bd8f356b7ba48ef5328e766bb7b70f702b422b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/06bd8f356b7ba48ef5328e766bb7b70f702b422b"}]},"branch":"refs/heads/master"},"f56f6de914e87513e2f97018ff3fd4361264e82a":{"kind":"REWORK","_number":3,"created":"2015-07-29 04:27:05.000000000","uploader":{"_account_id":1935,"name":"Tomoe Sugihara","email":"tomoe.sugihara@gmail.com","username":"tomoe"},"ref":"refs/changes/01/205901/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/01/205901/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/01/205901/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/01/205901/3"}}},"commit":{"parents":[{"commit":"c90656a4a3ca148cd3eec8b4792215f735f9c75d","subject":"Merge \"Explicitly set bind_ip in Swift server config files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c90656a4a3ca148cd3eec8b4792215f735f9c75d"}]}],"author":{"name":"Tomoe Sugihara","email":"tomoe@midokura.com","date":"2015-07-27 04:42:06.000000000","tz":0},"committer":{"name":"Tomoe Sugihara","email":"tomoe@midokura.com","date":"2015-07-29 04:22:21.000000000","tz":0},"subject":"Set secret key for metadata access via md proxy","message":"Set secret key for metadata access via md proxy\n\nBetween nova-api and neutron-metadata-agent, there\nis a mechanism to encrypt the data with\nshared secret. This patch sets a secret\nin nova.conf and metadata_agent.ini in order to\nexcercise the code path for the encryption.\n\nChange-Id: Ie98502e0747670eec468aad75b47d52961e674a6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f56f6de914e87513e2f97018ff3fd4361264e82a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f56f6de914e87513e2f97018ff3fd4361264e82a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}