)]}'
{"id":"openstack%2Fdevstack~206750","triplet_id":"openstack%2Fdevstack~master~Ifabfda444aed65467788b5e46a0cafe2a3b7883d","project":"openstack/devstack","branch":"master","topic":"bug/1479135","hashtags":[],"change_id":"Ifabfda444aed65467788b5e46a0cafe2a3b7883d","subject":"Add check for existing plugin","status":"ABANDONED","created":"2015-07-28 22:35:20.000000000","updated":"2015-08-07 15:11:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"be8e7514fa61c72f18e7587ebce45f0124963400","_number":206750,"virtual_id_number":206750,"owner":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"date":"2015-07-29 07:21:42.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-07-29 05:03:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-07-30 14:47:25.000000000","_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":1,"date":"2015-07-29 11:57:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":-1,"date":"2015-07-30 00:42:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-29 05:03:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-07-29 07:21:42.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-07-29 11:57:06.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2015-07-30 00:42:49.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"a96347166f662b908428cd8edd3f7ff0c77e9adc","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2015-07-28 22:35:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b19347a8e2b9bf5ff87086139c31e8c292628e20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-29 05:03:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-full/e173f2d/ : SUCCESS in 51m 24s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-postgres-full/5c4539d/ : SUCCESS in 49m 10s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-neutron-full/3ef1d8a/ : SUCCESS in 1h 02m 41s\n- gate-grenade-dsvm http://logs.openstack.org/50/206750/1/check/gate-grenade-dsvm/c430c50/ : SUCCESS in 46m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-large-ops/3ffd283/ : SUCCESS in 27m 15s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-neutron-large-ops/8b18a67/ : SUCCESS in 26m 01s\n- gate-devstack-bashate http://logs.openstack.org/50/206750/1/check/gate-devstack-bashate/db17ced/ : SUCCESS in 25s\n- gate-devstack-unit-tests http://logs.openstack.org/50/206750/1/check/gate-devstack-unit-tests/226619f/ : SUCCESS in 22s\n- gate-devstack-dsvm-cells http://logs.openstack.org/50/206750/1/check/gate-devstack-dsvm-cells/211c8f8/ : SUCCESS in 27m 43s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/50/206750/1/check/gate-grenade-dsvm-partial-ncpu/6e0018f/ : SUCCESS in 47m 56s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-ironic-pxe_ssh/16b2a6d/ : SUCCESS in 48m 32s\n- gate-devstack-dsvm-updown http://logs.openstack.org/50/206750/1/check/gate-devstack-dsvm-updown/1a6f9c5/ : SUCCESS in 27m 12s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-f21/03a695a/ : FAILURE in 46m 11s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-centos7/e45206c/ : SUCCESS in 36m 03s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/50/206750/1/check/gate-devstack-publish-docs/0084968//doc/build/html/ : SUCCESS in 1m 57s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/50/206750/1/check/gate-swift-dsvm-functional-nv/c5cb3ec/ : SUCCESS in 29m 42s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/50/206750/1/check/gate-grenade-dsvm-neutron/0c12892/ : SUCCESS in 45m 34s\n- gate-tempest-dsvm-multinode-smoke http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-multinode-smoke/d4a1cf3/ : SUCCESS in 34m 42s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-smoke http://logs.openstack.org/50/206750/1/check/gate-tempest-dsvm-neutron-multinode-smoke/13dd9a8/ : SUCCESS in 37m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"465170415a57040365ba78e1738ac22948b11d3f","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-07-29 07:21:42.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/50/206750/1/6209/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"6c7d0c5a65e14830bb22f7acd85574bb6eef4474","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2015-07-29 11:57:06.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"54a68fec566acf8788ae0b0ec7b310791ceaf9f4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-30 00:42:49.000000000","message":"Patch Set 1: Code-Review-1\n\nIt seems that calling it twice is really more of a mistake, and I feel like we\u0027d be better just die()ing with a clear error message.  This would also fail better if we ever get into a situation where two people write a plugin with the same name","accounts_in_message":[],"_revision_number":1},{"id":"853702e830b7af5eccde01ea6acc00d2e105899f","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2015-07-30 14:47:25.000000000","message":"Patch Set 1:\n\n@Ian: This was noticed as I was adding an \u0027override\u0027 section to a script (the override code being loaded from a different file).  Once the plugin was defined, there was no way to change it to a new set of values correctly (due to the issue described in the commit message).  I would have no problem putting a check in \u0027enable_plugin\u0027 to fail if defined multiple times, but then I\u0027d require a \u0027disable_plugin\u0027 function as well.  Would you be amenable to that?","accounts_in_message":[],"_revision_number":1},{"id":"367e78c4f5af22828a082b0e47b64e7fcb20186c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-07-30 23:00:15.000000000","message":"Patch Set 1:\n\nSorry if I\u0027m being dense, but I don\u0027t see how overriding variables fits with double invocations of \"enable_plugin\"?  Is this related to your other change If5a76360249827c19759a5c90dc00f70c59c32cc?","accounts_in_message":[],"_revision_number":1},{"id":"c70cf678f6389e7cad511e6d6e2b72a9eae0308f","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2015-08-07 15:11:52.000000000","message":"Abandoned\n\nMade changes to Trove plugin instead","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0067fc976cfa13273519dc3d4571e6b64207ba44","revisions":{"0067fc976cfa13273519dc3d4571e6b64207ba44":{"kind":"REWORK","_number":1,"created":"2015-07-28 22:35:20.000000000","uploader":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"ref":"refs/changes/50/206750/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/50/206750/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/50/206750/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/50/206750/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/50/206750/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/50/206750/1"}}},"commit":{"parents":[{"commit":"e0eb1a159f6545cf20d4db3d5f68bacd908fdde3","subject":"Merge \"Remove unused variable\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e0eb1a159f6545cf20d4db3d5f68bacd908fdde3"}]}],"author":{"name":"Peter Stachowski","email":"peter@tesora.com","date":"2015-07-28 22:31:39.000000000","tz":0},"committer":{"name":"Peter Stachowski","email":"peter@tesora.com","date":"2015-07-28 22:35:16.000000000","tz":0},"subject":"Add check for existing plugin","message":"Add check for existing plugin\n\nIf you call enable_plugin twice with the same name, the details are\nupdated correctly, however the plugin name gets added a second time to\nthe list.  This causes the plugin code to be executed twice and you\u0027ll\nend up with two sets of processes running.\n\nA check was added to enable_plugin so that the name only gets added\nto the list if it doesn\u0027t already exist.\n\nChange-Id: Ifabfda444aed65467788b5e46a0cafe2a3b7883d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0067fc976cfa13273519dc3d4571e6b64207ba44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0067fc976cfa13273519dc3d4571e6b64207ba44"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}