)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"112483c5f04ea95ef5213feb4aff04df37a9fdac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch copies os-brick\u0027s list of rootwrap filters for commands"},{"line_number":10,"context_line":"that are needed to execute from /usr/local/etc/os-brick/rootwrap.d"},{"line_number":11,"context_line":"to service\u0027s rootwrap.d directory to enable filters."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1479842"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_ab8147fd","line":12,"updated":"2015-08-10 18:31:54.000000000","message":"Would be good to note that this can\u0027t land until I2b1e657b87c7b27548200a20b991f34c3413c24b is merged and released and even then only after we bump the minimum required version of os-brick in global-requirements.","commit_id":"2790c20a8e9ac59ad55695649feea8ec2162cd59"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"21d4e8323e9df56a86859d11afb716fb4718d293","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch copies os-brick\u0027s list of rootwrap filters for commands"},{"line_number":10,"context_line":"that are needed to execute from /usr/local/etc/os-brick/rootwrap.d"},{"line_number":11,"context_line":"to service\u0027s rootwrap.d directory to enable filters."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1479842"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_74cc7c61","line":12,"in_reply_to":"1a4dcd0f_ab8147fd","updated":"2015-08-10 20:03:29.000000000","message":"Done","commit_id":"2790c20a8e9ac59ad55695649feea8ec2162cd59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"677125e09a03d0abbc59eb14d3a0ac17154d3e99","unresolved":false,"context_lines":[{"line_number":21,"context_line":"os-brick in global-requirements to be bumped to 0.4.0. That change"},{"line_number":22,"context_line":"I2f5ca36da2e5d84be260e32da269802993d7722f is merged as well."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partial-Bug: #1479842"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_e91d9873","line":24,"updated":"2015-09-06 13:49:05.000000000","message":"This could be Closes-Bug so that it closes out the devstack portion of the bug.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c5314361e63a618617636757b58574c42c2ac3b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"os-brick in global-requirements to be bumped to 0.4.0. That change"},{"line_number":22,"context_line":"I2f5ca36da2e5d84be260e32da269802993d7722f is merged as well."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partial-Bug: #1479842"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_b5c24433","line":24,"in_reply_to":"da20952f_153690e7","updated":"2015-09-08 21:11:14.000000000","message":"Sure, but the problem is getting the os-brick.filters into /etc/nova/rootwrap.d and /etc/cinder/rootwrap.d/, especially when os-brick is installed first since it\u0027s a dependency for both nova and cinder.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"449ad2e133b55e6c9c074a320c46d723fc2d34cf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"os-brick in global-requirements to be bumped to 0.4.0. That change"},{"line_number":22,"context_line":"I2f5ca36da2e5d84be260e32da269802993d7722f is merged as well."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partial-Bug: #1479842"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_153690e7","line":24,"in_reply_to":"da20952f_44fb4b79","updated":"2015-09-08 20:56:38.000000000","message":"You can package data files with pbr, the output dir is a bit weird because setuptools doesn\u0027t really do it well. Take a look at:\n\nhttp://docs.openstack.org/developer/pbr/#files","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"371ab76a6d31578b377b970362af283031dc6e4d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"os-brick in global-requirements to be bumped to 0.4.0. That change"},{"line_number":22,"context_line":"I2f5ca36da2e5d84be260e32da269802993d7722f is merged as well."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partial-Bug: #1479842"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_44fb4b79","line":24,"in_reply_to":"da20952f_84ae437f","updated":"2015-09-06 15:02:24.000000000","message":"We had talked about ways of trying to get this to automatically work but since pip doesn\u0027t install things to /etc and we can\u0027t assume people are using distro packages (debs/rpms), I think we\u0027re going to have to rely on deploy/config mgmt tooling like chef/puppet/ansible to copy this file over like we\u0027re doing in devstack.  I think this is actually the first case of a rootwrap filter being shared between libraries like this so there are probably better ways of sorting this out.  There was an oslo spec related to rootwrap mentioned in the bug report I think, but it\u0027s not mature yet.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"089f40c13cd9943fd66fc5b0a63daa16cba200e5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"os-brick in global-requirements to be bumped to 0.4.0. That change"},{"line_number":22,"context_line":"I2f5ca36da2e5d84be260e32da269802993d7722f is merged as well."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Partial-Bug: #1479842"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I9d77783c4cc8d8db7fff21543526fd4060f8b12b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_84ae437f","line":24,"in_reply_to":"da20952f_e91d9873","updated":"2015-09-06 14:54:02.000000000","message":"This addresses devstack usage, but I\u0027m still not clear on actual deployment scenarios.\n\nIt seems to me like consumers of the os-brick library need to be able to dynamically pull rootwrap filters in. Not clear yet what the best way would be to do that. Maybe some deployers can chime in.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"}],"inc/rootwrap":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56ea8f84788f8db9d56122dfb9293fbcd9600b6d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# configure_rootwrap lib"},{"line_number":83,"context_line":"function configure_rootwrap_lib {"},{"line_number":84,"context_line":"    local lib\u003d$1"},{"line_number":85,"context_line":"    local project\u003d$2"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_12c0c329","line":82,"updated":"2015-07-31 01:49:02.000000000","message":"Some more documentation on what this function is for and what the arguments are might be nice.","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"adba3984493aaf1def2631dd32739043d97964d1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# configure_rootwrap lib"},{"line_number":83,"context_line":"function configure_rootwrap_lib {"},{"line_number":84,"context_line":"    local lib\u003d$1"},{"line_number":85,"context_line":"    local project\u003d$2"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_1ff8a07b","line":82,"in_reply_to":"3a50d1a3_12c0c329","updated":"2015-07-31 21:40:30.000000000","message":"Done","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56ea8f84788f8db9d56122dfb9293fbcd9600b6d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"function configure_rootwrap_lib {"},{"line_number":84,"context_line":"    local lib\u003d$1"},{"line_number":85,"context_line":"    local project\u003d$2"},{"line_number":86,"context_line":"    local lib_dir\u003d\"/usr/local\""},{"line_number":87,"context_line":"    local rootwrap_conf_src_dir\u003d\"${lib_dir}/etc/${lib}\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_12ee83b4","line":86,"updated":"2015-07-31 01:49:02.000000000","message":"Seems you should be doing the same as the project_uc variable stuff in configure_rootwrap above.","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"adba3984493aaf1def2631dd32739043d97964d1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"function configure_rootwrap_lib {"},{"line_number":84,"context_line":"    local lib\u003d$1"},{"line_number":85,"context_line":"    local project\u003d$2"},{"line_number":86,"context_line":"    local lib_dir\u003d\"/usr/local\""},{"line_number":87,"context_line":"    local rootwrap_conf_src_dir\u003d\"${lib_dir}/etc/${lib}\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_1fcae04f","line":86,"in_reply_to":"3a50d1a3_12ee83b4","updated":"2015-07-31 21:40:30.000000000","message":"You are probably right, but I am not sure how to retrieve the etc install location dynamically.","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c5314361e63a618617636757b58574c42c2ac3b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# rootwrap filters from the library to the rootwrap filters directory"},{"line_number":85,"context_line":"# of the service."},{"line_number":86,"context_line":"function configure_rootwrap_lib {"},{"line_number":87,"context_line":"    local project\u003d$2"},{"line_number":88,"context_line":"    local lib\u003d$1"},{"line_number":89,"context_line":"    local rootwrap_conf_src_dir\u003d\"$DEST/${lib}/etc/${lib}\""},{"line_number":90,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"da20952f_55eac8ad","line":87,"updated":"2015-09-08 21:11:14.000000000","message":"Maybe rename the local variable \u0027project\u0027 as \u0027service\u0027 since os-brick is a project (and a library), and nova is a project - but not a library, it\u0027s a service.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f4b0d3eb20b3fa7909975f71964b7030df7b4afe","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# of the service."},{"line_number":86,"context_line":"function configure_rootwrap_lib {"},{"line_number":87,"context_line":"    local project\u003d$2"},{"line_number":88,"context_line":"    local lib\u003d$1"},{"line_number":89,"context_line":"    local rootwrap_conf_src_dir\u003d\"$DEST/${lib}/etc/${lib}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"da20952f_5512c80a","line":88,"updated":"2015-09-08 21:07:57.000000000","message":"ok, please never populate args in reverse order like this, this is all kinds of confusing to debug. This is a -1.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f4b0d3eb20b3fa7909975f71964b7030df7b4afe","unresolved":false,"context_lines":[{"line_number":86,"context_line":"function configure_rootwrap_lib {"},{"line_number":87,"context_line":"    local project\u003d$2"},{"line_number":88,"context_line":"    local lib\u003d$1"},{"line_number":89,"context_line":"    local rootwrap_conf_src_dir\u003d\"$DEST/${lib}/etc/${lib}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"},{"line_number":92,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"da20952f_358074f7","line":89,"range":{"start_line":89,"start_character":50,"end_line":89,"end_character":56},"updated":"2015-09-08 21:07:57.000000000","message":"this seems weird, that\u0027s a very oddly deep tree in a library, and not something I\u0027d like to make cannon via devstack.\n\netc/rootwrap/*.filters is fine, but please don\u0027t map a whole filesystem into here.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f55f97841693c87ffbc938367323ad9df78e8ff","unresolved":false,"context_lines":[{"line_number":86,"context_line":"function configure_rootwrap_lib {"},{"line_number":87,"context_line":"    local project\u003d$2"},{"line_number":88,"context_line":"    local lib\u003d$1"},{"line_number":89,"context_line":"    local rootwrap_conf_src_dir\u003d\"$DEST/${lib}/etc/${lib}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"},{"line_number":92,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"da20952f_55eba878","line":89,"in_reply_to":"da20952f_358074f7","updated":"2015-09-08 21:15:39.000000000","message":"I believe the filter was added in os-brick using the same structure as in cinder and nova - that\u0027s all:\n\nhttps://github.com/openstack/cinder/blob/master/etc/cinder/rootwrap.d/volume.filters\n\nhttps://github.com/openstack/cinder/blob/master/etc/cinder/rootwrap.d/volume.filters\n\nso etc/\u003cproject\u003e/rootwrap.d/*.filters","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"dc6e6464af52987f212bf59200f3cf935b344ba0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"function configure_rootwrap_lib {"},{"line_number":87,"context_line":"    local project\u003d$2"},{"line_number":88,"context_line":"    local lib\u003d$1"},{"line_number":89,"context_line":"    local rootwrap_conf_src_dir\u003d\"$DEST/${lib}/etc/${lib}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"},{"line_number":92,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"da20952f_9885f55a","line":89,"in_reply_to":"da20952f_55eba878","updated":"2015-09-08 21:24:50.000000000","message":"so, I think the problem I have is that this violates the principle of least surprise for users.\n\nCurrently there is an /etc/os-brick/rootwrap.d/*.filters in tree, and on the filesystem. However, /etc/os-brick/rootwrap.d/*.filter on the filesystem is vestigial. It does nothing. To an untrained user they would assume it was like other /etc/$foo/rootwrap.d/ directories, where they can change things, an stuff happens. But it isn\u0027t. So it\u0027s actively dangerous in building a correct system.\n\nBy similar reasoning, making the in tree bits look like an etc tree like that will make people think that their job is to copy it into that location, it looks like the nova location, so clearly it works that way. Except it doesn\u0027t.\n\nSo lets change the in tree os-brick location to etc/rootwrap/*filters (put a README.txt) in that directory to explain where you are supposed to install it into. Stop installing it in /etc/os-brick with PBR to get rid of that confusion. \n\nI do realize this requires another os-brick release, but I think it\u0027s important from a UX perspective, as this is going to be harder to undo once it\u0027s out there.","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e5c1f595db2b062c9d06a5bbf93083e59cafbed2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"function configure_rootwrap_lib {"},{"line_number":87,"context_line":"    local project\u003d$2"},{"line_number":88,"context_line":"    local lib\u003d$1"},{"line_number":89,"context_line":"    local rootwrap_conf_src_dir\u003d\"$DEST/${lib}/etc/${lib}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    sudo install -o root -g root -m 644 $rootwrap_conf_src_dir/rootwrap.d/*.filters /etc/${project}/rootwrap.d"},{"line_number":92,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"da20952f_44a9b48f","line":89,"in_reply_to":"da20952f_9885f55a","updated":"2015-09-09 00:11:57.000000000","message":"Here is the os-brick change:\n\nhttps://review.openstack.org/#/c/221513/","commit_id":"8284c94dd194e9407d5f3d850ec2040a2a2400a6"}],"lib/cinder":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"07e1d7110c9aee7b9d0303df20d79e26a7b9c8c1","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    rm -f $CINDER_CONF"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    configure_rootwrap cinder"},{"line_number":200,"context_line":"    configure_rootwrap os-brick cinder"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    cp $CINDER_DIR/etc/cinder/api-paste.ini $CINDER_API_PASTE_INI"},{"line_number":203,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_e7bc50dd","line":200,"updated":"2015-07-31 18:35:07.000000000","message":"you aren\u0027t calling your new function configure_rootwrap_lib","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"adba3984493aaf1def2631dd32739043d97964d1","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    rm -f $CINDER_CONF"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    configure_rootwrap cinder"},{"line_number":200,"context_line":"    configure_rootwrap os-brick cinder"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    cp $CINDER_DIR/etc/cinder/api-paste.ini $CINDER_API_PASTE_INI"},{"line_number":203,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_3ffd5c3b","line":200,"in_reply_to":"3a50d1a3_e7bc50dd","updated":"2015-07-31 21:40:30.000000000","message":"Good catch.  Fixed.","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5cb162fab9a1ad556817610a9e4cc64ef1f495e1","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    rm -f $CINDER_CONF"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    configure_rootwrap cinder"},{"line_number":200,"context_line":"    configure_rootwrap_lib os-brick cinder"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    cp $CINDER_DIR/etc/cinder/api-paste.ini $CINDER_API_PASTE_INI"},{"line_number":203,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a4dcd0f_4e49b1b6","line":200,"updated":"2015-08-10 19:11:08.000000000","message":"Fails:\n\nhttp://logs.openstack.org/53/207553/6/check/gate-tempest-dsvm-neutron-src-os-brick/ea93311/logs/devstacklog.txt.gz#_2015-08-10_19_03_54_437","commit_id":"2790c20a8e9ac59ad55695649feea8ec2162cd59"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"21d4e8323e9df56a86859d11afb716fb4718d293","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    rm -f $CINDER_CONF"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    configure_rootwrap cinder"},{"line_number":200,"context_line":"    configure_rootwrap_lib os-brick cinder"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    cp $CINDER_DIR/etc/cinder/api-paste.ini $CINDER_API_PASTE_INI"},{"line_number":203,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a4dcd0f_f4df2c0a","line":200,"in_reply_to":"1a4dcd0f_4e49b1b6","updated":"2015-08-10 20:03:29.000000000","message":"I think this will fail until Walt\u0027s patch got merged which will install \"/usr/local/etc/os-brick/rootwrap.d/*.filters\".\n\nhttps://review.openstack.org/#/c/207553/","commit_id":"2790c20a8e9ac59ad55695649feea8ec2162cd59"}],"lib/nova":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"07e1d7110c9aee7b9d0303df20d79e26a7b9c8c1","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    install_default_policy nova"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    configure_rootwrap nova"},{"line_number":311,"context_line":"    configure_rootwrap os-brick nova"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \"n-api\" ]]; then"},{"line_number":314,"context_line":"        # Get the sample configuration file in place"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_27c31859","line":311,"updated":"2015-07-31 18:35:07.000000000","message":"you aren\u0027t calling your new function configure_rootwrap_lib","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"adba3984493aaf1def2631dd32739043d97964d1","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    install_default_policy nova"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    configure_rootwrap nova"},{"line_number":311,"context_line":"    configure_rootwrap os-brick nova"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    if [[ \"$ENABLED_SERVICES\" \u003d~ \"n-api\" ]]; then"},{"line_number":314,"context_line":"        # Get the sample configuration file in place"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a50d1a3_bf972cea","line":311,"in_reply_to":"3a50d1a3_27c31859","updated":"2015-07-31 21:40:30.000000000","message":"Done","commit_id":"2818878249e154bcccc1f62a98141c6263eff518"}]}