)]}'
{"id":"openstack%2Fdevstack~2086","triplet_id":"openstack%2Fdevstack~master~I0793415fb03cc08d1eb1a3faf1b8ec3e723beb31","project":"openstack/devstack","branch":"master","topic":"mergeprop","hashtags":[],"change_id":"I0793415fb03cc08d1eb1a3faf1b8ec3e723beb31","subject":"support gerrit style refs/changes/... for branch names","status":"MERGED","created":"2011-12-05 21:38:34.000000000","updated":"2011-12-06 06:17:01.000000000","submitted":"2011-12-06 06:17:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b154668e683c0379db4a6b6eb348cef389402e2b","_number":2086,"virtual_id_number":2086,"owner":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":1,"date":"2011-12-06 06:17:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"recommended":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":0,"date":"2011-12-05 23:36:24.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":1,"date":"2011-12-05 23:54:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2011-12-06 06:16:56.000000000","_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"date":"2011-12-06 06:17:01.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-05 23:54:18.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2011-12-06 06:16:56.000000000","updated_by":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"reviewer":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"state":"REVIEWER"},{"updated":"2011-12-06 06:17:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fce6979ad7a20e9449a55b35ab4b27259bd1a89c","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-05 21:44:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5a56b458f304b05e823a1c2b31edccc4f073d1c2","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-05 22:57:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b2b34ce0626e68cc2a346794452f95a800845fc8","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-05 23:07:47.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"364e426bb075854aab881c155a6d99b606db2556","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2011-12-05 23:34:59.000000000","message":"Patch Set 4:\n\nThis will leave the git tree in detached head state, which is probably fine -- depends on whether the next thing you expect to do with the tree is throw it away, or commit a change.  \n\nHowever, if the use case for this is to test out a change, and possibly update it, then it may be worth having devstack simulate exactly what git-review would do in this case, including checking out onto a specially named branch, such that a subsequent git-review is run, it is uploaded with the same topic.\n\nOne way to implement this would be to use git-review.  Perhaps the following modification to this change:\n\nIf \u0027git-review\u0027 is in the path, use \"git review -d CHANGEID\" instead of the checkout/fetch, if not, leave the code as-is.\n\nI\u0027m not sure whether this is a use case you\u0027re targeting, and whether you would expect SSH keys, etc, to be available for git-review in the target environment.","accounts_in_message":[],"_revision_number":4},{"id":"d5fb97e372ecb9feb8747b6888c2ccaa8cdaa5f1","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2011-12-05 23:36:24.000000000","message":"Patch Set 4:\n\nJames,\n\nGood point.  Right now this is mostly for bots (jenkins) but using git-review would be more \"dev\" centered","accounts_in_message":[],"_revision_number":4},{"id":"b6d7f9c1c186e6ab0d9b3cc2334bebec299b2ec3","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2011-12-05 23:54:18.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nFor the CI jenkins, I took the approach of setting up the repos outside of devstack.  There\u0027s a small win in caching if you can avoid re-cloning them and instead just configure them appropriately and copy them over to the devstack environment.\n\nhttps://github.com/openstack/openstack-ci/blob/master/slave_scripts/devstack-vm-gate.sh","accounts_in_message":[],"_revision_number":4},{"id":"55580e429798e9c8da038efc196d8de613006c77","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2011-12-06 06:16:56.000000000","message":"Patch Set 4: Looks good to me, approved\n\nlgtm","accounts_in_message":[],"_revision_number":4},{"id":"7f2aa27ac3f7f43c26a57e142533abe7ac91d80f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-06 06:17:01.000000000","message":"Patch Set 4: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-devstack-merge/21/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"defd9e77f894d14e3d0f32c24b9399e11281308c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-06 06:17:01.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1a52a02f109b9c6a24a8ace789ce5f361b0c5bc7","revisions":{"de2f8f4ff17dde8bd46ac3469c9e34057369026e":{"kind":"REWORK","_number":1,"created":"2011-12-05 21:38:34.000000000","uploader":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"ref":"refs/changes/86/2086/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/86/2086/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/86/2086/1"}}},"commit":{"parents":[{"commit":"ef4e5367d20cfeadb77e706bf81cd8401e36feb4","subject":"Allow individual services to specify dependencies.  Also fixes lp897879: https://bugs.launchpad.net/bugs/897879","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ef4e5367d20cfeadb77e706bf81cd8401e36feb4"}]}],"author":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 21:38:29.000000000","tz":-480},"committer":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 21:38:33.000000000","tz":-480},"subject":"support gerrit style refs/changes/... for branch names","message":"support gerrit style refs/changes/... for branch names\n\nChange-Id: I0793415fb03cc08d1eb1a3faf1b8ec3e723beb31\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/de2f8f4ff17dde8bd46ac3469c9e34057369026e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/de2f8f4ff17dde8bd46ac3469c9e34057369026e"}]},"branch":"refs/heads/master"},"f2f99d69aa9b9492560623b107de83a1c63169b3":{"kind":"REWORK","_number":2,"created":"2011-12-05 21:44:08.000000000","uploader":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"ref":"refs/changes/86/2086/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/86/2086/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/86/2086/2"}}},"commit":{"parents":[{"commit":"ef4e5367d20cfeadb77e706bf81cd8401e36feb4","subject":"Allow individual services to specify dependencies.  Also fixes lp897879: https://bugs.launchpad.net/bugs/897879","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ef4e5367d20cfeadb77e706bf81cd8401e36feb4"}]}],"author":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 21:38:29.000000000","tz":-480},"committer":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 21:44:00.000000000","tz":-480},"subject":"support gerrit style refs/changes/... for branch names","message":"support gerrit style refs/changes/... for branch names\n\nChange-Id: I0793415fb03cc08d1eb1a3faf1b8ec3e723beb31\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2f99d69aa9b9492560623b107de83a1c63169b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f2f99d69aa9b9492560623b107de83a1c63169b3"}]},"branch":"refs/heads/master"},"1aad3f32122b304100dad5829d9422135bbe7774":{"kind":"REWORK","_number":3,"created":"2011-12-05 22:57:14.000000000","uploader":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"ref":"refs/changes/86/2086/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/86/2086/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/86/2086/3"}}},"commit":{"parents":[{"commit":"ef4e5367d20cfeadb77e706bf81cd8401e36feb4","subject":"Allow individual services to specify dependencies.  Also fixes lp897879: https://bugs.launchpad.net/bugs/897879","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ef4e5367d20cfeadb77e706bf81cd8401e36feb4"}]}],"author":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 21:38:29.000000000","tz":-480},"committer":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 22:57:04.000000000","tz":-480},"subject":"support gerrit style refs/changes/... for branch names","message":"support gerrit style refs/changes/... for branch names\n\nChange-Id: I0793415fb03cc08d1eb1a3faf1b8ec3e723beb31\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1aad3f32122b304100dad5829d9422135bbe7774"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1aad3f32122b304100dad5829d9422135bbe7774"}]},"branch":"refs/heads/master"},"1a52a02f109b9c6a24a8ace789ce5f361b0c5bc7":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2011-12-05 23:07:47.000000000","uploader":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"ref":"refs/changes/86/2086/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/86/2086/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/2086/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/86/2086/4"}}},"commit":{"parents":[{"commit":"ef4e5367d20cfeadb77e706bf81cd8401e36feb4","subject":"Allow individual services to specify dependencies.  Also fixes lp897879: https://bugs.launchpad.net/bugs/897879","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ef4e5367d20cfeadb77e706bf81cd8401e36feb4"}]}],"author":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 21:38:29.000000000","tz":-480},"committer":{"name":"Jesse Andrews","email":"anotherjesse@gmail.com","date":"2011-12-05 23:03:49.000000000","tz":-480},"subject":"support gerrit style refs/changes/... for branch names","message":"support gerrit style refs/changes/... for branch names\n\nTo use a gerrit \"branch\" with devstack I would find the repo/remote and\nset it for the specific project.\n\nExample: https://review.openstack.org/2059\n\nWould mean I update my localrc with the following settings:\n\nKEYSTONE_REPO\u003dhttps://review.openstack.org/p/openstack/keystone\nKEYSTONE_BRANCH\u003drefs/changes/59/2059/2\n\nChange-Id: I0793415fb03cc08d1eb1a3faf1b8ec3e723beb31\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1a52a02f109b9c6a24a8ace789ce5f361b0c5bc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1a52a02f109b9c6a24a8ace789ce5f361b0c5bc7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}