)]}'
{"id":"openstack%2Fdevstack~210645","triplet_id":"openstack%2Fdevstack~master~Iae0533cb71c7716c0cf1f8f37834102375845cbf","project":"openstack/devstack","branch":"master","topic":"add_physical_port_in_bridge","hashtags":[],"change_id":"Iae0533cb71c7716c0cf1f8f37834102375845cbf","subject":"Add physical guest interface in bridge for vlan or flat network","status":"ABANDONED","created":"2015-08-08 00:33:41.000000000","updated":"2015-09-10 18:38:18.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ca2958317e0d6b5a1ddc8b1ea090fdf7a4fbf3db","_number":210645,"virtual_id_number":210645,"owner":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"date":"2015-08-08 01:47:55.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":1,"date":"2015-08-08 01:43:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-08-10 18:39:09.000000000","_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"all":[{"value":-1,"date":"2015-08-10 10:48:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2015-08-11 02:44:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-08 01:43:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-08-08 01:47:55.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-08-10 10:48:02.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2015-08-11 02:44:13.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"}],"messages":[{"id":"0f59f582cd38701eb0979ae1d63c4b63f55ad004","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-08-08 00:33:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe865e11f4592f2bdfceca799af717e33a68b886","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-08 01:43:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-full/0ac63ca/ : SUCCESS in 44m 41s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-postgres-full/b716fa2/ : SUCCESS in 48m 10s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-neutron-full/dc2dab6/ : SUCCESS in 1h 09m 42s\n- gate-grenade-dsvm http://logs.openstack.org/45/210645/1/check/gate-grenade-dsvm/57ed226/ : SUCCESS in 42m 02s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-large-ops/32c0c22/ : SUCCESS in 27m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-neutron-large-ops/baa2d88/ : SUCCESS in 30m 01s\n- gate-devstack-bashate http://logs.openstack.org/45/210645/1/check/gate-devstack-bashate/d56fab2/ : SUCCESS in 32s\n- gate-devstack-unit-tests http://logs.openstack.org/45/210645/1/check/gate-devstack-unit-tests/811cfef/ : SUCCESS in 20s\n- gate-devstack-dsvm-cells http://logs.openstack.org/45/210645/1/check/gate-devstack-dsvm-cells/d87ff0d/ : SUCCESS in 23m 50s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/45/210645/1/check/gate-grenade-dsvm-partial-ncpu/2ae6037/ : SUCCESS in 47m 16s\n- gate-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-ironic-pxe_ssh/a80609c/ : SUCCESS in 38m 44s\n- gate-devstack-dsvm-updown http://logs.openstack.org/45/210645/1/check/gate-devstack-dsvm-updown/5510258/ : SUCCESS in 20m 17s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-f21/7f7dff1/ : FAILURE in 40m 33s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-centos7/0c3464c/ : SUCCESS in 31m 57s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/45/210645/1/check/gate-devstack-publish-docs/edd0671//doc/build/html/ : SUCCESS in 1m 49s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/45/210645/1/check/gate-swift-dsvm-functional-nv/d66bbdc/ : SUCCESS in 31m 36s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/45/210645/1/check/gate-grenade-dsvm-neutron/ba44ac6/ : SUCCESS in 53m 34s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-multinode-full/a71ddbb/ : SUCCESS in 55m 00s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/45/210645/1/check/gate-tempest-dsvm-neutron-multinode-full/d6d6c37/ : SUCCESS in 1h 04m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1ebe1761b2daddbc38b3ac520651820e5a4fb092","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-08-08 01:47:55.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/45/210645/1/7572/index.html\n\nUse \"xenserver: recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.\n\nDebugging suggestions at https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures","accounts_in_message":[],"_revision_number":1},{"id":"5af4697752b8d5591b72d8ee0dac9ad9a3f35c1e","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2015-08-10 10:48:02.000000000","message":"Patch Set 1: Code-Review-1\n\nAccording to the current code, GUEST_INTERFACE_DEFAULT is a xenserver only thing, at least in the Neutron code. It also creates a bridge device br-$GUEST_INTERFACE_DEFAULT and attaches the interface to it - it looks like you are creating a new behavior, when we already have some config knobs that you can use to attach an interface to OVS_PHYSICAL_BRIDGE when you want to use provider networking.\n\nhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/neutron-legacy#n715","accounts_in_message":[],"_revision_number":1},{"id":"3df7b8027c679b404f893d64da9980bb54944201","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-08-10 18:39:09.000000000","message":"Patch Set 1:\n\nYeah, it can achieve the same effect but I just find PUBLIC_INTERFACE not suitable to describe my purpose because what I was trying to do is use provider network for tenant network in VLAN mode while PUBLIC_INTERFACE is for external network if I understand correctly.","accounts_in_message":[],"_revision_number":1},{"id":"8d30e1740b1b1ddd5ef6ccdcfef76cb945b9e3bf","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-08-11 02:44:13.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI\u0027m not sure why you need to add GUEST_INTERFACE_DEFAULT into OVS_PHYSICAL_BRIDGE. Can you clarify the case?","accounts_in_message":[],"_revision_number":1},{"id":"f8f167fc5792026163e884b319a906277366f233","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-08-11 03:31:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"11980c5f89302b769c56a53d379b457b3c302dad","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-08-11 04:40:57.000000000","message":"Patch Set 1:\n\nThere are two points about this patch.\n\n1. GUEST_INTERFACE_DEFAULT already has been used by configuring nova-net or xenserver with neutron(not provider-network). When you add other sense to it, it would confuse users.\n2. Why don\u0027t you use PUBLIC_INTERFACE according with Sean\u0027s comment? Can you explain the reason well? Who uses GUEST_INTERFACE_DEFAULT even if devstack adds GUEST_INTERFACE_DEFAULT into OVS_PHYSICAL_BRIDGE?","accounts_in_message":[],"_revision_number":1},{"id":"7bbda16416f2b838c73791e0feca43124e385bdd","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-08-11 06:09:38.000000000","message":"Patch Set 1:\n\nI sure can use PUBLIC_INTERFACE, but the name is confusing for my purpose because I intend to use the interface for tenant network instead of public network.\nCould you explain the purpose of part:\n# Configure bridge manually with physical interface as port for multi-node\n_neutron_ovs_base_add_bridge $OVS_PHYSICAL_BRIDGE\n\nif you don\u0027t add port into bridge, what is the use of it?\n\nMoreover, be GUEST_INTERFACE_DEFAULT for xenserver, the code in lib/nova will overwrite the variable to the first interface rather than the value set in local.conf.","accounts_in_message":[],"_revision_number":1},{"id":"f7f1bf5f7bc0c669ba318bf90cf66766e8210095","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-08-12 01:25:07.000000000","message":"Patch Set 1:\n\nI\u0027m not sure your case. You want to use provider network, don\u0027t you? I think that provider network is different from tenant network. Do you mean that you want to add physical interface into OVS_PHYSICAL_BRIDGE for connecting external network in tenant network environments(not provider network)?\n\nCould you file your issues on Launchpad?","accounts_in_message":[],"_revision_number":1},{"id":"e23ecaaf8c0e317efa3b7de559c721e591deda74","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-08-12 02:42:23.000000000","message":"Patch Set 1:\n\nMy tenant network uses VLAN setup in the physical switch to isolate tenants instead of gre/vxlan tunnels, so that guests of the same tenant can communicate across different compute nodes.\nThis patch is not about external network.","accounts_in_message":[],"_revision_number":1},{"id":"f4a7fb6473a6108395ab0303d7f368e92940ea9b","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-08-12 04:25:35.000000000","message":"Patch Set 1:\n\nThe reason I am adding a physical interface for tenant network bridge is that I am using devstack for multinode deployment(multiple compute nodes and separate network node). I think this is where you are confused about why I am adding the physical interface after all.","accounts_in_message":[],"_revision_number":1},{"id":"c074da7cf95904c7a4f121a3a951c85dfc4226aa","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2015-09-10 18:38:18.000000000","message":"Abandoned\n\nuse public interface for the moment. may customize a devstack plugin for my use case if necessary.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e59ae91939b54dcbc85df5104f5d881248b5494","revisions":{"3e59ae91939b54dcbc85df5104f5d881248b5494":{"kind":"REWORK","_number":1,"created":"2015-08-08 00:33:41.000000000","uploader":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"ref":"refs/changes/45/210645/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/45/210645/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/45/210645/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/45/210645/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/45/210645/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/45/210645/1"}}},"commit":{"parents":[{"commit":"4627ac118350588ec56371f5fa9593c4c8e1ed9b","subject":"Merge \"Remove the old meter.yaml path from devstack\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4627ac118350588ec56371f5fa9593c4c8e1ed9b"}]}],"author":{"name":"Jerry Zhao","email":"xyzjerry@gmail.com","date":"2015-08-08 00:24:16.000000000","tz":-420},"committer":{"name":"Jerry Zhao","email":"xyzjerry@gmail.com","date":"2015-08-08 00:33:26.000000000","tz":-420},"subject":"Add physical guest interface in bridge for vlan or flat network","message":"Add physical guest interface in bridge for vlan or flat network\n\nThis change fixes the bug in lib/nova so as to honor the variable\nGUEST_INTERFACE_DEFAULT in local.conf, and add the physical interface\nas a port in the bridge.\n\nChange-Id: Iae0533cb71c7716c0cf1f8f37834102375845cbf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3e59ae91939b54dcbc85df5104f5d881248b5494"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3e59ae91939b54dcbc85df5104f5d881248b5494"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}