)]}'
{"lib/cinder":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"46cf13471d8899e7a944e399aebeff84da7420a4","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":391,"context_line":"            be_type\u003d${be%%:*}"},{"line_number":392,"context_line":"            be_name\u003d${be##*:}"},{"line_number":393,"context_line":"            restart_cinder_backend_${be_type} \u003e/dev/null 2\u003e\u00261 || true"},{"line_number":394,"context_line":"        done"},{"line_number":395,"context_line":"    fi"},{"line_number":396,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_5970e373","line":393,"updated":"2015-09-08 09:13:29.000000000","message":"Nits.\n\n* The errors (2) should not be blindly silenced.\n* The loop should not be repeated if you have multiple lvm backend.\n\n - Create set of enabled backend types , or maintain list of already processed types.\n - backend types without restart method should be skipped","commit_id":"7512588026ffb1c66a77bd175f7331af0687120f"}],"lib/lvm":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"46cf13471d8899e7a944e399aebeff84da7420a4","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"function restart_lvm_volume_group {"},{"line_number":131,"context_line":"    for backing_file in `ls ${DATA_DIR}/*${BACKING_FILE_SUFFIX}`; do"},{"line_number":132,"context_line":"        sudo losetup -a | grep $backing_file || sudo losetup -f --show $backing_file"},{"line_number":133,"context_line":"    done"},{"line_number":134,"context_line":"    sudo vgs"},{"line_number":135,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_c99662ef","line":132,"updated":"2015-09-08 09:13:29.000000000","message":"grep -q \"$backing_file\"","commit_id":"7512588026ffb1c66a77bd175f7331af0687120f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"46cf13471d8899e7a944e399aebeff84da7420a4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    for backing_file in `ls ${DATA_DIR}/*${BACKING_FILE_SUFFIX}`; do"},{"line_number":132,"context_line":"        sudo losetup -a | grep $backing_file || sudo losetup -f --show $backing_file"},{"line_number":133,"context_line":"    done"},{"line_number":134,"context_line":"    sudo vgs"},{"line_number":135,"context_line":"}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Sentinal value to ensure that init of default lvm volume group is"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da20952f_4979f2c6","line":134,"updated":"2015-09-08 09:13:29.000000000","message":"vgs also should be silent.","commit_id":"7512588026ffb1c66a77bd175f7331af0687120f"}],"rejoin-stack.sh":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"46cf13471d8899e7a944e399aebeff84da7420a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    if screen -ls | egrep -q \"[0-9].stack\"; then"},{"line_number":25,"context_line":"        echo \"Attaching to already started screen session..\""},{"line_number":26,"context_line":"        exec screen -r stack"},{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":"    exec screen -c $TOP_DIR/stack-screenrc"},{"line_number":29,"context_line":"fi"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da20952f_79e28703","line":27,"updated":"2015-09-08 09:13:29.000000000","message":"The cinder restart belongs here, \ndo it only when the screen session did not existed. (-1)","commit_id":"7512588026ffb1c66a77bd175f7331af0687120f"}]}