)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"22cf6506d8be45f7b5e914718ecbc301d0508d50","unresolved":false,"context_lines":[{"line_number":893,"context_line":"    # If needed, move config file from ``$NEUTRON_DIR/etc/neutron`` to ``NEUTRON_CONF_DIR``"},{"line_number":894,"context_line":"    mkdir -p /$Q_PLUGIN_CONF_PATH"},{"line_number":895,"context_line":"    Q_PLUGIN_CONF_FILE\u003d$Q_PLUGIN_CONF_PATH/$Q_PLUGIN_CONF_FILENAME"},{"line_number":896,"context_line":"    if [[ \"$Q_PLUGIN_REMOTE_SOURCE_DIR\" !\u003d \u0027\u0027 ]]; then"},{"line_number":897,"context_line":"        cp $Q_PLUGIN_REMOTE_SOURCE_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE"},{"line_number":898,"context_line":"    else"},{"line_number":899,"context_line":"        cp $NEUTRON_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_4cdb3422","line":896,"updated":"2015-08-14 03:38:10.000000000","message":"Just curious, does Q_PLUGIN_REMOTE_SOURCE_DIR include DEST as its prefix?\n\nIf so, what is your thought about separating them? For example, \n\ncp $DEST/$Q_PLUGIN_REMOTE_SOURCE_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE","commit_id":"6bbe7b53e459fcf80cd6d6356398245aa6c31478"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"a9f27bd49dd092d1336b85bb29b1c0435337e95d","unresolved":false,"context_lines":[{"line_number":893,"context_line":"    # If needed, move config file from ``$NEUTRON_DIR/etc/neutron`` to ``NEUTRON_CONF_DIR``"},{"line_number":894,"context_line":"    mkdir -p /$Q_PLUGIN_CONF_PATH"},{"line_number":895,"context_line":"    Q_PLUGIN_CONF_FILE\u003d$Q_PLUGIN_CONF_PATH/$Q_PLUGIN_CONF_FILENAME"},{"line_number":896,"context_line":"    if [[ \"$Q_PLUGIN_REMOTE_SOURCE_DIR\" !\u003d \u0027\u0027 ]]; then"},{"line_number":897,"context_line":"        cp $Q_PLUGIN_REMOTE_SOURCE_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE"},{"line_number":898,"context_line":"    else"},{"line_number":899,"context_line":"        cp $NEUTRON_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_f572dd48","line":896,"in_reply_to":"1a4dcd0f_4cdb3422","updated":"2015-08-24 11:23:57.000000000","message":"Hi Shih-Hao,\n\nIt very similar to neutron base directory. So it\u0027s the source directory. In this case, for example, it can be networking-plumgrid instead of Neutron. So this will work seamlessly for all sub-projects of Neutron as part of decomposition phase II.","commit_id":"6bbe7b53e459fcf80cd6d6356398245aa6c31478"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"6b5401a4d58793d37b2d064188998a59f999abe1","unresolved":false,"context_lines":[{"line_number":894,"context_line":"    mkdir -p /$Q_PLUGIN_CONF_PATH"},{"line_number":895,"context_line":"    Q_PLUGIN_CONF_FILE\u003d$Q_PLUGIN_CONF_PATH/$Q_PLUGIN_CONF_FILENAME"},{"line_number":896,"context_line":"    if [[ \"$Q_PLUGIN_REMOTE_SOURCE_DIR\" !\u003d \u0027\u0027 ]]; then"},{"line_number":897,"context_line":"        cp $Q_PLUGIN_REMOTE_SOURCE_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE"},{"line_number":898,"context_line":"    else"},{"line_number":899,"context_line":"        cp $NEUTRON_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE"},{"line_number":900,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_56caac1b","line":897,"updated":"2015-08-24 13:40:16.000000000","message":"I would prefer \n\ncp $Q_PLUGIN_REMOTE_SOURCE_DIR/$Q_PLUGIN_CONF_FILENAME /$Q_PLUGIN_CONF_FILE\n\nthan\n\ncp $Q_PLUGIN_REMOTE_SOURCE_DIR/$Q_PLUGIN_CONF_FILE /$Q_PLUGIN_CONF_FILE\n\nbecause the latter is forcing vendor repo to use the same subdirectory as neutron before decomposition, which may not be true for all vendors after decomposition.\n\nI have a similar change at\nhttps://review.openstack.org/#/c/212786/\nPlease consider that. Thanks.","commit_id":"6bbe7b53e459fcf80cd6d6356398245aa6c31478"}],"lib/neutron_plugins/README.md":[{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"956e88ee7be26333bdfb3df1252225604e65c831","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  install_package bridge-utils"},{"line_number":26,"context_line":"* ``neutron_plugin_configure_common`` :"},{"line_number":27,"context_line":"  set plugin-specific variables, ``Q_PLUGIN_CONF_PATH``, ``Q_PLUGIN_CONF_FILENAME``,"},{"line_number":28,"context_line":"  ``Q_PLUGIN_CLASS Q_PLUGIN_REMOTE_SOURCE_DIR``"},{"line_number":29,"context_line":"* ``neutron_plugin_configure_debug_command``"},{"line_number":30,"context_line":"* ``neutron_plugin_configure_dhcp_agent``"},{"line_number":31,"context_line":"* ``neutron_plugin_configure_l3_agent``"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"1a4dcd0f_99917cf4","line":28,"updated":"2015-08-14 03:05:33.000000000","message":"missing comma and quotes?\n\n``Q_PLUGIN_CLASS``, ``Q_PLUGIN_REMOTE_SOURCE_DIR``","commit_id":"6bbe7b53e459fcf80cd6d6356398245aa6c31478"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"5a5737fa2eb43db09dfea061266ff16c32b70900","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  install_package bridge-utils"},{"line_number":26,"context_line":"* ``neutron_plugin_configure_common`` :"},{"line_number":27,"context_line":"  set plugin-specific variables, ``Q_PLUGIN_CONF_PATH``, ``Q_PLUGIN_CONF_FILENAME``,"},{"line_number":28,"context_line":"  ``Q_PLUGIN_CLASS Q_PLUGIN_REMOTE_SOURCE_DIR``"},{"line_number":29,"context_line":"* ``neutron_plugin_configure_debug_command``"},{"line_number":30,"context_line":"* ``neutron_plugin_configure_dhcp_agent``"},{"line_number":31,"context_line":"* ``neutron_plugin_configure_l3_agent``"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"fa1b9901_b5e1c5d2","line":28,"in_reply_to":"1a4dcd0f_99917cf4","updated":"2015-08-24 11:24:37.000000000","message":"Ah, thanks for catching this. I have fixed this in the new patchset. .","commit_id":"6bbe7b53e459fcf80cd6d6356398245aa6c31478"}],"lib/neutron_plugins/plumgrid":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bbf720e05ab6dc5a5ab572ee12d82278b804e6ad","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return 1"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function has_neutron_plugin_security_group {"},{"line_number":50,"context_line":"    # return 0 means enabled"},{"line_number":51,"context_line":"    return 0"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_ea57bb57","side":"PARENT","line":49,"updated":"2015-08-13 05:27:07.000000000","message":"Unfortunately you cannot remove this method yet but I\u0027m proposing a patch to remove the restraint in https://review.openstack.org/#/c/204951/","commit_id":"2f605b0f4da2493d004b0893a850792ef20e13ec"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"4771cd2e104e68184d1b4456cc61a7c48e7ae737","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return 1"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function has_neutron_plugin_security_group {"},{"line_number":50,"context_line":"    # return 0 means enabled"},{"line_number":51,"context_line":"    return 0"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_011dd7bc","side":"PARENT","line":49,"in_reply_to":"1a4dcd0f_0d9a4162","updated":"2015-08-24 09:52:55.000000000","message":"Hi Hirofumi, I am not sure when you will commit get merged. This does not break DevStack for PLUMgrid. So please go ahead and re-review and remove the -1 if that\u0027s okay and we can proceed with rest of the decomposition process. Thanks!","commit_id":"2f605b0f4da2493d004b0893a850792ef20e13ec"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"7acd38a2ddc7764dab42c17f48842d52c318c443","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return 1"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function has_neutron_plugin_security_group {"},{"line_number":50,"context_line":"    # return 0 means enabled"},{"line_number":51,"context_line":"    return 0"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_0d9a4162","side":"PARENT","line":49,"in_reply_to":"1a4dcd0f_4dee0923","updated":"2015-08-13 05:59:33.000000000","message":"Nope, it didn\u0027t for me. Function is still sourced in remote plugin. Only the value will not get set properly. \n\nIn any case, let\u0027s wait for your commit to get merged. Thanks for taking care of this.","commit_id":"2f605b0f4da2493d004b0893a850792ef20e13ec"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e147dafa1ca0d83a1033a8bb0f2fa49590926b58","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return 1"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function has_neutron_plugin_security_group {"},{"line_number":50,"context_line":"    # return 0 means enabled"},{"line_number":51,"context_line":"    return 0"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_4dee0923","side":"PARENT","line":49,"in_reply_to":"1a4dcd0f_aa79b3c9","updated":"2015-08-13 05:46:57.000000000","message":"\u003e I was able to workaround this issue by setting sec group flag in the remote plugin\n\nIt doesn\u0027t solve the issue. Devstack would fail when stack.sh reads neutron-legacy because it cannot find has_neutron_plugin_security_group[1].\n\n[1]: https://github.com/openstack-dev/devstack/blob/master/lib/neutron-legacy#L355","commit_id":"2f605b0f4da2493d004b0893a850792ef20e13ec"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"a2f31c9618b24f7e7601761847fbff4fe000095d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    return 1"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"function has_neutron_plugin_security_group {"},{"line_number":50,"context_line":"    # return 0 means enabled"},{"line_number":51,"context_line":"    return 0"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_aa79b3c9","side":"PARENT","line":49,"in_reply_to":"1a4dcd0f_ea57bb57","updated":"2015-08-13 05:31:57.000000000","message":"I knew someone would fix it ;)\n\nBut this anyway doesn\u0027t affect me because I was able to workaround this issue by setting sec group flag in the remote plugin. Take a look at line #16 in [1]\n\n[1] https://review.openstack.org/#/c/211639/1/devstack/plugin.sh","commit_id":"2f605b0f4da2493d004b0893a850792ef20e13ec"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"da71bf48174b8e12e3219ca5e22fc22816fa1c9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# REVISIT(fawadkhaliq): This file is needed so Q_PLUGIN\u003dplumgrid can work."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba15a1d1_35722312","line":3,"updated":"2015-09-17 08:09:23.000000000","message":"This issue was removed by https://review.openstack.org/#/c/204956/\n\nDo you have other issue still?","commit_id":"2d832e051e7389ad17d9f703fe24d03f822675e2"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"292bfccc612b586a16ed562e72acfa14a0215e79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# REVISIT(fawadkhaliq): This file is needed so Q_PLUGIN\u003dplumgrid can work."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba15a1d1_308b116a","line":3,"in_reply_to":"ba15a1d1_35722312","updated":"2015-09-17 08:21:14.000000000","message":"Ah I see. I missed that commit somehow. Thanks. Removing it now.","commit_id":"2d832e051e7389ad17d9f703fe24d03f822675e2"}]}