)]}'
{"lib/ironic":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f78d11518e0f010ecfa1ff28b2d65a7bd093da1a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    return 1"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"# install_ironic_lib() - Collect sources and prepare"},{"line_number":185,"context_line":"function install_ironic_lib {"},{"line_number":186,"context_line":"    if use_library_from_git \"ironic-lib\"; then"},{"line_number":187,"context_line":"        git_clone_by_name \"ironic-lib\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_4289e16d","line":184,"updated":"2015-08-13 13:59:03.000000000","message":"nit: I\u0027m guessing this was a copy/paste. Seems like it should be s/sources/source/","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f78d11518e0f010ecfa1ff28b2d65a7bd093da1a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"function install_ironic_lib {"},{"line_number":186,"context_line":"    if use_library_from_git \"ironic-lib\"; then"},{"line_number":187,"context_line":"        git_clone_by_name \"ironic-lib\""},{"line_number":188,"context_line":"        setup_dev_lib \"ironic-lib\""},{"line_number":189,"context_line":"    fi"},{"line_number":190,"context_line":"}"},{"line_number":191,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_021759a3","line":188,"updated":"2015-08-13 13:59:03.000000000","message":"is ironic-lib name-spaced? If so, I think we should use \u0027setup_lib\u0027 (https://github.com/openstack-dev/devstack/blob/2d25c9290d163d682ae3958f0e09fede937c0f0f/inc/python#L164)","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2c76dc06b33d5992c9dae39c39c9b012a27a835f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"function install_ironic_lib {"},{"line_number":186,"context_line":"    if use_library_from_git \"ironic-lib\"; then"},{"line_number":187,"context_line":"        git_clone_by_name \"ironic-lib\""},{"line_number":188,"context_line":"        setup_dev_lib \"ironic-lib\""},{"line_number":189,"context_line":"    fi"},{"line_number":190,"context_line":"}"},{"line_number":191,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_a46aae7f","line":188,"in_reply_to":"1a4dcd0f_021759a3","updated":"2015-08-19 16:39:29.000000000","message":"I think ironic-lib is not namespaced, so using setup_dev_lib is better.","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"a00c9ec3f3e16abac762b010202ba11b222e4f21","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    if use_library_from_git \"ironic-lib\"; then"},{"line_number":187,"context_line":"        git_clone_by_name \"ironic-lib\""},{"line_number":188,"context_line":"        setup_dev_lib \"ironic-lib\""},{"line_number":189,"context_line":"    fi"},{"line_number":190,"context_line":"}"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"# install_ironic() - Collect source and prepare"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_33918af1","line":189,"updated":"2015-08-13 13:25:42.000000000","message":"Don\u0027t we need an else case to pip install the gr one ?","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a433fbef5118e3bc8608d22274cd0d5fb7b470bc","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    if use_library_from_git \"ironic-lib\"; then"},{"line_number":187,"context_line":"        git_clone_by_name \"ironic-lib\""},{"line_number":188,"context_line":"        setup_dev_lib \"ironic-lib\""},{"line_number":189,"context_line":"    fi"},{"line_number":190,"context_line":"}"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"# install_ironic() - Collect source and prepare"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_134fae92","line":189,"in_reply_to":"1a4dcd0f_33918af1","updated":"2015-08-13 13:27:24.000000000","message":"we expect ironic to pull it in as a dependency in this case","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"}],"stackrc":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f78d11518e0f010ecfa1ff28b2d65a7bd093da1a","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"##############"},{"line_number":258,"context_line":"#"},{"line_number":259,"context_line":"#  OpenStack Client Library Componets"},{"line_number":260,"context_line":"#"},{"line_number":261,"context_line":"##############"},{"line_number":262,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_ce443d74","line":259,"updated":"2015-08-13 13:59:03.000000000","message":"oh, typo. (outside scope of this patch)","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f78d11518e0f010ecfa1ff28b2d65a7bd093da1a","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# ironic common lib"},{"line_number":284,"context_line":"GITREPO[\"ironic-lib\"]\u003d${IRONIC_LIB_REPO:-${GIT_BASE}/openstack/ironic-lib.git}"},{"line_number":285,"context_line":"GITBRANCH[\"ironic-lib\"]\u003d${IRONIC_LIB_BRANCH:-master}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# the base authentication plugins that clients use to authenticate"},{"line_number":288,"context_line":"GITREPO[\"keystoneauth\"]\u003d${KEYSTONEAUTH_REPO:-${GIT_BASE}/openstack/keystoneauth.git}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a4dcd0f_8210494f","line":285,"updated":"2015-08-13 13:59:03.000000000","message":"There\u0027s a section below \u0027Libraries managed by OpenStack programs (non oslo)\u0027. Maybe this should go in that section.","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2c76dc06b33d5992c9dae39c39c9b012a27a835f","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# ironic common lib"},{"line_number":284,"context_line":"GITREPO[\"ironic-lib\"]\u003d${IRONIC_LIB_REPO:-${GIT_BASE}/openstack/ironic-lib.git}"},{"line_number":285,"context_line":"GITBRANCH[\"ironic-lib\"]\u003d${IRONIC_LIB_BRANCH:-master}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# the base authentication plugins that clients use to authenticate"},{"line_number":288,"context_line":"GITREPO[\"keystoneauth\"]\u003d${KEYSTONEAUTH_REPO:-${GIT_BASE}/openstack/keystoneauth.git}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_4412b20a","line":285,"in_reply_to":"1a4dcd0f_8210494f","updated":"2015-08-19 16:39:29.000000000","message":"Done","commit_id":"c8a1539359d2e8abd61e62ab275342deae0f02bf"}]}