)]}'
{"lib/quantum":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"707d259004ec2ffb176ddcf100745e24a7897f09","unresolved":false,"context_lines":[{"line_number":451,"context_line":"function _configure_quantum_l3_agent() {"},{"line_number":452,"context_line":"    Q_L3_ENABLED\u003dTrue"},{"line_number":453,"context_line":"    # for l3-agent, only use per tenant router if we have namespaces"},{"line_number":454,"context_line":"    Q_L3_ROUTER_PER_TENANT\u003d$Q_USE_NAMESPACE"},{"line_number":455,"context_line":"    AGENT_L3_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-l3-agent\""},{"line_number":456,"context_line":"    PUBLIC_BRIDGE\u003d${PUBLIC_BRIDGE:-br-ex}"},{"line_number":457,"context_line":"    Q_L3_CONF_FILE\u003d$QUANTUM_CONF_DIR/l3_agent.ini"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAM3%2F%2Bo6E%3D","line":454,"updated":"2013-02-23 18:38:18.000000000","message":"While I agree that these changes make sense, they are probably out of the scope of this bug","commit_id":"028d09c2f06f851cbc6fc69ef4b2487f4aaa5178"}],"lib/quantum_plugins/nicira":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6ed82fac70c64734c7da4903fea36bd387acbc05","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set +o xtrace"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"},{"line_number":9,"context_line":"    # NVP does not make part of the OVS family"},{"line_number":10,"context_line":"    return 1"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIdg%3D","line":9,"updated":"2013-02-06 02:30:15.000000000","message":"huh?","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"0215d41db091a66076f7018b49873e40fae13aec","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set +o xtrace"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"},{"line_number":9,"context_line":"    # NVP does not make part of the OVS family"},{"line_number":10,"context_line":"    return 1"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIbQ%3D","line":9,"in_reply_to":"AAAAM3%2F%2FIcU%3D","updated":"2013-02-06 02:39:44.000000000","message":"isn\u0027t this the flag used to determine if devstack should setup the integration bridge, etc?  If so, i think we should return 1.","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3cbba3e3041938f5a5f0b255f54b6952625f3ff9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set +o xtrace"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"},{"line_number":9,"context_line":"    # NVP does not make part of the OVS family"},{"line_number":10,"context_line":"    return 1"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIcU%3D","line":9,"in_reply_to":"AAAAM3%2F%2FIdg%3D","updated":"2013-02-06 02:35:52.000000000","message":"I meant family of plugins based on the ovs plugin.\nI will remove the cooment as it\u0027s misleading (and maybe return 0}","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6ed82fac70c64734c7da4903fea36bd387acbc05","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"function quantum_plugin_configure_l3_agent() {"},{"line_number":39,"context_line":"   # Nicira plugin does not run L3 agent"},{"line_number":40,"context_line":"   echo \"WARNING - q-l3 should not be executed with Nicira plugin!\""},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"function quantum_plugin_configure_plugin_agent() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIdQ%3D","line":40,"updated":"2013-02-06 02:30:15.000000000","message":"I almost wonder if we should fail here, not just warn.","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3cbba3e3041938f5a5f0b255f54b6952625f3ff9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"function quantum_plugin_configure_l3_agent() {"},{"line_number":39,"context_line":"   # Nicira plugin does not run L3 agent"},{"line_number":40,"context_line":"   echo \"WARNING - q-l3 should not be executed with Nicira plugin!\""},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"function quantum_plugin_configure_plugin_agent() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIcI%3D","line":40,"in_reply_to":"AAAAM3%2F%2FIdQ%3D","updated":"2013-02-06 02:35:52.000000000","message":"We should. I\u0027ll look for a nice and clean way to fail here","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6ed82fac70c64734c7da4903fea36bd387acbc05","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"function quantum_plugin_configure_plugin_agent() {"},{"line_number":44,"context_line":"   # Nicira plugin does not run L2 agent"},{"line_number":45,"context_line":"   echo \"WARNING - q-agt should not be executed with Nicira plugin!\""},{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function quantum_plugin_configure_service() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIdM%3D","line":45,"updated":"2013-02-06 02:30:15.000000000","message":"same.","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"6ed82fac70c64734c7da4903fea36bd387acbc05","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        if [[ \"$DEFAULT_TZ_UUID\" !\u003d \"\" ]]; then"},{"line_number":65,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" default_tz_uuid $DEFAULT_TZ_UUID"},{"line_number":66,"context_line":"        else"},{"line_number":67,"context_line":"            echo \"WARNING - The nicira plugin won\u0027t work properly without a default transport zone.\""},{"line_number":68,"context_line":"        fi"},{"line_number":69,"context_line":"        if [[ \"$DEFAULT_L3_GW_SVC_UUID\" !\u003d \"\" ]]; then"},{"line_number":70,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" default_l3_gw_service_uuid $DEFAULT_L3_GW_SVC_UUID"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2FIcs%3D","line":67,"updated":"2013-02-06 02:30:15.000000000","message":"same here, why not fail if it can\u0027t possibly work?","commit_id":"22151cddf498ad4cf1aeccfa4f9b147cc2415d99"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7388047e1904f527d1d386213127ba247c459556","unresolved":false,"context_lines":[{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function quantum_plugin_create_nova_conf() {"},{"line_number":14,"context_line":"    NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"nova.virt.libvirt.vif.LibvirtOpenVswitchDriver\"}"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function quantum_plugin_install_agent_packages() {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FCrg%3D","line":14,"updated":"2013-02-09 17:31:03.000000000","message":"Should this not be the hybrid one?","commit_id":"f9f84d919a69ecd7ea77eef1a63948888ece26a0"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"b72af618daa7bebdd257aba31eccdb7b2ca9b4be","unresolved":false,"context_lines":[{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function quantum_plugin_create_nova_conf() {"},{"line_number":14,"context_line":"    NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"nova.virt.libvirt.vif.LibvirtOpenVswitchDriver\"}"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function quantum_plugin_install_agent_packages() {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FCEY%3D","line":14,"in_reply_to":"AAAAM3%2F%2FCrg%3D","updated":"2013-02-10 19:47:15.000000000","message":"no, this is actually correct.  NVP does not use the hybrid driver.","commit_id":"f9f84d919a69ecd7ea77eef1a63948888ece26a0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7388047e1904f527d1d386213127ba247c459556","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    :"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":35,"context_line":"    :"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FCrc%3D","line":34,"updated":"2013-02-09 17:31:03.000000000","message":"Does this support dhcp agent?","commit_id":"f9f84d919a69ecd7ea77eef1a63948888ece26a0"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"b72af618daa7bebdd257aba31eccdb7b2ca9b4be","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    :"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":35,"context_line":"    :"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FCEU%3D","line":34,"in_reply_to":"AAAAM3%2F%2FCrc%3D","updated":"2013-02-10 19:47:15.000000000","message":"nvp plugin does support dhcp agent, but it seems like this method only needs content if there are non-standard options used.  ovs + linuxbridge plugin also have an empty method for this.","commit_id":"f9f84d919a69ecd7ea77eef1a63948888ece26a0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"75867beb93093bf02177fdddd70ba52fa5a2bae1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"},{"line_number":5,"context_line":"XTRACE\u003d$(set +o | grep xtrace)"},{"line_number":6,"context_line":"set +o xtrace"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FAcg%3D","line":5,"updated":"2013-02-11 20:26:56.000000000","message":"Please change XTRACE to MY_XTRACE so it doesn\u0027t stomp on the value set by lib/quantum","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a5921057a304d70f40dd82f66745399e1694c866","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"},{"line_number":5,"context_line":"XTRACE\u003d$(set +o | grep xtrace)"},{"line_number":6,"context_line":"set +o xtrace"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FAa4%3D","line":5,"in_reply_to":"AAAAM3%2F%2FAcg%3D","updated":"2013-02-11 20:34:07.000000000","message":"Done","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"dca7211a97f429f66ee354b31063618ad70dbe39","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"},{"line_number":9,"context_line":"    # NVP does not make part of the OVS family"},{"line_number":10,"context_line":"    return 1"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function quantum_plugin_create_nova_conf() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B17A%3D","line":10,"updated":"2013-02-17 19:12:15.000000000","message":"In my testing of this from a clean setup, i noticed that we do not properly create br-int, or call set-manager","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1f8158b1deae1e55fe4c723937b4db0bb142845a","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_quantum_ovs_base_plugin() {"},{"line_number":9,"context_line":"    # NVP does not make part of the OVS family"},{"line_number":10,"context_line":"    return 1"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"function quantum_plugin_create_nova_conf() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B1KY%3D","line":10,"in_reply_to":"AAAAM3%2F%2B17A%3D","updated":"2013-02-18 09:32:14.000000000","message":"Thanks for noticing this!","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fc886ebf8d614bb3d4ef9f05f83891230d09f079","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function quantum_plugin_configure_debug_command() {"},{"line_number":30,"context_line":"    # Debug agent not supported by nicira plugin"},{"line_number":31,"context_line":"    :"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2Frc%3D","line":30,"updated":"2013-02-12 05:45:59.000000000","message":"why not?","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"cd3259a251af8fc68bac2aa2e29458dd3a298e6d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function quantum_plugin_configure_debug_command() {"},{"line_number":30,"context_line":"    # Debug agent not supported by nicira plugin"},{"line_number":31,"context_line":"    :"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2B0c%3D","line":30,"in_reply_to":"AAAAM3%2F%2B%2Frc%3D","updated":"2013-02-12 16:07:58.000000000","message":"Because I don\u0027t know how to make it work with NVP plugin. It might be trivial, but then if I have not tested it I cant say the devstack patch allows you to use the debug agent.","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fc886ebf8d614bb3d4ef9f05f83891230d09f079","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":35,"context_line":"    :"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"function quantum_plugin_configure_l3_agent() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2FrU%3D","line":35,"updated":"2013-02-12 05:45:59.000000000","message":"This might be obvious but what is :   ?","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"cd3259a251af8fc68bac2aa2e29458dd3a298e6d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":35,"context_line":"    :"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"function quantum_plugin_configure_l3_agent() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2B0Y%3D","line":35,"in_reply_to":"AAAAM3%2F%2B%2FrU%3D","updated":"2013-02-12 16:07:58.000000000","message":"noop","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fc886ebf8d614bb3d4ef9f05f83891230d09f079","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else"},{"line_number":75,"context_line":"            echo \"WARNING - The nicira plugin needs a default l3 gw service for running the Quantum l3 APIs.\""},{"line_number":76,"context_line":"        fi"},{"line_number":77,"context_line":"        NVP_USER\u003d${NVP_USER:-\"admin\"}"},{"line_number":78,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" nvp_user $NVP_USER"},{"line_number":79,"context_line":"        # Do not set default for NVP password"},{"line_number":80,"context_line":"        if [[ \"$NVP_PASSWORD\" !\u003d \"\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2FrQ%3D","line":77,"updated":"2013-02-12 05:45:59.000000000","message":"nit: consider moving all variables like this to the top so that they can all be set in one places.","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"cd3259a251af8fc68bac2aa2e29458dd3a298e6d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        else"},{"line_number":75,"context_line":"            echo \"WARNING - The nicira plugin needs a default l3 gw service for running the Quantum l3 APIs.\""},{"line_number":76,"context_line":"        fi"},{"line_number":77,"context_line":"        NVP_USER\u003d${NVP_USER:-\"admin\"}"},{"line_number":78,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" nvp_user $NVP_USER"},{"line_number":79,"context_line":"        # Do not set default for NVP password"},{"line_number":80,"context_line":"        if [[ \"$NVP_PASSWORD\" !\u003d \"\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2B0I%3D","line":77,"in_reply_to":"AAAAM3%2F%2B%2FrQ%3D","updated":"2013-02-12 16:07:58.000000000","message":"Done","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"79f5eaf4c53232db87dc6bb81bb8765151a5bb6b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        else"},{"line_number":83,"context_line":"            echo \"WARNING - NVP controller password not specified. Will use default.\""},{"line_number":84,"context_line":"        fi"},{"line_number":85,"context_line":"        NVP_REQ_TIMEOUT\u003d${NVP_REQ_TIMEOUT:-\"30\"}"},{"line_number":86,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" req_timeout $NVP_REQ_TIMEOUT"},{"line_number":87,"context_line":"        NVP_HTTP_TIMEOUT\u003d${NVP_HTTP_TIMEOUT:-\"10\"}"},{"line_number":88,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" http_timeout $NVP_HTTP_TIMEOUT"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2B%2Bzc%3D","line":85,"updated":"2013-02-12 16:10:55.000000000","message":"Actually we should not do this. Because this will add stuff in the conf file while what we want is for the option to be set only if specified.\nIf not, quantum will use the default anyway.","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"75867beb93093bf02177fdddd70ba52fa5a2bae1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Restore xtrace"},{"line_number":112,"context_line":"$XTRACE"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FAcc%3D","line":112,"updated":"2013-02-11 20:26:56.000000000","message":"Also change to $MY_XTRACE","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a5921057a304d70f40dd82f66745399e1694c866","unresolved":false,"context_lines":[{"line_number":109,"context_line":"}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Restore xtrace"},{"line_number":112,"context_line":"$XTRACE"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FAa8%3D","line":112,"in_reply_to":"AAAAM3%2F%2FAcc%3D","updated":"2013-02-11 20:34:07.000000000","message":"Done","commit_id":"93fde5aae70b22d6ecc52cb9dc8caee8de56225e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c202efaeb278117a3f6decc3cbc7b8486c82483","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\t\t\techo \"Error - No controller specified. Unable to set a manager for OVS\""},{"line_number":32,"context_line":"\t\t\texit 1"},{"line_number":33,"context_line":"\t\tfi"},{"line_number":34,"context_line":"\t\tsudo ovs-vsctl set-manager $OVS_MANAGER"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2BpCw%3D","line":34,"updated":"2013-02-23 16:13:07.000000000","message":"tabs + whitespace above.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\t\t\techo \"Error - No controller specified. Unable to set a manager for OVS\""},{"line_number":32,"context_line":"\t\t\texit 1"},{"line_number":33,"context_line":"\t\tfi"},{"line_number":34,"context_line":"\t\tsudo ovs-vsctl set-manager $OVS_MANAGER"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo7c%3D","line":34,"in_reply_to":"AAAAM3%2F%2BpCw%3D","updated":"2013-02-23 18:26:48.000000000","message":"Yeah I did not mean to push this code.\nI hit git review instead of git push to another git server for testing","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c202efaeb278117a3f6decc3cbc7b8486c82483","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":55,"context_line":"    :"},{"line_number":56,"context_line":"    # how to ensure br-int is configured?"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function quantum_plugin_configure_l3_agent() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2BpCI%3D","line":56,"updated":"2013-02-23 16:13:07.000000000","message":"that\u0027s a good question.  We should probably exact some of the logic above into a \"setup NVP transport node\" method, which we call if in this method as well.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":55,"context_line":"    :"},{"line_number":56,"context_line":"    # how to ensure br-int is configured?"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function quantum_plugin_configure_l3_agent() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo7M%3D","line":56,"in_reply_to":"AAAAM3%2F%2BpCI%3D","updated":"2013-02-23 18:26:48.000000000","message":"Sounds the right thing to do","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c202efaeb278117a3f6decc3cbc7b8486c82483","unresolved":false,"context_lines":[{"line_number":54,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":55,"context_line":"    :"},{"line_number":56,"context_line":"    # how to ensure br-int is configured?"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function quantum_plugin_configure_l3_agent() {"},{"line_number":60,"context_line":"   # Nicira plugin does not run L3 agent"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2BpBs%3D","line":57,"updated":"2013-02-23 16:13:07.000000000","message":"+    iniset $Q_DHCP_CONF_FILE DEFAULT enable_isolated_metadata True\n+    iniset $Q_DHCP_CONF_FILE DEFAULT enable_metadata_network True\n\nfor metadata support.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":54,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":55,"context_line":"    :"},{"line_number":56,"context_line":"    # how to ensure br-int is configured?"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function quantum_plugin_configure_l3_agent() {"},{"line_number":60,"context_line":"   # Nicira plugin does not run L3 agent"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo7Y%3D","line":57,"in_reply_to":"AAAAM3%2F%2BpBs%3D","updated":"2013-02-23 18:26:48.000000000","message":"Done","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c202efaeb278117a3f6decc3cbc7b8486c82483","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function quantum_plugin_configure_l3_agent() {"},{"line_number":60,"context_line":"   # Nicira plugin does not run L3 agent"},{"line_number":61,"context_line":"   echo \"ERROR - q-l3 should must not be executed with Nicira plugin!\""},{"line_number":62,"context_line":"   exit 1"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo%2F0%3D","line":61,"updated":"2013-02-23 16:13:07.000000000","message":"Great, good to have an error here. \n\nWe might as well have this patch add L3 + metadata support as well, since they are pretty fundamental.  I\u0027ve made comments about metadata support above.  I\u0027ll send you a separate email with my thoughts on L3, as they require changes to additional files as well, since NVP doesn\u0027t use an agent for L3.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c1c6934feb1189f7a6d541ca94dbbc0b5e4c323","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if [[ \"$DEFAULT_L3_GW_SVC_UUID\" !\u003d \"\" ]]; then"},{"line_number":94,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" default_l3_gw_service_uuid $DEFAULT_L3_GW_SVC_UUID"},{"line_number":95,"context_line":"        else"},{"line_number":96,"context_line":"            echo \"ERROR - The nicira plugin won\u0027t work without default l3 gw service.\""},{"line_number":97,"context_line":"            exit 1"},{"line_number":98,"context_line":"        fi"},{"line_number":99,"context_line":"        # nvp_controllers must be a comma separated string"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo%2B0%3D","line":96,"updated":"2013-02-23 16:31:45.000000000","message":"That\u0027s not actually true, is it?  l3 connectivity won\u0027t work, and metadata would be broken for images that don\u0027t support receiving routes via static DHCP, but otherwise, things would work.  I\u0027m working on some additional patchset changes that improves the interaction with NVP L3.  Will post example diff soon.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if [[ \"$DEFAULT_L3_GW_SVC_UUID\" !\u003d \"\" ]]; then"},{"line_number":94,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" default_l3_gw_service_uuid $DEFAULT_L3_GW_SVC_UUID"},{"line_number":95,"context_line":"        else"},{"line_number":96,"context_line":"            echo \"ERROR - The nicira plugin won\u0027t work without default l3 gw service.\""},{"line_number":97,"context_line":"            exit 1"},{"line_number":98,"context_line":"        fi"},{"line_number":99,"context_line":"        # nvp_controllers must be a comma separated string"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo60%3D","line":96,"in_reply_to":"AAAAM3%2F%2Bo%2B0%3D","updated":"2013-02-23 18:26:48.000000000","message":"Yeah I added this message today because for some reason I thought l3 gateway was mandatory.\nBut it actually isn\u0027t.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c202efaeb278117a3f6decc3cbc7b8486c82483","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" nvp_controllers $NVP_CONTROLLERS"},{"line_number":102,"context_line":"\t\telif [[ \"$NVP_CONTROLLER_CONNECTION\" !\u003d \"\" ]]; then"},{"line_number":103,"context_line":"\t\t    # Only 1 controller can be specified in this case"},{"line_number":104,"context_line":"\t\t\tiniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" nvp_controller_connection $NVP_CONTROLLER_CONNECTION"},{"line_number":105,"context_line":"        else"},{"line_number":106,"context_line":"            echo \"ERROR - The nicira plugin needs at least an NVP controller.\""},{"line_number":107,"context_line":"            exit 1"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo%2Fw%3D","line":104,"updated":"2013-02-23 16:13:07.000000000","message":"tabs","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" nvp_controllers $NVP_CONTROLLERS"},{"line_number":102,"context_line":"\t\telif [[ \"$NVP_CONTROLLER_CONNECTION\" !\u003d \"\" ]]; then"},{"line_number":103,"context_line":"\t\t    # Only 1 controller can be specified in this case"},{"line_number":104,"context_line":"\t\t\tiniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" nvp_controller_connection $NVP_CONTROLLER_CONNECTION"},{"line_number":105,"context_line":"        else"},{"line_number":106,"context_line":"            echo \"ERROR - The nicira plugin needs at least an NVP controller.\""},{"line_number":107,"context_line":"            exit 1"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo7E%3D","line":104,"in_reply_to":"AAAAM3%2F%2Bo%2Fw%3D","updated":"2013-02-23 18:26:48.000000000","message":"Done","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"d06189ab4fa592db4eb2c017e73be2e2175518eb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if [[ \"$NVP_RETRIES\" !\u003d \"\" ]]; then"},{"line_number":118,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" retries $NVP_RETRIES"},{"line_number":119,"context_line":"        if [[ \"$NVP_REDIRECTS\" !\u003d \"\" ]]; then"},{"line_number":120,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" redirects $NVP_REDIRECTS"},{"line_number":121,"context_line":"    else"},{"line_number":122,"context_line":"        echo \"ERROR - Default cluster not configured. Quantum will not start\""},{"line_number":123,"context_line":"        exit 1"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo%2BY%3D","line":120,"updated":"2013-02-23 16:51:15.000000000","message":"these need \"fi\", no?  At least my bash seems to complain if they aren\u0027t there.","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if [[ \"$NVP_RETRIES\" !\u003d \"\" ]]; then"},{"line_number":118,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" retries $NVP_RETRIES"},{"line_number":119,"context_line":"        if [[ \"$NVP_REDIRECTS\" !\u003d \"\" ]]; then"},{"line_number":120,"context_line":"            iniset /$Q_PLUGIN_CONF_FILE \"CLUSTER:$DC\" redirects $NVP_REDIRECTS"},{"line_number":121,"context_line":"    else"},{"line_number":122,"context_line":"        echo \"ERROR - Default cluster not configured. Quantum will not start\""},{"line_number":123,"context_line":"        exit 1"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo6w%3D","line":120,"in_reply_to":"AAAAM3%2F%2Bo%2BY%3D","updated":"2013-02-23 18:26:48.000000000","message":"No they need it (as I told you I did not mean to push this patch:) )","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3c202efaeb278117a3f6decc3cbc7b8486c82483","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    else"},{"line_number":122,"context_line":"        echo \"ERROR - Default cluster not configured. Quantum will not start\""},{"line_number":123,"context_line":"        exit 1"},{"line_number":124,"context_line":"    fi"},{"line_number":125,"context_line":"}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"function quantum_plugin_setup_interface_driver() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2BpBk%3D","line":124,"updated":"2013-02-23 16:13:07.000000000","message":"+    iniset /$Q_PLUGIN_CONF_FILE NVP enable_metadata_access_network True\n\nfor metadata","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1428bd55cfa73eb9362cb11f4f62d5e10d32ff08","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    else"},{"line_number":122,"context_line":"        echo \"ERROR - Default cluster not configured. Quantum will not start\""},{"line_number":123,"context_line":"        exit 1"},{"line_number":124,"context_line":"    fi"},{"line_number":125,"context_line":"}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"function quantum_plugin_setup_interface_driver() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAM3%2F%2Bo6s%3D","line":124,"in_reply_to":"AAAAM3%2F%2BpBk%3D","updated":"2013-02-23 18:26:48.000000000","message":"Done","commit_id":"b20b0f4dbc61c43a39da277e8b9150acd2821b53"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"707d259004ec2ffb176ddcf100745e24a7897f09","unresolved":false,"context_lines":[{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":55,"context_line":"    # how to ensure br-int is configured?"},{"line_number":56,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT enable_isolated_metadata True"},{"line_number":57,"context_line":"    iniset $Q_DHCP_CONF_FILE DEFAULT enable_metadata_network True"},{"line_number":58,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAM3%2F%2Bo54%3D","line":55,"updated":"2013-02-23 18:38:18.000000000","message":"I think factoring out lines 19-34 in a common routine and calling it here if is_service_enabled q-dhcp should work","commit_id":"028d09c2f06f851cbc6fc69ef4b2487f4aaa5178"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"e7648720e57673c5e16d27f3f2c4e6d0efbb8f49","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function is_quantum_ovs_base_plugin() {"},{"line_number":30,"context_line":"    # NVP does not make part of the OVS family"},{"line_number":31,"context_line":"    return 1"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"function quantum_plugin_create_nova_conf() {"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAM3%2F%2Bo3M%3D","line":31,"updated":"2013-02-23 21:26:12.000000000","message":"this is tricky, as this actually is what lib/nova uses to update the cgroup acl to allow /dev/net/tun.   \n\nif is_service_enabled quantum \u0026\u0026 is_quantum_ovs_base_plugin","commit_id":"3453fb28a0e25ac974cc801cdb0656bd54909acf"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7d9ac37799f07dd756a753dc3bb81c8221fc928d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        echo \"Error - No controller specified. Unable to set a manager for OVS\""},{"line_number":24,"context_line":"        exit 1"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"    sudo ovs-vsctl set-manager $OVS_MANAGER"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function is_quantum_ovs_base_plugin() {"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAAM3%2F%2Bowk%3D","line":26,"updated":"2013-02-24 07:01:32.000000000","message":"Should this be $OVS_MGR","commit_id":"74b9d8f25e38e345956f9b9e2b04d7e5493a4473"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"20c2550aacdc4f442899e00d90a39ce322194280","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        echo \"Error - No controller specified. Unable to set a manager for OVS\""},{"line_number":24,"context_line":"        exit 1"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"    sudo ovs-vsctl set-manager $OVS_MANAGER"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function is_quantum_ovs_base_plugin() {"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAAM3%2F%2BowQ%3D","line":26,"in_reply_to":"AAAAM3%2F%2Bowk%3D","updated":"2013-02-24 07:05:13.000000000","message":"Done","commit_id":"74b9d8f25e38e345956f9b9e2b04d7e5493a4473"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7d9ac37799f07dd756a753dc3bb81c8221fc928d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":59,"context_line":"    # The if below if probably unnecessary"},{"line_number":60,"context_line":"    if is_service_enabled q-dhcp; then"},{"line_number":61,"context_line":"        setup_integration_bridge"},{"line_number":62,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAAM3%2F%2Bowg%3D","line":59,"updated":"2013-02-24 07:01:32.000000000","message":"Not sure that I understand the comment. I think that the code ensures that the correct driver is configured for the agent","commit_id":"74b9d8f25e38e345956f9b9e2b04d7e5493a4473"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"20c2550aacdc4f442899e00d90a39ce322194280","unresolved":false,"context_lines":[{"line_number":56,"context_line":"}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"function quantum_plugin_configure_dhcp_agent() {"},{"line_number":59,"context_line":"    # The if below if probably unnecessary"},{"line_number":60,"context_line":"    if is_service_enabled q-dhcp; then"},{"line_number":61,"context_line":"        setup_integration_bridge"},{"line_number":62,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAAM3%2F%2BowE%3D","line":59,"in_reply_to":"AAAAM3%2F%2Bowg%3D","updated":"2013-02-24 07:05:13.000000000","message":"I think salvatore is specifically referring to guarding the call to setup_integration_bridge with an if-block.  Presumably this function is only called if q-dhcp is enabled.  I will confirm that and remove the if.","commit_id":"74b9d8f25e38e345956f9b9e2b04d7e5493a4473"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"72f9fc20b02e0203c2f46fd1ee87dcb87b333bff","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    # Set manager to NVP controller (1st of list)"},{"line_number":14,"context_line":"    if [[ \"$NVP_CONTROLLERS\" !\u003d \"\" ]]; then"},{"line_number":15,"context_line":"        # Get the first controller"},{"line_number":16,"context_line":"        controllers\u003d(${$NVP__CONTROLLERS//,/ })"},{"line_number":17,"context_line":"        mgr_port\u003d${NVP_CONTROLLER_PORT:-\"443\"}"},{"line_number":18,"context_line":"        OVS_MGR\u003d${controllers[0]}:$mgr_port"},{"line_number":19,"context_line":"    elif [[ \"$NVP_CONTROLLER_CONNECTION\" !\u003d \"\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"AAAAM3%2F%2BndI%3D","line":16,"updated":"2013-02-25 18:22:15.000000000","message":"typo, there are two underscores here.  this prevents the manager from being set correct (though its easy to miss, if the manager was previous set correctly)","commit_id":"8edac6d9bbf334b29445f878339b0d328ba7efb5"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"af63a49f8f956fbb4c0a1df6ffdb93f706d5672b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mgr_port\u003d${NVP_CONTROLLER_PORT:-\"443\"}"},{"line_number":18,"context_line":"        OVS_MGR\u003d${controllers[0]}:$mgr_port"},{"line_number":19,"context_line":"    elif [[ \"$NVP_CONTROLLER_CONNECTION\" !\u003d \"\" ]]; then"},{"line_number":20,"context_line":"        conn\u003d(${$NVP_CONTROLLER_CONNECTION//\\:/ })"},{"line_number":21,"context_line":"        OVS_MGR\u003d${conn[0]}:${conn[1]}"},{"line_number":22,"context_line":"    else"},{"line_number":23,"context_line":"        echo \"Error - No controller specified. Unable to set a manager for OVS\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"AAAAM3%2F%2BnZg%3D","line":20,"updated":"2013-02-25 18:54:34.000000000","message":"I think this syntax for converting from a comma-delimited list to a n array is wrong.  We need to get rid of the second $, both here, and a few lines above.  Is there anywhere else in the patch that may use the same syntax?","commit_id":"8edac6d9bbf334b29445f878339b0d328ba7efb5"}]}