)]}'
{"lib/lvm":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b3e94e6cddf40b42f06e4166dac46a0394e63de5","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Method used to wipe old lvm volumes in Nova\u0027s libvirt image backend."},{"line_number":34,"context_line":"# Choices are \u0027none\u0027, \u0027zero\u0027, or \u0027shred\u0027."},{"line_number":35,"context_line":"LVM_VOLUME_CLEAR\u003d${LVM_VOLUME_CLEAR:-zero}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Backing file name is of the form $VOLUME_GROUP$BACKING_FILE_SUFFIX"},{"line_number":38,"context_line":"BACKING_FILE_SUFFIX\u003d-backing-file"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dab17558_edcd0e32","line":35,"updated":"2016-05-11 00:53:39.000000000","message":"What I don\u0027t like is devstack overriding project defaults.\nTwo years from now when we add \"shredv2\" nobody comes back to think that devstack is actually setting this to zero and you end up not testing what you think you\u0027re testing.\n\nI\u0027m still not sure why this can\u0027t be just set in local.conf just as any other variable for jobs who want to override the default.","commit_id":"89328a086f6b81c27354e27f775e7692f41debca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35ddebcf9b89f1f786a366267727307758208fcc","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Method used to wipe old lvm volumes in Nova\u0027s libvirt image backend."},{"line_number":34,"context_line":"# Choices are \u0027none\u0027, \u0027zero\u0027, or \u0027shred\u0027."},{"line_number":35,"context_line":"LVM_VOLUME_CLEAR\u003d${LVM_VOLUME_CLEAR:-zero}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Backing file name is of the form $VOLUME_GROUP$BACKING_FILE_SUFFIX"},{"line_number":38,"context_line":"BACKING_FILE_SUFFIX\u003d-backing-file"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dab17558_83dd33e2","line":35,"in_reply_to":"dab17558_edcd0e32","updated":"2016-05-11 01:44:47.000000000","message":"Ian, can you provide an example of how to set this in local.conf without using a variable in devstack? Are you talking about putting straight bash into local.conf or something else?","commit_id":"89328a086f6b81c27354e27f775e7692f41debca"}],"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7d86428ab735e28ee3f10d0b408862c06133be4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"NOVA_SERVICE_LISTEN_ADDRESS\u003d${NOVA_SERVICE_LISTEN_ADDRESS:-$SERVICE_LISTEN_ADDRESS}"},{"line_number":90,"context_line":"EC2_SERVICE_PORT\u003d${EC2_SERVICE_PORT:-8773}"},{"line_number":91,"context_line":"EC2_SERVICE_PORT_INT\u003d${EC2_SERVICE_PORT_INT:-18773}"},{"line_number":92,"context_line":"NOVA_VOLUME_CLEAR\u003d${NOVA_VOLUME_CLEAR:-none}"},{"line_number":93,"context_line":"NOVA_VOLUME_CLEAR\u003d$(echo ${NOVA_VOLUME_CLEAR} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# Option to enable/disable config drive"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_5a771c02","line":92,"updated":"2015-08-24 20:13:44.000000000","message":"This should default to zero rather than none since it defaults to zero in the code:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/storage/lvm.py#L35","commit_id":"fca4fac39fb513b1b6e47016b9958be23d2b0545"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7d86428ab735e28ee3f10d0b408862c06133be4","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    if [[ \"$NOVA_BACKEND\" \u003d\u003d \"LVM\" ]]; then"},{"line_number":614,"context_line":"        iniset $NOVA_CONF libvirt images_type \"lvm\""},{"line_number":615,"context_line":"        iniset $NOVA_CONF libvirt images_volume_group $DEFAULT_VOLUME_GROUP_NAME"},{"line_number":616,"context_line":"        iniset $NOVA_CONF libvirt volume_clear $NOVA_VOLUME_CLEAR"},{"line_number":617,"context_line":"    fi"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    if is_ssl_enabled_service glance || is_service_enabled tls-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa1b9901_faeab073","line":616,"updated":"2015-08-24 20:13:44.000000000","message":"It may not be a bad idea to whitelist the possible values like cinder does:\n\nhttps://github.com/openstack-dev/devstack/blob/master/lib/cinder#L277","commit_id":"fca4fac39fb513b1b6e47016b9958be23d2b0545"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b3e94e6cddf40b42f06e4166dac46a0394e63de5","unresolved":false,"context_lines":[{"line_number":606,"context_line":"        iniset $NOVA_CONF libvirt images_volume_group $DEFAULT_VOLUME_GROUP_NAME"},{"line_number":607,"context_line":"        # Assuming devstack isn\u0027t used for production deployments, don\u0027t waste"},{"line_number":608,"context_line":"        # time zero\u0027ing out volumes."},{"line_number":609,"context_line":"        iniset $NOVA_CONF libvirt volume_clear \"$LVM_VOLUME_CLEAR\""},{"line_number":610,"context_line":"    fi"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    if is_ssl_enabled_service glance || is_service_enabled tls-proxy; then"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dab17558_e864dcb9","line":609,"updated":"2016-05-11 00:53:39.000000000","message":"i understand there\u0027s some precedent with cinder here.  but if we have to have this, i\u0027d rather see\n\n if isset LVM_VOLUME_CLEAR; then\n   iniset ...\n fi\n\nand have no default for LVM_VOLUME_CLEAR (i.e., pick it up from nova defaults)\n\nbut, as mentioned, it seems like can be done with no modifications via existing local config options\n\n(and add something in docs/ while we\u0027re at it)","commit_id":"89328a086f6b81c27354e27f775e7692f41debca"}]}