)]}'
{"id":"openstack%2Fdevstack~21721","triplet_id":"openstack%2Fdevstack~master~I7f1b5dbf5329b23507cb767d54a2795be0d73e01","project":"openstack/devstack","branch":"master","topic":"screen-dev","hashtags":[],"change_id":"I7f1b5dbf5329b23507cb767d54a2795be0d73e01","subject":"Add option to make screen starting more robust.","status":"MERGED","created":"2013-02-12 00:53:13.000000000","updated":"2013-02-13 02:03:58.000000000","submitted":"2013-02-13 02:03:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"01c0976c8f1701ad501511f9be7669a5ba9a758e","_number":21721,"virtual_id_number":21721,"owner":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2013-02-13 02:03:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2013-02-12 19:44:52.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"date":"2013-02-12 17:13:26.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":1,"date":"2013-02-12 19:44:52.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-12 01:09:16.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2013-02-12 01:51:20.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2013-02-12 01:52:13.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-02-12 01:55:20.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2013-02-12 07:26:28.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2013-02-12 19:44:52.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-02-13 02:03:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5d90a89fb30a9f852bb4fc803a91e34d007a6797","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-02-12 01:09:16.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nSeems like the simpler approach should work for normal devs too - just change the command we tell screen to spawn to do its own stuffing.","accounts_in_message":[],"_revision_number":1},{"id":"aa606b242a0f3f8c7243b2a498ddf1172cd423be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 01:35:26.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-full/2141 : SUCCESS\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-postgres-full/1867 : SUCCESS\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-quantum/6288 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"0d553354e0ded296f2c5cd0c718d70335936cb8e","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2013-02-12 01:51:20.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"9d162397cceab4fdede002b09082fcd497b453b1","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-12 01:52:13.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nso this seems like a bandaid, but with the CI queue size, so be it. It really feels like we should be building custom screenrc files with the exec and be done with it.","accounts_in_message":[],"_revision_number":1},{"id":"9fe1e566dc86dd327047bcc1b177b127e47b33c2","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-02-12 01:55:20.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"da66b314dfaa1da0f2f6c6dd48da1a04207c5c9d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-12 02:03:03.000000000","message":"Patch Set 1: Do not merge\n\nGoing to put a hold on this until the devstack gate makes it through, to make sure the output looks fine and we merge it (as devstack changes impact far too many other parts of the system).","accounts_in_message":[],"_revision_number":1},{"id":"8b37ba8430fbc1642c3a563e7d24ada1e61d4592","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2013-02-12 07:26:28.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9954bdad3e3589099ad81effd2d96a52acfc69da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 08:52:31.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-full/2200 : ABORTED\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-postgres-full/1926 : ABORTED\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-quantum/6352 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"eb7aba4b1531b49b2e30270f418bcea25c85382d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-12 11:03:24.000000000","message":"Patch Set 1: No score\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0b47d33e3c6b895f83783921f76d9f42f29528ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 11:47:13.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-full/2216 : SUCCESS\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-postgres-full/1942 : SUCCESS\n- http://logs.openstack.org/21721/1/check/gate-tempest-devstack-vm-quantum/6375 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"94e4b8786e17754708e762a29bfec593390247ef","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-12 12:13:50.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"2dba53ccbbf175a7763b90fd1e79d6083bd98008","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-02-12 16:43:58.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"456ff2ef5ccff64494ac3e974faa973cb7fe1cb0","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-12 17:13:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4984773ed754aceebf80889202f2be59ad3ed350","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 18:16:44.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21721/2/check/gate-tempest-devstack-vm-full/2276 : SUCCESS\n- http://logs.openstack.org/21721/2/check/gate-tempest-devstack-vm-postgres-full/2002 : SUCCESS\n- http://logs.openstack.org/21721/2/check/gate-tempest-devstack-vm-quantum/6446 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"8f22b166f7bdf520505873128ddbe0e5eac3d12c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-12 19:44:52.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c9fca1dd08b4f267027cdc927f6614d99e99c734","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-02-12 19:44:52.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d754ec5e926dbd8acc30b203a3a5216e95a2ff08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-13 02:03:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"bdba2c957ccf8ae930fe1923d079e32a6d57289b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-13 02:03:58.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21721/2/gate/gate-tempest-devstack-vm-full/2403 : SUCCESS\n- http://logs.openstack.org/21721/2/gate/gate-tempest-devstack-vm-postgres-full/2129 : SUCCESS\n- http://logs.openstack.org/21721/2/gate/gate-tempest-devstack-vm-quantum/6588 : SUCCESS\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"58e21349644f42d4aff078e4da26ecd98d76ba19","revisions":{"ac8f49631198a17288fc31ce0fee89239fa95744":{"kind":"REWORK","_number":1,"created":"2013-02-12 00:53:13.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/21/21721/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/21721/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/21721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/21721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/21721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/21721/1"}}},"commit":{"parents":[{"commit":"098b272cf76ce7150852daba79b714f9746a204f","subject":"Merge \"Disable non-dhcp resolv.conf\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/098b272cf76ce7150852daba79b714f9746a204f"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2013-02-12 00:48:12.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2013-02-12 00:53:11.000000000","tz":-480},"subject":"Add option to make screen starting more robust.","message":"Add option to make screen starting more robust.\n\nWe have seen a number of failures in ci where a host is overloaded\nand the 1.5 second sleep before stuffing data into screen is not\nlong enough. This means the service doesn\u0027t start and tests fail.\n\nThis change adds a config option to allow us to turn off the developer\nfriendly option to stuff text into the screen. When SCREEN_DEV is\nset to False it will use a simple exec in screen instead of stuff.\nThis should be far more reliable because we don\u0027t have to wait\nfor bash to start.\n\nChange-Id: I7f1b5dbf5329b23507cb767d54a2795be0d73e01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ac8f49631198a17288fc31ce0fee89239fa95744"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ac8f49631198a17288fc31ce0fee89239fa95744"}]},"branch":"refs/heads/master"},"58e21349644f42d4aff078e4da26ecd98d76ba19":{"kind":"REWORK","_number":2,"created":"2013-02-12 17:13:26.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/21/21721/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/21721/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/21721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/21721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/21721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/21721/2"}}},"commit":{"parents":[{"commit":"098b272cf76ce7150852daba79b714f9746a204f","subject":"Merge \"Disable non-dhcp resolv.conf\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/098b272cf76ce7150852daba79b714f9746a204f"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2013-02-12 00:48:12.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2013-02-12 17:12:45.000000000","tz":-480},"subject":"Add option to make screen starting more robust.","message":"Add option to make screen starting more robust.\n\nWe have seen a number of failures in ci where a host is overloaded\nand the 1.5 second sleep before stuffing data into screen is not\nlong enough. This means the service doesn\u0027t start and tests fail.\n\nThis change adds a config option to allow us to turn off the developer\nfriendly option to stuff text into the screen. When SCREEN_DEV is\nset to False it will use a simple exec in screen instead of stuff.\nThis should be far more reliable because we don\u0027t have to wait\nfor bash to start.\n\nChange-Id: I7f1b5dbf5329b23507cb767d54a2795be0d73e01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/58e21349644f42d4aff078e4da26ecd98d76ba19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/58e21349644f42d4aff078e4da26ecd98d76ba19"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}