)]}'
{"id":"openstack%2Fdevstack~21932","triplet_id":"openstack%2Fdevstack~master~I489bfd4cc12cc6b0b8201837f2bfb78c6881c82c","project":"openstack/devstack","branch":"master","topic":"refactor-get-pacage","hashtags":[],"change_id":"I489bfd4cc12cc6b0b8201837f2bfb78c6881c82c","subject":"package: consolidate get_packages logic","status":"MERGED","created":"2013-02-14 01:38:05.000000000","updated":"2013-02-28 05:43:35.000000000","submitted":"2013-02-28 05:43:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c27dd14c5edd77b3e25db327cac04e4aa787650f","_number":21932,"virtual_id_number":21932,"owner":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-02-28 05:43:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-02-26 10:45:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},{"value":1,"date":"2013-02-26 17:21:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":2,"date":"2013-02-27 16:23:02.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":1,"date":"2013-02-28 05:07:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-22 11:58:26.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-02-25 11:31:41.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-02-26 10:45:23.000000000","updated_by":{"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},"reviewer":{"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},"state":"REVIEWER"},{"updated":"2013-02-26 17:21:45.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2013-02-28 05:07:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-02-28 05:43:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"eb304359385920901d02dac6ec696e7af70cf080","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-14 03:18:34.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21932/1/check/gate-tempest-devstack-vm-full/2701 : SUCCESS\n- http://logs.openstack.org/21932/1/check/gate-tempest-devstack-vm-postgres-full/2427 : SUCCESS\n- http://logs.openstack.org/21932/1/check/gate-tempest-devstack-vm-quantum/6928 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"1cc0fd4301b7de8b9fbf5bcec98c4b7a58fbd825","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-22 11:58:26.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\none minor nit on variable naming, then I\u0027m +2. It\u0027s a nice cleanup.","accounts_in_message":[],"_revision_number":1},{"id":"00f933155b3c8136a148b96c20bbe3d2b4e60412","author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"date":"2013-02-25 07:27:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"79bf679b5844d10016d27b4a50ea5a6af860329b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-25 08:02:54.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21932/2/check/gate-tempest-devstack-vm-full/5271 : SUCCESS\n- http://logs.openstack.org/21932/2/check/gate-tempest-devstack-vm-postgres-full/4990 : SUCCESS\n- http://logs.openstack.org/21932/2/check/gate-tempest-devstack-vm-quantum/9902 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"445b0a4ae87130a6d7218b600baa4b3c2f2012af","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-02-25 11:31:41.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b5262b0a053071b2275d2e3ab35496abdd7d7a13","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-02-26 00:00:35.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"5171af63130da4743fb2fbf5199554b56819d6f8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-02-26 02:11:22.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI\u0027m not sure I understand the rationale for making get_packages() a one line wrapper around get_packages_for().  You are already changing signature of get_packages() to remove the selected distro path, adding the service list in its place should be fine.  It gets rid of the ENABLED_SERVICES dependency.","accounts_in_message":[],"_revision_number":2},{"id":"a4b32a5010280f02b9c245b1aec627c928cbb517","author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"date":"2013-02-26 08:18:13.000000000","message":"Patch Set 2: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"146006cd2f790b603c7d48938bf45d1026a04445","author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"date":"2013-02-26 08:39:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d367f05ed195d5ea09a685a0661421addd021db1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-26 09:14:46.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/21932/3/check/gate-tempest-devstack-vm-full/5470 : SUCCESS\n- http://logs.openstack.org/21932/3/check/gate-tempest-devstack-vm-postgres-full/5189 : SUCCESS\n- http://logs.openstack.org/21932/3/check/gate-tempest-devstack-vm-quantum/10153 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"d73f8a5b67010087563416a231e32351277996ce","author":{"_account_id":4726,"name":"Yoshihiro Kaneko","email":"ykaneko0929@gmail.com","username":"ykaneko0929"},"date":"2013-02-26 10:45:23.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"4cba83ab697a146319f1e3f812cd3eb4a2daaa45","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-02-26 17:21:45.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d08ea667ba06d70277fd4f991813356f12ab2100","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-02-27 16:23:02.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"811b36fa2d0295ed436c4503fe351ce01dffdaae","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-02-28 05:07:41.000000000","message":"Patch Set 3: Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"1a592b24bc88177f570156d2df9ac9c280462132","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 05:07:51.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"0159593adaa5abf3d2d66049a6045e079a49be34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 05:43:35.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"00be8ea8f0a393662c29e3d226794b946ed26b59","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 05:43:35.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/21932/3/gate/gate-tempest-devstack-vm-full/6026 : SUCCESS\n- http://logs.openstack.org/21932/3/gate/gate-tempest-devstack-vm-postgres-full/5745 : SUCCESS\n- http://logs.openstack.org/21932/3/gate/gate-tempest-devstack-vm-quantum/10807 : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8c43809ef6664521b2c906665609757ce7f0b55e","revisions":{"007f4d7f733a70b1184f7ccd9268444aafe86760":{"kind":"REWORK","_number":1,"created":"2013-02-14 01:38:05.000000000","uploader":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"ref":"refs/changes/32/21932/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/21932/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/21932/1"}}},"commit":{"parents":[{"commit":"77ee2faa3dbe9d89176df75dd7df028447567ddc","subject":"Merge \"allow resize tests to run\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/77ee2faa3dbe9d89176df75dd7df028447567ddc"}]}],"author":{"name":"Isaku Yamahata","email":"yamahata@valinux.co.jp","date":"2013-02-12 13:30:56.000000000","tz":540},"committer":{"name":"Isaku Yamahata","email":"yamahata@valinux.co.jp","date":"2013-02-14 01:37:46.000000000","tz":540},"subject":"pakcage: consolidate get_packages logic","message":"pakcage: consolidate get_packages logic\n\nRefactor get_package logic.\nWith this refactoring, code like\n\"if is_ubuntum; then install_package xxx elif is_fendor...\"\ncan be simplified later.\n\nChange-Id: I489bfd4cc12cc6b0b8201837f2bfb78c6881c82c\nSigned-off-by: Isaku Yamahata \u003cyamahata@valinux.co.jp\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/007f4d7f733a70b1184f7ccd9268444aafe86760"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/007f4d7f733a70b1184f7ccd9268444aafe86760"}]},"branch":"refs/heads/master"},"3fdad65a32719c884a22950f81592960a1c48e18":{"kind":"REWORK","_number":2,"created":"2013-02-25 07:27:43.000000000","uploader":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"ref":"refs/changes/32/21932/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/21932/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/21932/2"}}},"commit":{"parents":[{"commit":"3bd75a8d019290c602daf5f4c313513b3791657d","subject":"Merge \"Fix hard coded quantum url and port\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3bd75a8d019290c602daf5f4c313513b3791657d"}]}],"author":{"name":"Isaku Yamahata","email":"yamahata@valinux.co.jp","date":"2013-02-12 13:30:56.000000000","tz":540},"committer":{"name":"Isaku Yamahata","email":"yamahata@valinux.co.jp","date":"2013-02-25 07:04:44.000000000","tz":540},"subject":"pakcage: consolidate get_packages logic","message":"pakcage: consolidate get_packages logic\n\nRefactor get_package logic.\nWith this refactoring, code like\n\"if is_ubuntum; then install_package xxx elif is_fendor...\"\ncan be simplified later.\n\nChange-Id: I489bfd4cc12cc6b0b8201837f2bfb78c6881c82c\nSigned-off-by: Isaku Yamahata \u003cyamahata@valinux.co.jp\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3fdad65a32719c884a22950f81592960a1c48e18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3fdad65a32719c884a22950f81592960a1c48e18"}]},"branch":"refs/heads/master"},"8c43809ef6664521b2c906665609757ce7f0b55e":{"kind":"REWORK","_number":3,"created":"2013-02-26 08:39:10.000000000","uploader":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"ref":"refs/changes/32/21932/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/32/21932/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/32/21932/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/32/21932/3"}}},"commit":{"parents":[{"commit":"555ecd07b084e7f5149a36b97508408a74490eaa","subject":"Devstack support for nicira plugin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/555ecd07b084e7f5149a36b97508408a74490eaa"}]}],"author":{"name":"Isaku Yamahata","email":"yamahata@valinux.co.jp","date":"2013-02-12 13:30:56.000000000","tz":540},"committer":{"name":"Isaku Yamahata","email":"yamahata@valinux.co.jp","date":"2013-02-26 08:39:05.000000000","tz":540},"subject":"package: consolidate get_packages logic","message":"package: consolidate get_packages logic\n\nRefactor get_package logic.\nWith this refactoring, code like\n\"if is_ubuntu; then install_package xxx elif is_fedora...\"\ncan be simplified later.\n\nChange-Id: I489bfd4cc12cc6b0b8201837f2bfb78c6881c82c\nSigned-off-by: Isaku Yamahata \u003cyamahata@valinux.co.jp\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8c43809ef6664521b2c906665609757ce7f0b55e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8c43809ef6664521b2c906665609757ce7f0b55e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}