)]}'
{"id":"openstack%2Fdevstack~227620","triplet_id":"openstack%2Fdevstack~master~If7b8f6fa674773ce131abb9b78fd392688c23254","project":"openstack/devstack","branch":"master","topic":"move-use-secgroup","hashtags":[],"change_id":"If7b8f6fa674773ce131abb9b78fd392688c23254","subject":"Move Q_USE_SECGROUP for complete support of external plugin","status":"ABANDONED","created":"2015-09-25 00:58:20.000000000","updated":"2016-01-13 13:44:50.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fd1757fbcd2a273eb728fa48e6ea694342dee20d","_number":227620,"virtual_id_number":227620,"owner":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-09-25 01:58:52.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2015-10-02 15:51:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-09-28 22:50:19.000000000","_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"date":"2015-09-28 14:01:28.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":-1,"date":"2015-09-28 04:32:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"date":"2015-09-25 00:59:12.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"date":"2015-09-25 00:59:03.000000000","_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":-1,"date":"2015-09-28 14:03:40.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-25 00:59:03.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-09-25 00:59:12.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2015-09-25 01:58:52.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-09-28 22:50:19.000000000","updated_by":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"reviewer":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"state":"REVIEWER"},{"updated":"2015-10-02 15:51:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"efca41cf1d45ca9e21b4779ee55c987716520f72","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2015-09-25 00:58:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7affc8cf181bf4d0bb5d37551e6a7c97fd15d865","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-09-25 01:58:52.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/20/227620/1/12230/index.html : FAILURE in 55 m 42 s","accounts_in_message":[],"_revision_number":1},{"id":"8036f7ff14527a983a8c68386795a7cbe7ebced5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-25 02:04:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-full/3371b20/ : SUCCESS in 40m 12s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-postgres-full/66482f4/ : SUCCESS in 50m 42s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-neutron-full/22e4f65/ : SUCCESS in 50m 41s\n- gate-grenade-dsvm http://logs.openstack.org/20/227620/1/check/gate-grenade-dsvm/63abf64/ : SUCCESS in 42m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-large-ops/d23d2af/ : SUCCESS in 32m 26s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-neutron-large-ops/81e0d46/ : SUCCESS in 29m 51s\n- gate-devstack-bashate http://logs.openstack.org/20/227620/1/check/gate-devstack-bashate/250839e/ : SUCCESS in 28s\n- gate-devstack-unit-tests http://logs.openstack.org/20/227620/1/check/gate-devstack-unit-tests/c2de81c/ : SUCCESS in 24s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/20/227620/1/check/gate-grenade-dsvm-partial-ncpu/052835c/ : SUCCESS in 40m 56s\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-ironic-agent_ssh/f84f9fd/ : SUCCESS in 43m 08s\n- gate-devstack-dsvm-updown http://logs.openstack.org/20/227620/1/check/gate-devstack-dsvm-updown/bf1f3bb/ : SUCCESS in 21m 29s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-f21/d656f7c/ : SUCCESS in 47m 49s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-centos7/5f1134f/ : SUCCESS in 33m 21s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/20/227620/1/check/gate-devstack-publish-docs/67ec28b//doc/build/html/ : SUCCESS in 1m 44s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/20/227620/1/check/gate-swift-dsvm-functional-nv/3ca3d63/ : SUCCESS in 25m 53s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/20/227620/1/check/gate-grenade-dsvm-neutron/4582c21/ : SUCCESS in 43m 37s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-multinode-full/544d1d2/ : SUCCESS in 47m 50s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/20/227620/1/check/gate-tempest-dsvm-neutron-multinode-full/083fb4c/ : SUCCESS in 1h 01m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f28348085552952f1d3e86ac3545420086d766f7","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-09-28 04:32:26.000000000","message":"Patch Set 1: Code-Review-1\n\ni personally like this approach.\nhowever, there seems to be favor to use override-defaults for this purpose.\nhttps://review.openstack.org/#/c/204951","accounts_in_message":[],"_revision_number":1},{"id":"2e8f59834bc5e7765e5031b2a15820dc138a8211","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2015-09-28 14:01:28.000000000","message":"Patch Set 1:\n\nThanks. I wasn\u0027t aware of Hirofumi\u0027s patch when I looks through devstack patches :-(\nI should to chime in that patch.\n\nIs \"override-default\" way you mentioned an approach with a variable? correct?","accounts_in_message":[],"_revision_number":1},{"id":"f25e73abba55fe0c3be5b848592bafc56e41487b","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2015-09-28 14:03:40.000000000","message":"Patch Set 1: Workflow-1\n\nI would like to use this patch to drop related vendor specific files, so I will keep it open with WIP. Once the other patch from Hirofumi lands, I will resume the patch.","accounts_in_message":[],"_revision_number":1},{"id":"3c51bc33a56c9711e61b80f22d9e4a5278800e81","author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"date":"2015-09-28 22:50:19.000000000","message":"Patch Set 1:\n\nIn this cycle, I removed some restraints for vendor plugin from devstack. I tried to do this as well but it was concluded that we should use override-default[1] not change devstack.\n\n[1]: https://review.openstack.org/#/c/221137/3/devstack/override-defaults\n\nHowever, I prefer this patch. I think we should remove the restraint and some plugins depending on it. If you want to restore my patch, you can do.","accounts_in_message":[],"_revision_number":1},{"id":"b51df44a8e0c8e347bd71ebf891cc77e3d2adf33","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-02 15:51:33.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"b21ecfecbfcb19d73f881e73120a42170a7f7ecc","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-01-13 13:44:50.000000000","message":"Abandoned\n\nAbandon this in favor of override_defaults mechanism. I will post follow-up patches.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a031c964ebb5c108b041bd4b289aae401d9f1cde","revisions":{"a031c964ebb5c108b041bd4b289aae401d9f1cde":{"kind":"REWORK","_number":1,"created":"2015-09-25 00:58:20.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/20/227620/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/20/227620/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/227620/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/227620/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/227620/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/20/227620/1"}}},"commit":{"parents":[{"commit":"9f6b7eb3e5faeed3bb54f8ba919bd9412fa8f7c7","subject":"Merge \"attempt to cut api workers in half\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9f6b7eb3e5faeed3bb54f8ba919bd9412fa8f7c7"}]}],"author":{"name":"Akihiro Motoki","email":"motoki@da.jp.nec.com","date":"2015-09-25 00:46:44.000000000","tz":540},"committer":{"name":"Akihiro Motoki","email":"motoki@da.jp.nec.com","date":"2015-09-25 00:58:18.000000000","tz":540},"subject":"Move Q_USE_SECGROUP for complete support of external plugin","message":"Move Q_USE_SECGROUP for complete support of external plugin\n\nEven after devstack external plugin mechanism was introduced,\nNeutron plugin maintainers still need to have small code\nin the main devstack repo.\nIt is because has_neutron_plugin_security_group is called too\nearly, i.e. before loading external plugin.\n\nThis commit defers the call of has_neutron_plugin_security_group\nuntil configure_neutron. After that, devstack external plugin\nsuport for Neutorn is completely achieved.\n\nThis patch also deletes vendor specific files which already use\nexternal plugin (midonet, nec, vmware_*).\nI checked all these repositories and confirmed they have\nhas_neutron_plugin_security_group function in their repo too.\nWe can safely delete these files.\n\nChange-Id: If7b8f6fa674773ce131abb9b78fd392688c23254\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a031c964ebb5c108b041bd4b289aae401d9f1cde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a031c964ebb5c108b041bd4b289aae401d9f1cde"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}