)]}'
{"lib/quantum_plugins/ovs_base":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"591609869286005a3c43a93202748e3753f7e9cb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        install_package make fakeroot dkms openvswitch-switch openvswitch-datapath-dkms linux-headers-$kernel_version"},{"line_number":27,"context_line":"    else"},{"line_number":28,"context_line":"        install_package openvswitch"},{"line_number":29,"context_line":"        # Fedora does not started OVS by default"},{"line_number":30,"context_line":"        restart_service openvswitch"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Bnm8%3D","line":29,"updated":"2013-02-25 17:21:06.000000000","message":"is this comment meant from the line above?  if so, i\u0027d move it above the install_package line.  Otherwise, i\u0027m not clear on why it is relevant for the restart_service command, so perhaps more detail is needed.","commit_id":"814f21b85da3e0cc2ee13cf9948d5588e97c1aaa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2674da56cd01866f01219030872b239c53da2599","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        install_package make fakeroot dkms openvswitch-switch openvswitch-datapath-dkms linux-headers-$kernel_version"},{"line_number":27,"context_line":"    else"},{"line_number":28,"context_line":"        install_package openvswitch"},{"line_number":29,"context_line":"        # Fedora does not started OVS by default"},{"line_number":30,"context_line":"        restart_service openvswitch"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2BmPk%3D","line":29,"in_reply_to":"AAAAM3%2F%2Bne8%3D","updated":"2013-02-26 09:12:57.000000000","message":"Done","commit_id":"814f21b85da3e0cc2ee13cf9948d5588e97c1aaa"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f81b79fdc39f1272af759d91d634385e62498e51","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        install_package make fakeroot dkms openvswitch-switch openvswitch-datapath-dkms linux-headers-$kernel_version"},{"line_number":27,"context_line":"    else"},{"line_number":28,"context_line":"        install_package openvswitch"},{"line_number":29,"context_line":"        # Fedora does not started OVS by default"},{"line_number":30,"context_line":"        restart_service openvswitch"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2Bne8%3D","line":29,"in_reply_to":"AAAAM3%2F%2Bnm8%3D","updated":"2013-02-25 18:01:47.000000000","message":"It actually refers to why the restart_service command below is present in the fedora branch and not the ubuntu branch above.\n\nActually this bit of code predates suse support and should probably do an \u0027elif fedora\u0027 and fall through with either an error or just let it go, whatever is appropriate in Quantum...I don\u0027t know the status of quantum-on-suse support.","commit_id":"814f21b85da3e0cc2ee13cf9948d5588e97c1aaa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2674da56cd01866f01219030872b239c53da2599","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        install_package make fakeroot dkms openvswitch-switch openvswitch-datapath-dkms linux-headers-$kernel_version"},{"line_number":27,"context_line":"    else"},{"line_number":28,"context_line":"        install_package openvswitch"},{"line_number":29,"context_line":"        # Fedora does not started OVS by default"},{"line_number":30,"context_line":"        restart_service openvswitch"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2BmPo%3D","line":29,"in_reply_to":"AAAAM3%2F%2Bnm8%3D","updated":"2013-02-26 09:12:57.000000000","message":"with fedora the ovs needs to be restarted","commit_id":"814f21b85da3e0cc2ee13cf9948d5588e97c1aaa"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"685d465c8ac83a051493ae40da9b27a6fe443e32","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        restart_service openvswitch"},{"line_number":31,"context_line":"    elif is_suse; then"},{"line_number":32,"context_line":"        ### FIXME: Find RPMs for OpenVSwitch"},{"line_number":33,"context_line":"\techo \"OpenVSwitch packages need to be located\""},{"line_number":34,"context_line":"        restart_service openvswitch"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2Bl%2Fg%3D","line":33,"updated":"2013-02-26 13:50:02.000000000","message":"hard tab","commit_id":"403902a2809111a609fe0a4dd56d8e096c35b73f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"de767eb3d46d8c376a8fa6664188c1f8c563bd9f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        restart_service openvswitch"},{"line_number":31,"context_line":"    elif is_suse; then"},{"line_number":32,"context_line":"        ### FIXME: Find RPMs for OpenVSwitch"},{"line_number":33,"context_line":"\techo \"OpenVSwitch packages need to be located\""},{"line_number":34,"context_line":"        restart_service openvswitch"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAM3%2F%2Bl3M%3D","line":33,"in_reply_to":"AAAAM3%2F%2Bl%2Fg%3D","updated":"2013-02-26 15:33:13.000000000","message":"my bad","commit_id":"403902a2809111a609fe0a4dd56d8e096c35b73f"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"b86b653b68641b9cd538a9a6325762aecb694ccd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    elif is_suse; then"},{"line_number":32,"context_line":"        ### FIXME: Find RPMs for OpenVSwitch"},{"line_number":33,"context_line":"        echo \"OpenVSwitch packages need to be located\""},{"line_number":34,"context_line":"        restart_service openvswitch"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAANH%2F%2F%2FfU%3D","line":34,"updated":"2013-02-28 05:26:18.000000000","message":"seems strange to restart openvswitch in the branch for is_suse, since we are saying that we don\u0027t have packages to install.  Or am I misreading this?\n\nOr is the thought that the restart would fail, indicating to the operator that they need to install it manually, and once they do that it would work?","commit_id":"5452b18d2374af1f192dea4cb53213ea6d7dc59e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"39796791dc881ac51fe3bd8ffd9b455d6bb12d28","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    elif is_suse; then"},{"line_number":32,"context_line":"        ### FIXME: Find RPMs for OpenVSwitch"},{"line_number":33,"context_line":"        echo \"OpenVSwitch packages need to be located\""},{"line_number":34,"context_line":"        restart_service openvswitch"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAANH%2F%2F%2FBY%3D","line":34,"in_reply_to":"AAAANH%2F%2F%2FVY%3D","updated":"2013-02-28 16:25:06.000000000","message":"I was thinking we should remove it, as in general there is no need to restart OVS here if the install was done manually (after an install, restart with kernel module reload is required). \n\nOne might argue that it is valuable though, as this restart command will fail if the user did not manually install it.  Could be a useful indicator.  I\u0027m fine either way :)","commit_id":"5452b18d2374af1f192dea4cb53213ea6d7dc59e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"19044dc657895aef29c59aaff8494b26bd39f45c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    elif is_suse; then"},{"line_number":32,"context_line":"        ### FIXME: Find RPMs for OpenVSwitch"},{"line_number":33,"context_line":"        echo \"OpenVSwitch packages need to be located\""},{"line_number":34,"context_line":"        restart_service openvswitch"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAANH%2F%2F%2FVY%3D","line":34,"in_reply_to":"AAAANH%2F%2F%2FfU%3D","updated":"2013-02-28 08:50:25.000000000","message":"i just left this for backward compatability. what do you suggest here?","commit_id":"5452b18d2374af1f192dea4cb53213ea6d7dc59e"}]}