)]}'
{"clean.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ec24f6a8f063db0c0dc36b6b723107c17793fd8e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"cleanup_nova"},{"line_number":96,"context_line":"cleanup_neutron"},{"line_number":97,"context_line":"cleanup_swift"},{"line_number":98,"context_line":"if is_service_enabled horizon; then"},{"line_number":99,"context_line":"    cleanup_horizon"},{"line_number":100,"context_line":"fi"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a2fa921_0ded378b","line":98,"updated":"2015-10-05 21:49:58.000000000","message":"I would prefer to not do the service enabled check but make the cleanup function silently succeed if horizon is not or never was installed.  clean.sh does not have the same standards in this regard as anything else in DevStack.","commit_id":"f62565998852c237d92b65f160b4308fbb10166e"}],"lib/horizon":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a1e038a88cb448e4065e68a7d5147272087b4a40","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"# start_horizon() - Start running processes, including screen"},{"line_number":180,"context_line":"function start_horizon {"},{"line_number":181,"context_line":"    enable_apache_site horizon"},{"line_number":182,"context_line":"    restart_apache_server"},{"line_number":183,"context_line":"    tail_log horizon /var/log/$APACHE_NAME/horizon_error.log"},{"line_number":184,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a2fa921_4f9c4ac0","line":181,"updated":"2015-10-07 01:20:47.000000000","message":"this is not on the cleanup path -- are we certain this is idempotent (i think it is, but not sure we do it elsewhere)\n\nis this for rejoining after stop, or what?  i should be explained as to why it\u0027s not working","commit_id":"58d4bf0db4a03b38835fc95fe45c5c32eb6cf754"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8100d6cf83f33dd26bf30e95fa02d138f6770f92","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"# start_horizon() - Start running processes, including screen"},{"line_number":180,"context_line":"function start_horizon {"},{"line_number":181,"context_line":"    enable_apache_site horizon"},{"line_number":182,"context_line":"    restart_apache_server"},{"line_number":183,"context_line":"    tail_log horizon /var/log/$APACHE_NAME/horizon_error.log"},{"line_number":184,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a2fa921_f55c9d7e","line":181,"in_reply_to":"7a2fa921_4f9c4ac0","updated":"2015-10-08 23:51:29.000000000","message":"actually it doesn\u0027t help for rejoin, because we don\u0027t call this method in screenrc\n\nI add this is because we must remove the link when stopping horizon, to avoid somewhere else, or in future, call start_horizon, we should enable it here, not only in init_horizon (I prefer to remove enable action in init_horizon but keeping it doesn\u0027t hurt as well)","commit_id":"58d4bf0db4a03b38835fc95fe45c5c32eb6cf754"}]}