)]}'
{"id":"openstack%2Fdevstack~23023","triplet_id":"openstack%2Fdevstack~master~I70a8cfe67ed408284f5c88c762c6bb8acb8ecdb2","project":"openstack/devstack","branch":"master","topic":"error_log","hashtags":[],"change_id":"I70a8cfe67ed408284f5c88c762c6bb8acb8ecdb2","subject":"Refactor error logging","status":"MERGED","created":"2013-02-26 20:45:14.000000000","updated":"2013-03-04 14:12:10.000000000","submitted":"2013-03-04 14:12:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c7f28ebe6a86a883e9c246ae6b3904019b381ef","_number":23023,"virtual_id_number":23023,"owner":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2013-03-04 14:12:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-03-04 13:37:54.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":2,"date":"2013-03-01 11:55:28.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-03-04 13:37:54.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"date":"2013-03-01 11:55:28.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-28 00:28:59.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2013-02-28 06:32:35.000000000","updated_by":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"reviewer":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"state":"REVIEWER"},{"updated":"2013-03-01 11:55:28.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-03-04 13:37:54.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-03-04 14:12:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c297a087a95e430d3679e91da4a53b209aff9e59","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-26 21:10:16.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23023/1/check/gate-tempest-devstack-vm-full/5633 : FAILURE\n- http://logs.openstack.org/23023/1/check/gate-tempest-devstack-vm-postgres-full/5352 : FAILURE\n- http://logs.openstack.org/23023/1/check/gate-tempest-devstack-vm-quantum/10341 : FAILURE\n","accounts_in_message":[],"_revision_number":1},{"id":"9d1550701725f6aed2b41a578320689b63845ce0","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-02-26 21:51:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c833c175fa739b6af46b2834752e7434ef46131d","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-02-26 21:52:34.000000000","message":"Patch Set 2:\n\nrecheck bug 1133609","accounts_in_message":[],"_revision_number":2},{"id":"ce6fd0a7fe636ab03ba73142269d0d39931998c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-26 23:10:00.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23023/2/check/gate-tempest-devstack-vm-full/5697 : FAILURE\n- http://logs.openstack.org/23023/2/check/gate-tempest-devstack-vm-postgres-full/5416 : FAILURE\n- http://logs.openstack.org/23023/2/check/gate-tempest-devstack-vm-quantum/10418 : FAILURE\n","accounts_in_message":[],"_revision_number":2},{"id":"dfcc64b94ea38431f0f582b5be10a9cf700d1307","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-02-27 22:19:34.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"75679b071317ee69e8dc402f54caa9dd13abe972","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-27 22:58:17.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23023/2/check/gate-tempest-devstack-vm-full/5963 : SUCCESS\n- http://logs.openstack.org/23023/2/check/gate-tempest-devstack-vm-postgres-full/5682 : SUCCESS\n- http://logs.openstack.org/23023/2/check/gate-tempest-devstack-vm-quantum/10722 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"0d1d0bfeea83093b19b04c4b32a24613d517b72b","author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"date":"2013-02-28 06:32:35.000000000","message":"Patch Set 2: (1 inline comment)\n\nlog_error function seems missing.","accounts_in_message":[],"_revision_number":2},{"id":"913bbf0efb775e165b9f97822f94a84303ae4ff2","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-02-28 19:59:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7fb26009f8c55326d3f73dd48a98e3dbf21b9eb5","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-02-28 19:59:48.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"bbba665805edc29013a7570234291fae4d01fae1","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-02-28 19:59:53.000000000","message":"Patch Set 2:\n\nThanks I fixed the commit message.","accounts_in_message":[],"_revision_number":2},{"id":"2604ae23d11011d296d783f1b995a183761401d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 20:39:12.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23023/3/check/gate-tempest-devstack-vm-full/6137 : SUCCESS\n- http://logs.openstack.org/23023/3/check/gate-tempest-devstack-vm-postgres-full/5856 : SUCCESS\n- http://logs.openstack.org/23023/3/check/gate-tempest-devstack-vm-quantum/10938 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"8726689550e80e0567318670ee92714cf163c514","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-03-01 11:55:28.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nnice","accounts_in_message":[],"_revision_number":3},{"id":"7a1a7476fb5e47a8ed5b0fac36949ff92570b683","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-03-04 13:37:54.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"aba608ccfeee3a5bf902af7dd6f069436056a428","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-04 13:37:56.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"9195c65f6aefa061d7903c121eb5c3a19bc9007c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-04 14:12:10.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"1445a71ac21be65c1a30541ea91b2802dd12f32d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-04 14:12:10.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23023/3/gate/gate-tempest-devstack-vm-full/6791 : SUCCESS\n- http://logs.openstack.org/23023/3/gate/gate-tempest-devstack-vm-postgres-full/6510 : SUCCESS\n- http://logs.openstack.org/23023/3/gate/gate-tempest-devstack-vm-quantum/11697 : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"07115eb5c06a7f5a63bfacdf33ded466c8f2e2c9","revisions":{"96ed48f6213825e1a5ebdc1d000f84a7caf12619":{"kind":"REWORK","_number":1,"created":"2013-02-26 20:45:14.000000000","uploader":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"ref":"refs/changes/23/23023/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/23/23023/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/23/23023/1"}}},"commit":{"parents":[{"commit":"921f2dab624c045d2be321d986b4769c7fb7de99","subject":"move sysstat earlier (but not too early)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/921f2dab624c045d2be321d986b4769c7fb7de99"}]}],"author":{"name":"Nachi Ueno","email":"nachi@nttmcl.com","date":"2013-02-26 20:38:18.000000000","tz":-480},"committer":{"name":"Nachi Ueno","email":"nachi@nttmcl.com","date":"2013-02-26 20:38:18.000000000","tz":-480},"subject":"Refactor error logging","message":"Refactor error logging\n\nIt is hard to grep errors in current log. so in this patch,\nI\u0027m adding log_error function which also writes log for\nscreen_log_dir/error.log.\nIn future, we may categolize negative fault by using\nthis error.log.\n\nChange-Id: I70a8cfe67ed408284f5c88c762c6bb8acb8ecdb2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/96ed48f6213825e1a5ebdc1d000f84a7caf12619"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/96ed48f6213825e1a5ebdc1d000f84a7caf12619"}]},"branch":"refs/heads/master"},"d1a11912b8fcada07766eb39be4f47d5cf1ba220":{"kind":"REWORK","_number":2,"created":"2013-02-26 21:51:58.000000000","uploader":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"ref":"refs/changes/23/23023/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/23/23023/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/23/23023/2"}}},"commit":{"parents":[{"commit":"921f2dab624c045d2be321d986b4769c7fb7de99","subject":"move sysstat earlier (but not too early)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/921f2dab624c045d2be321d986b4769c7fb7de99"}]}],"author":{"name":"Nachi Ueno","email":"nachi@nttmcl.com","date":"2013-02-26 20:38:18.000000000","tz":-480},"committer":{"name":"Nachi Ueno","email":"nachi@nttmcl.com","date":"2013-02-26 21:47:09.000000000","tz":-480},"subject":"Refactor error logging","message":"Refactor error logging\n\nIt is hard to grep errors in current log. so in this patch,\nI\u0027m adding log_error function which also writes log for\nscreen_log_dir/error.log.\nIn future, we may categolize negative fault by using\nthis error.log.\n\nChange-Id: I70a8cfe67ed408284f5c88c762c6bb8acb8ecdb2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d1a11912b8fcada07766eb39be4f47d5cf1ba220"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d1a11912b8fcada07766eb39be4f47d5cf1ba220"}]},"branch":"refs/heads/master"},"07115eb5c06a7f5a63bfacdf33ded466c8f2e2c9":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-02-28 19:59:41.000000000","uploader":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"ref":"refs/changes/23/23023/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/23/23023/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/23/23023/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/23/23023/3"}}},"commit":{"parents":[{"commit":"921f2dab624c045d2be321d986b4769c7fb7de99","subject":"move sysstat earlier (but not too early)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/921f2dab624c045d2be321d986b4769c7fb7de99"}]}],"author":{"name":"Nachi Ueno","email":"nachi@nttmcl.com","date":"2013-02-26 20:38:18.000000000","tz":-480},"committer":{"name":"Nachi Ueno","email":"nachi@nttmcl.com","date":"2013-02-28 19:54:24.000000000","tz":-480},"subject":"Refactor error logging","message":"Refactor error logging\n\nIt is hard to grep errors in current log. so in this patch,\nI\u0027m updating die function which also writes log for\nscreen_log_dir/error.log.\nIn future, we may categolize negative fault by using\nthis error.log.\n\nChange-Id: I70a8cfe67ed408284f5c88c762c6bb8acb8ecdb2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/07115eb5c06a7f5a63bfacdf33ded466c8f2e2c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/07115eb5c06a7f5a63bfacdf33ded466c8f2e2c9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}