)]}'
{"id":"openstack%2Fdevstack~23187","triplet_id":"openstack%2Fdevstack~master~I4c6e8ee31f298004338ca46bfc330a3e3af288aa","project":"openstack/devstack","branch":"master","topic":"bug/1136028","hashtags":[],"change_id":"I4c6e8ee31f298004338ca46bfc330a3e3af288aa","subject":"Allow DATABASE_TYPE to be specified in localrc","status":"MERGED","created":"2013-02-28 17:40:41.000000000","updated":"2013-03-02 03:10:37.000000000","submitted":"2013-03-02 03:10:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d1a198976a5114935513271a4e4b5027449687b5","_number":23187,"virtual_id_number":23187,"owner":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-03-02 03:10:37.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-03-01 20:36:33.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-03-01 21:03:47.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-01 20:36:33.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-03-01 21:03:47.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-01 20:36:33.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-03-01 21:03:47.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-03-02 03:10:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"65f19e65a24b3aeca3b6e537357eb7d87b0bef5e","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-02-28 17:44:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"177a015c96bb2ff157ac0e2acf0b619fc8e6e418","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-02-28 17:44:35.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"e99522b7852fd70af5686618ecf15e37585d811f","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-02-28 17:46:31.000000000","message":"Patch Set 2:\n\nAdded reviewers of https://review.openstack.org/#/c/22635/1 which deprecated DATABASE_TYPE and added this behaviour.","accounts_in_message":[],"_revision_number":2},{"id":"2e71f36acecb59483ea39825327c5870bfb3d11e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 18:23:10.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23187/2/check/gate-tempest-devstack-vm-full/6103 : SUCCESS\n- http://logs.openstack.org/23187/2/check/gate-tempest-devstack-vm-postgres-full/5822 : SUCCESS\n- http://logs.openstack.org/23187/2/check/gate-tempest-devstack-vm-quantum/10900 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"cab0e461f7d15b57e8f796be5165ca3b777bded6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-02-28 23:16:17.000000000","message":"Patch Set 2:\n\nThanks for putting this here Bob.  I think your last point in the commit message is where we need to go...DATABASE_TYPE is a useful configuration option in multi-node, maybe we don\u0027t need the backward compatibility.  I see this for the steps:\n* add the database to ENABLED_SERVICES on the node that actually runs the database; this triggers the db to be installed and initialized\n* add DATABASE_TYPE on compute nodes; it is inferred if a database is in ENABLED_SERVICES; this allows database_connection_url() to do the Right Thing(TM) in setting up the connection string\n* if both ENABLED_SERVICES and DATABASE_TYPE are set, ENABLED_SERVICES wins and DATABASE_TYPE will be overridden to match.\n\nAnyone who is still configuring the DB only with DATABASE_TYPE will not have a database running anywhere.\n\nThoughts?","accounts_in_message":[],"_revision_number":2},{"id":"51161eb3eddec263653f6ae92aeb8857fbade755","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-03-01 10:42:50.000000000","message":"Patch Set 2:\n\nThat sounds good to me - however I\u0027m very new to devstack so my view shouldn\u0027t count for much!","accounts_in_message":[],"_revision_number":2},{"id":"e54966a82de78840399b587627f34445a770cccd","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-03-01 14:06:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"adf2ac07e0e09dc99c34e920849734fd98946e90","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 14:44:54.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23187/3/check/gate-tempest-devstack-vm-full/6277 : SUCCESS\n- http://logs.openstack.org/23187/3/check/gate-tempest-devstack-vm-postgres-full/5996 : SUCCESS\n- http://logs.openstack.org/23187/3/check/gate-tempest-devstack-vm-quantum/11100 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"ddbf7af043152fe47e09f7f0c618edef627e9b36","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-01 20:36:33.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nThis has been working fine for me in a couple of permutations, but only in single node configs.  I\u0027m not going to get to multi-node until next week but am OK putting this in anyway.  I think this will be just the first of a couple of fixes for multi-node to work like it did last summer.","accounts_in_message":[],"_revision_number":3},{"id":"d9706e2ca043b8219d96c5ef65a535e4a8772f97","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-03-01 21:03:47.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"f99bc499b949909f718b02899e9f0dbf554c3e03","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 21:03:55.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"f50b8c09cde31807d8a094930ff42efe45cc4aa5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-02 03:10:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"64fce898ae9573bea009def4932c783494e39b89","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-02 03:10:37.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23187/3/gate/gate-tempest-devstack-vm-full/6658 : SUCCESS\n- http://logs.openstack.org/23187/3/gate/gate-tempest-devstack-vm-postgres-full/6377 : SUCCESS\n- http://logs.openstack.org/23187/3/gate/gate-tempest-devstack-vm-quantum/11513 : SUCCESS\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3aa8887170200a8bcf3e4a909059428b360f0c3d","revisions":{"d666cc919d722423c3320e897af54d3f70bc6919":{"kind":"REWORK","_number":1,"created":"2013-02-28 17:40:41.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/87/23187/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/87/23187/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/87/23187/1"}}},"commit":{"parents":[{"commit":"493db1eb2980b156cad5de7710dddc7a2d1733e1","subject":"Merge \"Add genisoimage to package dependencies:\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/493db1eb2980b156cad5de7710dddc7a2d1733e1"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-02-28 17:39:41.000000000","tz":0},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-02-28 17:39:41.000000000","tz":0},"subject":"Allow DATABASE_TYPE to be specified in localrc without forcing it in ENABLED_SERVICES","message":"Allow DATABASE_TYPE to be specified in localrc without forcing it in ENABLED_SERVICES\n\nChange-Id: I4c6e8ee31f298004338ca46bfc330a3e3af288aa\nFixes: bug 1136028\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d666cc919d722423c3320e897af54d3f70bc6919"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d666cc919d722423c3320e897af54d3f70bc6919"}]},"branch":"refs/heads/master"},"065cabe4020abc4c3cf74526f64efc87b49464a9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-02-28 17:44:27.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/87/23187/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/87/23187/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/87/23187/2"}}},"commit":{"parents":[{"commit":"493db1eb2980b156cad5de7710dddc7a2d1733e1","subject":"Merge \"Add genisoimage to package dependencies:\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/493db1eb2980b156cad5de7710dddc7a2d1733e1"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-02-28 17:39:41.000000000","tz":0},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-02-28 17:41:51.000000000","tz":0},"subject":"Allow DATABASE_TYPE to be specified in localrc","message":"Allow DATABASE_TYPE to be specified in localrc\n\nThe use of DATABASE_TYPE without forcing it into ENABLED_SERVICES\nseems to be the only way to set up a multi-host devstack installation.\n\nIf there are other ways to set up a multi-host installation, then this\nchange may not be needed.\n\nAlso, we should look at whether DATABASE_TYPE should be deprecated or\nif we can safely just deprecate use_database\n\nChange-Id: I4c6e8ee31f298004338ca46bfc330a3e3af288aa\nFixes: bug 1136028\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/065cabe4020abc4c3cf74526f64efc87b49464a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/065cabe4020abc4c3cf74526f64efc87b49464a9"}]},"branch":"refs/heads/master"},"3aa8887170200a8bcf3e4a909059428b360f0c3d":{"kind":"REWORK","_number":3,"created":"2013-03-01 14:06:07.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/87/23187/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/87/23187/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/87/23187/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/87/23187/3"}}},"commit":{"parents":[{"commit":"493db1eb2980b156cad5de7710dddc7a2d1733e1","subject":"Merge \"Add genisoimage to package dependencies:\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/493db1eb2980b156cad5de7710dddc7a2d1733e1"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-02-28 17:39:41.000000000","tz":0},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-03-01 14:04:13.000000000","tz":0},"subject":"Allow DATABASE_TYPE to be specified in localrc","message":"Allow DATABASE_TYPE to be specified in localrc\n\nThe use of DATABASE_TYPE without forcing it into ENABLED_SERVICES\nseems to be the only way to set up a multi-host devstack installation.\n\nOnly deprecate use_database.\nChanges functionality of use_database to be equivalent to specifying DATABASE_TYPE\nThis means that people with localrc\u0027s that only specify use_database used to have\na database service brought up, but now will not until they add it to ENABLED_SERVICES.\n\nChange-Id: I4c6e8ee31f298004338ca46bfc330a3e3af288aa\nFixes: bug 1136028\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3aa8887170200a8bcf3e4a909059428b360f0c3d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3aa8887170200a8bcf3e4a909059428b360f0c3d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}