)]}'
{"id":"openstack%2Fdevstack~233106","triplet_id":"openstack%2Fdevstack~master~I0f9403f44ed2fe693a46cd02486bd94043ce6b1a","project":"openstack/devstack","branch":"master","topic":"bug/1504304","hashtags":[],"change_id":"I0f9403f44ed2fe693a46cd02486bd94043ce6b1a","subject":"Perform additional disable_service checks","status":"MERGED","created":"2015-10-09 15:03:07.000000000","updated":"2016-04-19 23:17:41.000000000","submitted":"2015-10-12 03:03:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"34c6e3b1aa7e88da980e6ccdf3eff18dee54210d","_number":233106,"virtual_id_number":233106,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-10-09 16:44:51.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-10-12 03:03:53.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2015-10-09 16:40:25.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":2,"date":"2015-10-12 01:39:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":1,"date":"2015-10-12 01:39:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-09 16:40:25.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2015-10-09 16:44:51.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-10-12 01:39:06.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-10-12 03:03:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"acdfefee82f3c574b1998a6bb2d5ca30cbfa83f0","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-10-09 15:03:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea21ade1ef839a0577957f480a29305498c23a5c","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-10-09 15:07:46.000000000","message":"Patch Set 1: Workflow-1\n\nGonna refactor this to provide some warnings.","accounts_in_message":[],"_revision_number":1},{"id":"fe9a73783e99109822b4b18eae17c4c3e283619d","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-10-09 16:13:24.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/06/233106/1/13322/index.html : SUCCESS in 58 m 08 s","accounts_in_message":[],"_revision_number":1},{"id":"a6711e801e15f1bc1959166708c1265f63402675","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 16:33:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-tempest-dsvm-full http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-full/fc5b46c/ : SUCCESS in 54m 47s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-postgres-full/f4446f8/ : SUCCESS in 55m 06s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-neutron-full/0088206/ : SUCCESS in 1h 19m 15s\n- gate-grenade-dsvm http://logs.openstack.org/06/233106/1/check/gate-grenade-dsvm/9b75d87/ : SUCCESS in 54m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-large-ops/8110a3e/ : SUCCESS in 36m 19s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-neutron-large-ops/423eb33/ : SUCCESS in 33m 13s\n- gate-devstack-bashate http://logs.openstack.org/06/233106/1/check/gate-devstack-bashate/d713c7e/ : SUCCESS in 21s\n- gate-devstack-unit-tests http://logs.openstack.org/06/233106/1/check/gate-devstack-unit-tests/ae2ea07/ : FAILURE in 32s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/06/233106/1/check/gate-grenade-dsvm-partial-ncpu/7308c46/ : SUCCESS in 1h 02m 21s\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-ironic-agent_ssh/9bdee9e/ : SUCCESS in 52m 33s\n- gate-devstack-dsvm-updown http://logs.openstack.org/06/233106/1/check/gate-devstack-dsvm-updown/5ffd5de/ : SUCCESS in 32m 43s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-f21/13c7432/ : SUCCESS in 1h 22m 30s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-centos7/c075e63/ : SUCCESS in 45m 58s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/06/233106/1/check/gate-devstack-publish-docs/e944a0f//doc/build/html/ : SUCCESS in 1m 12s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/06/233106/1/check/gate-swift-dsvm-functional-nv/cf50e85/ : SUCCESS in 38m 47s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/06/233106/1/check/gate-grenade-dsvm-neutron/97a9c27/ : SUCCESS in 1h 03m 40s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-multinode-full/2b0c6a8/ : FAILURE in 59m 24s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/06/233106/1/check/gate-tempest-dsvm-neutron-multinode-full/680e8cf/ : FAILURE in 1h 07m 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"45993bb8af113aa0b11ff5ad679938f38e752efe","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-10-09 16:37:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a1f763354fe4379b7cf8a6005afe99ff7185bb04","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-09 16:40:25.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c8786b63814a1a836ff6e959f6b6a10ce18b263b","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-10-09 16:44:51.000000000","message":"Patch Set 2:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/06/233106/2/13332/index.html : FAILURE in 05 m 24 s","accounts_in_message":[],"_revision_number":2},{"id":"3ec03bbbb51a0e477907ad2ab67db275541a776c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 18:00:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-full/90c32df/ : SUCCESS in 58m 54s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-postgres-full/046cb4d/ : SUCCESS in 57m 49s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-neutron-full/e8f41d7/ : SUCCESS in 1h 09m 16s\n- gate-grenade-dsvm http://logs.openstack.org/06/233106/2/check/gate-grenade-dsvm/f19ee45/ : SUCCESS in 55m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-large-ops/5721007/ : SUCCESS in 28m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-neutron-large-ops/f18afe9/ : SUCCESS in 35m 23s\n- gate-devstack-bashate http://logs.openstack.org/06/233106/2/check/gate-devstack-bashate/b8aab2a/ : SUCCESS in 25s\n- gate-devstack-unit-tests http://logs.openstack.org/06/233106/2/check/gate-devstack-unit-tests/659b016/ : SUCCESS in 23s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/06/233106/2/check/gate-grenade-dsvm-partial-ncpu/69fcc31/ : SUCCESS in 50m 01s\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-ironic-agent_ssh/6fb881b/ : SUCCESS in 48m 58s\n- gate-devstack-dsvm-updown http://logs.openstack.org/06/233106/2/check/gate-devstack-dsvm-updown/341feb4/ : SUCCESS in 22m 24s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-f21/9cd667a/ : SUCCESS in 43m 07s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-centos7/8c0b516/ : SUCCESS in 28m 08s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/06/233106/2/check/gate-devstack-publish-docs/5f9761f//doc/build/html/ : SUCCESS in 1m 45s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/06/233106/2/check/gate-swift-dsvm-functional-nv/9c459cf/ : SUCCESS in 35m 21s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/06/233106/2/check/gate-grenade-dsvm-neutron/b773ce9/ : SUCCESS in 46m 47s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-multinode-full/2a8c4cc/ : SUCCESS in 51m 33s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/06/233106/2/check/gate-tempest-dsvm-neutron-multinode-full/88ec31d/ : SUCCESS in 1h 02m 07s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"624c9320514f1ec5d8a2acb950c72ceaae1701b6","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-10-12 01:39:06.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\nThis LGTM based on the principle of least-surprise -- if you disable in local.conf you expect that to apply always.\n\nI like the checking for modification of ENABLED_SERVICES.\n\nI think we need to make sure we\u0027re namespacing globals more carefully; in most other areas it\u0027s well recognised that if you start using _ or __ prefixed variables you get to keep whatever brokenness you\u0027ve created.  I think we\u0027d do well to move towards similar approach.  This code has obviously been around longer than people thinking about plugins, however","accounts_in_message":[],"_revision_number":2},{"id":"19c763882e50557c69e671da81eb595dae80ecfe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-12 01:39:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"4ce0c224e02978460845bc30659a8026450f0b79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-12 03:03:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/06/233106/2/gate/gate-tempest-dsvm-full/1bd6869/ : SUCCESS in 39m 24s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/06/233106/2/gate/gate-tempest-dsvm-postgres-full/b121511/ : SUCCESS in 37m 28s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/06/233106/2/gate/gate-tempest-dsvm-neutron-full/aa609a9/ : SUCCESS in 1h 24m 31s\n- gate-grenade-dsvm http://logs.openstack.org/06/233106/2/gate/gate-grenade-dsvm/f3fd382/ : SUCCESS in 53m 38s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/06/233106/2/gate/gate-tempest-dsvm-large-ops/356258f/ : SUCCESS in 27m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/06/233106/2/gate/gate-tempest-dsvm-neutron-large-ops/c396a4f/ : SUCCESS in 34m 27s\n- gate-devstack-bashate http://logs.openstack.org/06/233106/2/gate/gate-devstack-bashate/c027ae9/ : SUCCESS in 21s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/06/233106/2/gate/gate-grenade-dsvm-partial-ncpu/44eff92/ : SUCCESS in 40m 41s","accounts_in_message":[],"_revision_number":2},{"id":"defdc611cd506a77c34ce4eb708139b2379668b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-12 03:03:55.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"6ccfef6f7812be037c36eae5f45017d334ff4f16","author":{"_account_id":6671,"name":"Jerry Zhao","email":"xyzjerry@gmail.com","username":"zhaoxinyu"},"date":"2016-04-19 23:17:41.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/liberty as commit 2af47f99fdb350e2053599849dafb488c77cab13","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c6d470142e0a0359a7322e9b76d61ba15caf95bc","revisions":{"39174564dc88f6142c9414c3542e06209f64335c":{"kind":"REWORK","_number":1,"created":"2015-10-09 15:03:07.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/06/233106/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/06/233106/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/233106/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/233106/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/233106/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/06/233106/1"}}},"commit":{"parents":[{"commit":"b2b82a0f34d84ecf5329703bf6e63c89272ef2da","subject":"Merge \"Move $DEST creation after logging setup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b2b82a0f34d84ecf5329703bf6e63c89272ef2da"}]}],"author":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2015-10-09 14:57:05.000000000","tz":0},"committer":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2015-10-09 14:57:05.000000000","tz":0},"subject":"Perform service disablement in a lazy fashion","message":"Perform service disablement in a lazy fashion\n\nWith the advent of plugins and their settings files it has become\npossible to disable_service in local.conf only to have the service\nre-enabled in a plugin settings file. This happens because of\nprocessing order.\n\nTo get around this the disable_service function now aggregates\nrequests into a DISABLED_SERVICES variable which is then processed\nby perform_disable_service just after the \"source\" phase of\nstacking. This allows local.conf to win the race which is likely to\nmore accurately reflect people\u0027s expectations.\n\nChange-Id: I0f9403f44ed2fe693a46cd02486bd94043ce6b1a\nCloses-Bug: #1504304\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/39174564dc88f6142c9414c3542e06209f64335c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/39174564dc88f6142c9414c3542e06209f64335c"}]},"branch":"refs/heads/master"},"c6d470142e0a0359a7322e9b76d61ba15caf95bc":{"kind":"REWORK","_number":2,"created":"2015-10-09 16:37:23.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/06/233106/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/06/233106/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/233106/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/233106/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/233106/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/06/233106/2"}}},"commit":{"parents":[{"commit":"b2b82a0f34d84ecf5329703bf6e63c89272ef2da","subject":"Merge \"Move $DEST creation after logging setup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b2b82a0f34d84ecf5329703bf6e63c89272ef2da"}]}],"author":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2015-10-09 14:57:05.000000000","tz":0},"committer":{"name":"Chris Dent","email":"chdent@redhat.com","date":"2015-10-09 16:34:32.000000000","tz":0},"subject":"Perform additional disable_service checks","message":"Perform additional disable_service checks\n\nWith the advent of plugins and their settings files it has become\npossible to disable_service in local.conf only to have the service\nre-enabled in a plugin settings file. This happens because of\nprocessing order.\n\nTo get around this the disable_service function now aggregates\nservice names into a DISABLED_SERVICES variable which is then checked\nduring enable_service. If something tries to enable something that\nwas previously disabled, a warning is produced in the log and the\nservice is not enabled.\n\nThen after all configuration has been sourced a final check is to\ndone by verify_disabled_services to confirm that something has not\nmanually adjusted ENABLED_SERVICES to overcome a previously called\ndisable_service. If something has, the stack dies with an error.\n\nChange-Id: I0f9403f44ed2fe693a46cd02486bd94043ce6b1a\nCloses-Bug: #1504304\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c6d470142e0a0359a7322e9b76d61ba15caf95bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c6d470142e0a0359a7322e9b76d61ba15caf95bc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}