)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"88fb16e4d5a2ad0e92464cdde89840b7d924cebd","unresolved":false,"context_lines":[{"line_number":838,"context_line":"# runs that a clean run would need to clean up"},{"line_number":839,"context_line":"function cleanup_neutron {"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    _move_neutron_addresses_route \"$OVS_PHYSICAL_BRIDGE\" \"$PUBLIC_INTERFACE\" False \"inet\""},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    if [[ \"$OVS_PHYSICAL_BRIDGE\" !\u003d \"\" \u0026\u0026 $(ip -f inet6 a s dev \"$OVS_PHYSICAL_BRIDGE\" | grep -c \u0027global\u0027) !\u003d 0 ]]; then"},{"line_number":844,"context_line":"        _move_neutron_addresses_route \"$OVS_PHYSICAL_BRIDGE\" \"$PUBLIC_INTERFACE\" False \"inet6\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a2fa921_df77f706","line":841,"updated":"2015-10-12 01:45:55.000000000","message":"I think either this should be checked and not called too, or just remove the \"ip\" check below ... it looks like _move_neutron_address_route just returns if $OVS_PHYSICAL_BRIDGE is empty anyway","commit_id":"e88a7534ea6045141c86c1ab4a56abb197da3218"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"54f838372005853a9eb38dd6543ec873d910cde0","unresolved":false,"context_lines":[{"line_number":838,"context_line":"# runs that a clean run would need to clean up"},{"line_number":839,"context_line":"function cleanup_neutron {"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    _move_neutron_addresses_route \"$OVS_PHYSICAL_BRIDGE\" \"$PUBLIC_INTERFACE\" False \"inet\""},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    if [[ \"$OVS_PHYSICAL_BRIDGE\" !\u003d \"\" \u0026\u0026 $(ip -f inet6 a s dev \"$OVS_PHYSICAL_BRIDGE\" | grep -c \u0027global\u0027) !\u003d 0 ]]; then"},{"line_number":844,"context_line":"        _move_neutron_addresses_route \"$OVS_PHYSICAL_BRIDGE\" \"$PUBLIC_INTERFACE\" False \"inet6\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a2fa921_a4d0e0f8","line":841,"in_reply_to":"7a2fa921_df77f706","updated":"2015-10-12 11:31:01.000000000","message":"The function _move_neutron_address_route has judged the 1st arg. If $OVS_PHYSICAL_BRIDGE is empty the function will do nothing. So I don\u0027t think this should  be checked","commit_id":"e88a7534ea6045141c86c1ab4a56abb197da3218"}]}