)]}'
{"id":"openstack%2Fdevstack~233596","triplet_id":"openstack%2Fdevstack~master~I798630edf832a4e930d65853d48b0bab529c5a1e","project":"openstack/devstack","branch":"master","topic":"locals","hashtags":[],"change_id":"I798630edf832a4e930d65853d48b0bab529c5a1e","subject":"use less generic variable for iteration","status":"ABANDONED","created":"2015-10-12 11:30:30.000000000","updated":"2015-10-12 12:38:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"99fc47bce70123b893416f857be952e14702ea86","_number":233596,"virtual_id_number":233596,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"all":[{"date":"2015-10-12 12:38:52.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-10-12 11:39:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-12 11:39:33.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2015-10-12 12:38:52.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"409a5b909b144c513d5e2134d7ae1d300d053a51","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-12 11:30:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2971791305e4465b22b061341c8b2f882cd25577","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-12 11:35:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6e1dbe520ad237f8cafc92e6ca3ee63e1b9cd42a","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2015-10-12 11:39:33.000000000","message":"Patch Set 2: Code-Review+1\n\nah good, you caught my concern (and was writing about on patch set 1)\n\nlocal is \"local to this function and its children\" which means it will show up in things sourced from the function.","accounts_in_message":[],"_revision_number":2},{"id":"a431ad8ec9a2e7b8f395a50a214f274c8a32c673","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-12 11:40:42.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2},{"id":"0148cd764aae74bc422c337a31c0d41ef62416dc","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-10-12 12:38:52.000000000","message":"Patch Set 2:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/96/233596/2/13402/index.html : SUCCESS in 59 m 45 s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"297ca1064cc2f1f982b1071ba992b5eb23edd7b3","revisions":{"d74d93c4f27992b7c307d2d039cf098709af3c40":{"kind":"REWORK","_number":1,"created":"2015-10-12 11:30:30.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/96/233596/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/96/233596/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/233596/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/233596/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/233596/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/96/233596/1"}}},"commit":{"parents":[{"commit":"0914d04343b60392c5227559dcaa0da39b2d1c64","subject":"Merge \"docs: Move tip about Extension Drivers into misc section\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0914d04343b60392c5227559dcaa0da39b2d1c64"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-10-12 11:29:17.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-10-12 11:29:17.000000000","tz":-240},"subject":"make i local in run_phase","message":"make i local in run_phase\n\nWe were getting some spill over because i might have a value which\nisn\u0027t related. This should shield us from that.\n\nChange-Id: I798630edf832a4e930d65853d48b0bab529c5a1e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d74d93c4f27992b7c307d2d039cf098709af3c40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d74d93c4f27992b7c307d2d039cf098709af3c40"}]},"branch":"refs/heads/master"},"297ca1064cc2f1f982b1071ba992b5eb23edd7b3":{"kind":"REWORK","_number":2,"created":"2015-10-12 11:35:16.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/96/233596/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/96/233596/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/233596/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/233596/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/233596/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/96/233596/2"}}},"commit":{"parents":[{"commit":"0914d04343b60392c5227559dcaa0da39b2d1c64","subject":"Merge \"docs: Move tip about Extension Drivers into misc section\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0914d04343b60392c5227559dcaa0da39b2d1c64"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-10-12 11:29:17.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2015-10-12 11:33:29.000000000","tz":-240},"subject":"use less generic variable for iteration","message":"use less generic variable for iteration\n\nUsing i for iteration is dangerous if you do a ``source`` inside the\nfunction, because it means someone else\u0027s non localized use of i might\nchange that value later. This happens in the ironic case.\n\nChange-Id: I798630edf832a4e930d65853d48b0bab529c5a1e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/297ca1064cc2f1f982b1071ba992b5eb23edd7b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/297ca1064cc2f1f982b1071ba992b5eb23edd7b3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}