)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e319fa357b39f6d331909be0adbf11b44a4768a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eugene Nikanorov \u003cenikanorov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-03 21:55:06 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements bluepring quantum-lbaas-plugin-support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for quantum lbaas plugin."},{"line_number":10,"context_line":"Configure service_plugins and lbaas agent"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAN3%2F%2F%2Fbo%3D","line":7,"updated":"2013-03-04 13:27:28.000000000","message":"bluepring \u003d\u003e blueprint","commit_id":"c3e11a6dddef9a2224abfd95cf5f4b16d6aabccd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f27e0eef604ccda4a808966852c994ff52747db7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eugene Nikanorov \u003cenikanorov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-03 21:55:06 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements bluepring quantum-lbaas-plugin-support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for quantum lbaas plugin."},{"line_number":10,"context_line":"Configure service_plugins and lbaas agent"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAN3%2F%2F%2FZ0%3D","line":7,"in_reply_to":"AAAAN3%2F%2F%2Fbo%3D","updated":"2013-03-04 13:49:37.000000000","message":"Done","commit_id":"c3e11a6dddef9a2224abfd95cf5f4b16d6aabccd"}],"lib/quantum":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8176f5983fb7e6a0962d5c34738f83858621f42a","unresolved":false,"context_lines":[{"line_number":501,"context_line":"    quantum_agent_lbaas_install_agent_packages"},{"line_number":502,"context_line":"    quantum_agent_lbaas_configure_common"},{"line_number":503,"context_line":"    quantum_agent_lbaas_configure_agent"},{"line_number":504,"context_line":"}"},{"line_number":505,"context_line":"# _configure_quantum_plugin_agent() - Set config files for quantum plugin agent"},{"line_number":506,"context_line":"# It is called when q-agt is enabled."},{"line_number":507,"context_line":"function _configure_quantum_plugin_agent() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F604%3D","line":504,"updated":"2013-03-06 14:19:30.000000000","message":"please add new line","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"}],"lib/quantum_plugins/agent_loadbalancer":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2c28dbe2fb686c5ef414b7ec63e31c3a8201d6aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin "},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAANn%2F%2F%2F%2FU%3D","line":1,"updated":"2013-03-03 18:23:37.000000000","message":"trailing space","commit_id":"cf26add90549ef813b2f0e1f4eb5719fe6505136"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2c28dbe2fb686c5ef414b7ec63e31c3a8201d6aa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"function quantum_agent_lbaas_configure_common() {"},{"line_number":15,"context_line":"    # TODO: should be a concatenation of classes, separated by comma"},{"line_number":16,"context_line":"    if [[ $Q_SERVICE_PLUGIN_CLASSES \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":17,"context_line":"    \tQ_SERVICE_PLUGIN_CLASSES\u003d\"quantum.plugins.services.agent_loadbalancer.plugin.LoadBalancerPlugin\""},{"line_number":18,"context_line":"    else"},{"line_number":19,"context_line":"\tQ_SERVICE_PLUGIN_CLASSES\u003d\"$Q_SERVICE_PLUGIN_CLASSES,quantum.plugins.services.agent_loadbalancer.plugin.LoadBalancerPlugin\""},{"line_number":20,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAANn%2F%2F%2F%2FQ%3D","line":17,"updated":"2013-03-03 18:23:37.000000000","message":"space and tab","commit_id":"cf26add90549ef813b2f0e1f4eb5719fe6505136"},{"author":{"_account_id":5983,"name":"Leon Cui","email":"lcui@vmware.com","username":"lcui"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F%2BEg%3D","line":1,"updated":"2013-03-05 00:44:22.000000000","message":"PLease  use formal openstack file header.","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f27e0eef604ccda4a808966852c994ff52747db7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F9oY%3D","line":1,"in_reply_to":"AAAAN3%2F%2F%2BEg%3D","updated":"2013-03-05 05:54:44.000000000","message":"I did just like other quantum plugin script libraries are written: no header. Check lib/quantum_plugins/...","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":5983,"name":"Leon Cui","email":"lcui@vmware.com","username":"lcui"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function quantum_agent_lbaas_install_agent_packages() {"},{"line_number":7,"context_line":"    if is_ubuntu || is_fedora; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F%2BEA%3D","line":4,"updated":"2013-03-05 00:44:22.000000000","message":"Is it a bash script?  If yes, should add the following line in the 1st line:\n\n#!/bin/bash","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f27e0eef604ccda4a808966852c994ff52747db7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function quantum_agent_lbaas_install_agent_packages() {"},{"line_number":7,"context_line":"    if is_ubuntu || is_fedora; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F9oA%3D","line":4,"in_reply_to":"AAAAN3%2F%2F%2BEA%3D","updated":"2013-03-05 05:54:44.000000000","message":"Why? It\u0027s not a command execution. This line defines variable that is used outside this file.\nquantum-lbaas-agent is python script that is being started from lib/quantum via python.","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":5983,"name":"Leon Cui","email":"lcui@vmware.com","username":"lcui"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function quantum_agent_lbaas_install_agent_packages() {"},{"line_number":7,"context_line":"    if is_ubuntu || is_fedora; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F9l0%3D","line":4,"in_reply_to":"AAAAN3%2F%2F9oA%3D","updated":"2013-03-05 06:12:02.000000000","message":"I see.","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8176f5983fb7e6a0962d5c34738f83858621f42a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    LBAAS_AGENT_CONF_PATH\u003d/etc/quantum/plugins/services/agent_loadbalancer"},{"line_number":22,"context_line":"    mkdir -p $LBAAS_AGENT_CONF_PATH"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    LBAAS_AGENT_CONF_FILENAME\u003d\"$LBAAS_AGENT_CONF_PATH/lbaas_agent.ini\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    cp $QUANTUM_DIR/etc/lbaas_agent.ini /$LBAAS_AGENT_CONF_FILENAME"},{"line_number":27,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F7Mw%3D","line":24,"updated":"2013-03-06 07:25:44.000000000","message":"With Fedora there is an issue with the nogroup in the configuration file. (Please see https://review.openstack.org/#/c/23368/). We added in a new configuration variable - can you please set it to nobody if the distribution is fedora.","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8176f5983fb7e6a0962d5c34738f83858621f42a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    cp $QUANTUM_DIR/etc/lbaas_agent.ini /$LBAAS_AGENT_CONF_FILENAME"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if [[ $Q_PLUGIN \u003d\u003d \u0027linuxbridge\u0027 ]]; then"},{"line_number":29,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT interface_driver \"quantum.agent.linux.interface.BridgeInterfaceDriver\""},{"line_number":30,"context_line":"    fi"},{"line_number":31,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAN3%2F%2F7Ms%3D","line":28,"updated":"2013-03-06 07:25:44.000000000","message":"would it not be better to enable each plugin to be able to set the driver - for example the DHCP agent has the following quantum_plugin_configure_dhcp_agent - maybe we should have the same kind of interface here that will enable each plugin to set the appropriate driver","commit_id":"445e9f0fa0223958fc478d8aa0334aab9ec66170"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8176f5983fb7e6a0962d5c34738f83858621f42a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function quantum_agent_lbaas_install_agent_packages() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F60w%3D","line":3,"updated":"2013-03-06 14:19:30.000000000","message":"Consider adding:\n# Save trace setting\nMY_XTRACE\u003d$(set +o | grep xtrace)\nset +o xtrace","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d2d37cd8bc6162f1482b88d24377b9afb3472107","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Quantum loadbalancer plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"AGENT_LBAAS_BINARY\u003d\"$QUANTUM_DIR/bin/quantum-lbaas-agent\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function quantum_agent_lbaas_install_agent_packages() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F6zA%3D","line":3,"in_reply_to":"AAAAN3%2F%2F60w%3D","updated":"2013-03-06 14:28:50.000000000","message":"Done","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8176f5983fb7e6a0962d5c34738f83858621f42a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    cp $QUANTUM_DIR/etc/lbaas_agent.ini /$LBAAS_AGENT_CONF_FILENAME"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if [[ $Q_PLUGIN \u003d\u003d \u0027linuxbridge\u0027 || $Q_PLUGIN \u003d\u003d \u0027brocade\u0027 ]]; then"},{"line_number":29,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT interface_driver \"quantum.agent.linux.interface.BridgeInterfaceDriver\""},{"line_number":30,"context_line":"    else"},{"line_number":31,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT interface_driver \"quantum.agent.linux.interface.OVSInterfaceDriver\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F60Q%3D","line":28,"updated":"2013-03-06 14:19:30.000000000","message":"wonder if this could be problematic if additional plugins are added. is it possible to have this done via the plugins?","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d2d37cd8bc6162f1482b88d24377b9afb3472107","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    cp $QUANTUM_DIR/etc/lbaas_agent.ini /$LBAAS_AGENT_CONF_FILENAME"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if [[ $Q_PLUGIN \u003d\u003d \u0027linuxbridge\u0027 || $Q_PLUGIN \u003d\u003d \u0027brocade\u0027 ]]; then"},{"line_number":29,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT interface_driver \"quantum.agent.linux.interface.BridgeInterfaceDriver\""},{"line_number":30,"context_line":"    else"},{"line_number":31,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT interface_driver \"quantum.agent.linux.interface.OVSInterfaceDriver\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F6zQ%3D","line":28,"in_reply_to":"AAAAN3%2F%2F60Q%3D","updated":"2013-03-06 14:28:50.000000000","message":"I\u0027m not sure it\u0027s better to let plugin scripts know about some depending services. I think it\u0027s service responsibility to configure it according to current core plugin","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8176f5983fb7e6a0962d5c34738f83858621f42a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    if is_fedora; then"},{"line_number":35,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT user_group \"nobody\""},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F60s%3D","line":37,"updated":"2013-03-06 14:19:30.000000000","message":"# Restore xtrace\n$MY_XTRACE","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d2d37cd8bc6162f1482b88d24377b9afb3472107","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    if is_fedora; then"},{"line_number":35,"context_line":"        iniset $LBAAS_AGENT_CONF_FILENAME DEFAULT user_group \"nobody\""},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAN3%2F%2F6y8%3D","line":37,"in_reply_to":"AAAAN3%2F%2F60s%3D","updated":"2013-03-06 14:28:50.000000000","message":"Done","commit_id":"4ed338ed1fa99d89a730c6566d7f771123eb1e82"}]}