)]}'
{"id":"openstack%2Fdevstack~236020","triplet_id":"openstack%2Fdevstack~master~Ic8da28a7a182593833823755a5153d1f1f99df36","project":"openstack/devstack","branch":"master","topic":"rm-unused-nova-functions","hashtags":[],"change_id":"Ic8da28a7a182593833823755a5153d1f1f99df36","subject":"Remove a couple of unused nova functions","status":"ABANDONED","created":"2015-10-16 17:23:03.000000000","updated":"2015-11-11 20:50:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"130a40bbfd0128647dec1da00fb9d825c0154e73","_number":236020,"virtual_id_number":236020,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-10-16 18:20:21.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-10-16 18:46:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"date":"2015-10-26 13:24:07.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-18 12:10:12.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":-2,"date":"2015-10-19 14:24:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-16 18:20:21.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-10-16 18:46:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-18 12:10:12.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2015-10-19 14:24:02.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"4a75692bc46fcb5ec23153fa9dbf046c644edfb9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-16 17:23:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b9633841d4b3fdb1d26425917aa0218c562219e8","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-10-16 18:20:21.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/20/236020/1/13885/index.html : SUCCESS in 53 m 42 s","accounts_in_message":[],"_revision_number":1},{"id":"2838e634dd2fbc4f66906edc800730f6288c05a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-16 18:46:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-full/1d4fda7/ : SUCCESS in 51m 10s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-postgres-full/32213df/ : SUCCESS in 39m 54s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-neutron-full/7258952/ : SUCCESS in 1h 15m 22s\n- gate-grenade-dsvm http://logs.openstack.org/20/236020/1/check/gate-grenade-dsvm/e331ea8/ : SUCCESS in 53m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-large-ops/01be9c1/ : SUCCESS in 27m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-neutron-large-ops/513255c/ : SUCCESS in 45m 56s\n- gate-devstack-bashate http://logs.openstack.org/20/236020/1/check/gate-devstack-bashate/6f988f1/ : SUCCESS in 38s\n- gate-devstack-unit-tests http://logs.openstack.org/20/236020/1/check/gate-devstack-unit-tests/1b320ff/ : SUCCESS in 32s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/20/236020/1/check/gate-grenade-dsvm-partial-ncpu/7930247/ : SUCCESS in 1h 08m 53s\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-ironic-agent_ssh/044e77c/ : SUCCESS in 47m 56s\n- gate-devstack-dsvm-updown http://logs.openstack.org/20/236020/1/check/gate-devstack-dsvm-updown/cf99d20/ : SUCCESS in 29m 44s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-f21/e5607b8/ : SUCCESS in 43m 21s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-centos7/0b73a4c/ : SUCCESS in 32m 05s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/20/236020/1/check/gate-devstack-publish-docs/5c6b694//doc/build/html/ : SUCCESS in 1m 34s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/20/236020/1/check/gate-swift-dsvm-functional-nv/45eb90d/ : SUCCESS in 26m 31s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/20/236020/1/check/gate-grenade-dsvm-neutron/c59e94b/ : SUCCESS in 1h 02m 05s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-multinode-full/ae14f49/ : SUCCESS in 49m 42s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/20/236020/1/check/gate-tempest-dsvm-neutron-multinode-full/aed2f97/ : SUCCESS in 1h 00m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4cb3ebbabecf13fd17362bd537ee863eb64579e6","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2015-10-18 12:10:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2c24305becd604de8f91a83aa0f6ea7c3efc80f0","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2015-10-19 14:24:02.000000000","message":"Patch Set 1: Code-Review-2\n\nis_service_enabled \u0027nova\u0027 hits the first of these","accounts_in_message":[],"_revision_number":1},{"id":"04b3821e41b912d9ef3c23aa975681f357af357b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-10-26 13:24:07.000000000","message":"Patch Set 1:\n\nSean, I\u0027m not following, I\u0027m removing is_nova_enabled, `is_service_enabled nova` is using the generic common function defined outside the nova script.","accounts_in_message":[],"_revision_number":1},{"id":"9aadc7f5cb89d97cde7be8cb001dd6650afb446d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-11-11 20:50:35.000000000","message":"Abandoned\n\nUsed here:\n\nhttps://github.com/openstack-dev/devstack/blob/db6cb078aecf90c7b0cb30778903c61770a25861/functions-common#L1929-L1933","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2a88a864c65bc39b0582eef95a48ea30463d7e9e","revisions":{"2a88a864c65bc39b0582eef95a48ea30463d7e9e":{"kind":"REWORK","_number":1,"created":"2015-10-16 17:23:03.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/20/236020/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/20/236020/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/236020/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/236020/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/236020/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/20/236020/1"}}},"commit":{"parents":[{"commit":"0ba18481672964808bbbc4160643387dc931c654","subject":"Merge \"Pin bashate and allow for substitution\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0ba18481672964808bbbc4160643387dc931c654"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-16 17:22:23.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-10-16 17:22:23.000000000","tz":-420},"subject":"Remove a couple of unused nova functions","message":"Remove a couple of unused nova functions\n\nThere are more generic alternatives to these which are being used\ninstead so let\u0027s remove them.\n\nChange-Id: Ic8da28a7a182593833823755a5153d1f1f99df36\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2a88a864c65bc39b0582eef95a48ea30463d7e9e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2a88a864c65bc39b0582eef95a48ea30463d7e9e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}