)]}'
{"id":"openstack%2Fdevstack~23812","triplet_id":"openstack%2Fdevstack~master~I82982a9f1324db878439aa6bbee38bd205f073d0","project":"openstack/devstack","branch":"master","topic":"driver","hashtags":[],"change_id":"I82982a9f1324db878439aa6bbee38bd205f073d0","subject":"Quantum: use generic VIF driver","status":"MERGED","created":"2013-03-07 12:55:42.000000000","updated":"2013-03-12 23:58:34.000000000","submitted":"2013-03-12 23:58:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9061f595c1d66ad81b5074956feeca82aab8bb18","_number":23812,"virtual_id_number":23812,"owner":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":2,"date":"2013-03-12 23:58:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"date":"2013-03-07 14:14:01.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2013-03-08 01:48:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2013-03-12 21:00:27.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-03-10 01:28:38.000000000","_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-03-07 13:05:58.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2013-03-12 21:00:27.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-03-10 01:28:38.000000000","_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-07 14:14:01.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2013-03-08 01:48:57.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2013-03-10 01:28:38.000000000","updated_by":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"reviewer":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"state":"REVIEWER"},{"updated":"2013-03-12 21:00:27.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-03-12 23:58:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7e5f2166b8596958474d71504bcd371846efbb12","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-03-07 13:05:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0c791523e0abb0215948f65a5ba186485f2ee1f4","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-03-07 13:06:06.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"58a8f34b5555337c726c613476ba2ae2d26fad9b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-07 13:43:17.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23812/2/check/gate-tempest-devstack-vm-full/7568 : SUCCESS\n- http://logs.openstack.org/23812/2/check/gate-tempest-devstack-vm-postgres-full/7284 : SUCCESS\n- http://logs.openstack.org/23812/2/check/gate-tempest-devstack-vm-quantum/12665 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"8d8b18d940791f4951897c3758435e7cc977b44a","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-07 14:14:01.000000000","message":"Patch Set 2: (1 inline comment)\n\nTrivial typo in commit message, otherwise fine","accounts_in_message":[],"_revision_number":2},{"id":"f1c33b12ff21854aa5cda3794247504a167d27ba","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-03-08 01:48:57.000000000","message":"Patch Set 2:\n\nI am ok with this patch, but we need to take care of the timing of merging.\n\nI think quantum security group with OVS based plugin does not work with LibvirtGenericVIFDriver yet since LibvirtHybridOVSBridgeDriver is not enabled if NoopFirewallDriver is used. However devstack quantum secgroup support is not merged yet, so this patch does not break anything.\n\ndevstack patch of Quantum Security Group support is under review too. We need to rebase each other since if this patch is merged first we need to set LIBVIRT_VIFDRIVER to make Quantum secgroup work and vice versa this patch needs to make sure quantum secgruop works for OVS based plugin.","accounts_in_message":[],"_revision_number":2},{"id":"9dc5abbfda44c3c23b6e5a40cc8086700e30d8e0","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2013-03-10 01:28:38.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nminor nits from other reviewers aside, this looks good.","accounts_in_message":[],"_revision_number":2},{"id":"6d5d6f5e36412e4e4d886fb2391bb3bb4472edcb","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-12 21:00:27.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a2f5f2f928784ae8c49fdca61d3bacb5bce8fb22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-12 21:00:29.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"38f9e0a9c39cde211476711db04db0a9aecbbcb3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-12 23:58:34.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23812/2/gate/gate-tempest-devstack-vm-full/8503 : SUCCESS\n- http://logs.openstack.org/23812/2/gate/gate-tempest-devstack-vm-postgres-full/8219 : SUCCESS\n- http://logs.openstack.org/23812/2/gate/gate-tempest-devstack-vm-quantum/13734 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"f61d872d8f88e5c7127714139dcaa75298b5def4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-12 23:58:34.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4d8c5b0aca07f0cefa0cf5794f2f0beb2fc5899f","revisions":{"bb2ce926c51ea37b45830d9b12b4720bbbc828f4":{"kind":"REWORK","_number":1,"created":"2013-03-07 12:55:42.000000000","uploader":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"ref":"refs/changes/12/23812/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/12/23812/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/23812/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/23812/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/23812/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/12/23812/1"}}},"commit":{"parents":[{"commit":"fd6aa547f0eb2ab402a214d22039a2ad57e4fc36","subject":"Merge \"Implements blueprint quantum-lbaas-plugin-support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fd6aa547f0eb2ab402a214d22039a2ad57e4fc36"}]}],"author":{"name":"Gary Kotton","email":"gkotton@redhat.com","date":"2013-03-07 12:54:34.000000000","tz":0},"committer":{"name":"Gary Kotton","email":"gkotton@redhat.com","date":"2013-03-07 12:54:34.000000000","tz":0},"subject":"Quantum: user generic VIF driver","message":"Quantum: user generic VIF driver\n\nFor plugins that support VIF bindings, make use of the\nLibvirtGenericVIFDriver libvirt vif driver\n\nChange-Id: I82982a9f1324db878439aa6bbee38bd205f073d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bb2ce926c51ea37b45830d9b12b4720bbbc828f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bb2ce926c51ea37b45830d9b12b4720bbbc828f4"}]},"branch":"refs/heads/master"},"4d8c5b0aca07f0cefa0cf5794f2f0beb2fc5899f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-03-07 13:05:58.000000000","uploader":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"ref":"refs/changes/12/23812/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/12/23812/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/23812/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/23812/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/23812/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/12/23812/2"}}},"commit":{"parents":[{"commit":"fd6aa547f0eb2ab402a214d22039a2ad57e4fc36","subject":"Merge \"Implements blueprint quantum-lbaas-plugin-support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fd6aa547f0eb2ab402a214d22039a2ad57e4fc36"}]}],"author":{"name":"Gary Kotton","email":"gkotton@redhat.com","date":"2013-03-07 12:54:34.000000000","tz":0},"committer":{"name":"Gary Kotton","email":"gkotton@redhat.com","date":"2013-03-07 13:04:56.000000000","tz":0},"subject":"Quantum: use generic VIF driver","message":"Quantum: use generic VIF driver\n\nFor plugins that support VIF bindings, make use of the\nLibvirtGenericVIFDriver libvirt vif driver. The plugin\nreturns the VIF type to Nova which inturn \"knows\" what\nto do.\n\nChange-Id: I82982a9f1324db878439aa6bbee38bd205f073d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4d8c5b0aca07f0cefa0cf5794f2f0beb2fc5899f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4d8c5b0aca07f0cefa0cf5794f2f0beb2fc5899f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}