)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d20c82d538088d40246dc23ba7e388104a024f60","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce IMAGE_PROPERTIES for custom image properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PPC64LE architecture requires different image properties"},{"line_number":10,"context_line":"for third party CI testing. The custom configuration"},{"line_number":11,"context_line":"is usually set on devstack-gate hooks in order"},{"line_number":12,"context_line":"to customize the deployment and tests."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a26ad4f_adfa6373","line":10,"updated":"2015-11-03 00:27:41.000000000","message":"so this is getting to my point ... we already have branching in here for several architectures.  is whatever you\u0027re doing so specific to your third-party CI that anyone else who tried things out on PPC64LE would *not* need these settings?\n\nI understand people trying devstack on PPC64LE is probably a community of just you -- but the alternative seems to be to just add whatever flags you need into the existing code path. \n\nif it\u0027s generic, we should add it to devstack.  if it\u0027s too specific, no point.  This is why adding context helps us make good decisions!","commit_id":"6c9864df95c7f0c25bf8402409614d9485bc13af"},{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"e4ef24ae29c08587edbd17e65ff5b7166ff6fcb3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce IMAGE_PROPERTIES for custom image properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PPC64LE architecture requires different image properties"},{"line_number":10,"context_line":"for third party CI testing. The custom configuration"},{"line_number":11,"context_line":"is usually set on devstack-gate hooks in order"},{"line_number":12,"context_line":"to customize the deployment and tests."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_af32950e","line":10,"in_reply_to":"1a26ad4f_adfa6373","updated":"2015-11-05 11:37:43.000000000","message":"No. You didn\u0027t get the point. This patch is to do the opposite. It is proposing a new localrc parameter to avoid specific code in DevStack. Any Third Party CI or any custom need can take advantage of it.","commit_id":"6c9864df95c7f0c25bf8402409614d9485bc13af"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"b85ace60a36c0fa0ff14a2a9434483a32f456a1e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce IMAGE_PROPERTIES for custom image properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PPC64LE architecture requires different image properties"},{"line_number":10,"context_line":"for third party CI testing. The custom configuration"},{"line_number":11,"context_line":"is usually set on devstack-gate hooks in order"},{"line_number":12,"context_line":"to customize the deployment and tests."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_c216c7a6","line":10,"in_reply_to":"da85f559_5a409ba5","updated":"2015-11-10 12:36:24.000000000","message":"3 ways to handle arch specific needs:\n1) IMAGE_PROPERTIES proposed in this change\n2) local.sh - update image after devstack runs (since you\u0027ll need to find the image ID and update your image properties)\n3) another \"branch\" (if) in the code (easiest path)\n\nI think the idea here with #1 was to make the code more generic and remove all specific cases...\n\nAll above solutions are valid IMHO, but looks like #3 is being used so far.","commit_id":"6c9864df95c7f0c25bf8402409614d9485bc13af"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"469da03173c3c772e64854588b45a936900d794f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce IMAGE_PROPERTIES for custom image properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PPC64LE architecture requires different image properties"},{"line_number":10,"context_line":"for third party CI testing. The custom configuration"},{"line_number":11,"context_line":"is usually set on devstack-gate hooks in order"},{"line_number":12,"context_line":"to customize the deployment and tests."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_5a409ba5","line":10,"in_reply_to":"fa80f949_af32950e","updated":"2015-11-09 23:05:33.000000000","message":"I understand what the code is doing; what I want to understand is why this is the correct way to do it.  Why would you not add a branch for PPC64LE as we do for the other architectures?","commit_id":"6c9864df95c7f0c25bf8402409614d9485bc13af"}],"doc/source/configuration.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6a01946422d8bb970e56f1dee9d6895b7a3c8bc8","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        IMAGE_URLS+\u003d\"http://foo.bar.com/image2.qcow\""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Guest Image Properties"},{"line_number":418,"context_line":"-----------------------"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"Image properties can be overwritten by setting ``IMAGE_PROPERTIES`` parameter."},{"line_number":421,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_1b16514c","line":418,"updated":"2015-11-02 06:14:59.000000000","message":"this should be a subsection, and it doesn\u0027t quite line up, which i think will make the parser unhappy","commit_id":"cf04958889b4ab6d8ad90d924e4f887d2b090c9a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6a01946422d8bb970e56f1dee9d6895b7a3c8bc8","unresolved":false,"context_lines":[{"line_number":418,"context_line":"-----------------------"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"Image properties can be overwritten by setting ``IMAGE_PROPERTIES`` parameter."},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    ::"},{"line_number":423,"context_line":"        IMAGE_PROPERTIES\u003d\"--property hw_scsi_model\u003dvirtio-scsi --property hw_disk_bus\u003dscsi\""},{"line_number":424,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_5b1e0960","line":421,"updated":"2015-11-02 06:14:59.000000000","message":"can you expand this a bit","commit_id":"cf04958889b4ab6d8ad90d924e4f887d2b090c9a"}],"functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"964fb055c63f6fceaf20f3cb727b92e517f2d1a4","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    fi"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    if [[ ! -z \"$IMAGE_PROPERTIES\" ]]; then"},{"line_number":313,"context_line":"        img_property\u003d$IMAGE_PROPERTIES"},{"line_number":314,"context_line":"    fi"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    if [ \"$container_format\" \u003d \"bare\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a26ad4f_1b265615","line":313,"updated":"2015-11-01 22:54:39.000000000","message":"overriding img_property seems wrong.  it seems like what is really needed is a new variable substituted into the command, or a +\u003d at least\n\nunless the idea *is* to override these, in that case, yeah, documentation and an explanation of why that is the right thing to do would clear things up","commit_id":"ecceaacfbeeae3241512e847b4c8da92809c65d7"}]}