)]}'
{"lib/ironic":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"90334b306a61145623f9a529e020dfc4fdc48d4a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":97,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":98,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":99,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":102,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_41f753d3","line":99,"updated":"2015-10-28 23:21:10.000000000","message":"this could really do with some documentation about what it\u0027s doing...","commit_id":"ba205e3c905a0f9fe29c5b9b6ce88b2a74918a85"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f9fa3752384faaa050abccade6b8748ac2d710a4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":97,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":98,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":99,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":102,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_4f869566","line":99,"in_reply_to":"1a26ad4f_41f753d3","updated":"2015-10-29 05:37:26.000000000","message":"Done","commit_id":"ba205e3c905a0f9fe29c5b9b6ce88b2a74918a85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"90334b306a61145623f9a529e020dfc4fdc48d4a","unresolved":false,"context_lines":[{"line_number":745,"context_line":"    elif [[ \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"fedora\" || \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"ubuntu\" ]]; then"},{"line_number":746,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":747,"context_line":"    else"},{"line_number":748,"context_line":"        echo \"IRONIC_IPA_RAMDISK_DISTRO\u003d$IRONIC_IPA_RAMDISK_DISTRO is not supported.\""},{"line_number":749,"context_line":"    fi"},{"line_number":750,"context_line":"}"},{"line_number":751,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_01bcfb03","line":748,"updated":"2015-10-28 23:21:10.000000000","message":"should \"die\" here","commit_id":"ba205e3c905a0f9fe29c5b9b6ce88b2a74918a85"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f9fa3752384faaa050abccade6b8748ac2d710a4","unresolved":false,"context_lines":[{"line_number":745,"context_line":"    elif [[ \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"fedora\" || \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"ubuntu\" ]]; then"},{"line_number":746,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":747,"context_line":"    else"},{"line_number":748,"context_line":"        echo \"IRONIC_IPA_RAMDISK_DISTRO\u003d$IRONIC_IPA_RAMDISK_DISTRO is not supported.\""},{"line_number":749,"context_line":"    fi"},{"line_number":750,"context_line":"}"},{"line_number":751,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_ef7c4174","line":748,"in_reply_to":"1a26ad4f_01bcfb03","updated":"2015-10-29 05:37:26.000000000","message":"Done","commit_id":"ba205e3c905a0f9fe29c5b9b6ce88b2a74918a85"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"90334b306a61145623f9a529e020dfc4fdc48d4a","unresolved":false,"context_lines":[{"line_number":766,"context_line":"    local kernel_path\u003d$1"},{"line_number":767,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":768,"context_line":"    local distro\u003d$3"},{"line_number":769,"context_line":"    local tempfile\u003d$(mktemp)"},{"line_number":770,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":771,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":772,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_610fefe1","line":769,"updated":"2015-10-28 23:21:10.000000000","message":"this might get big?  I wonder if we should use --tmpdir to set this somewhere like $DEST?","commit_id":"ba205e3c905a0f9fe29c5b9b6ce88b2a74918a85"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f9fa3752384faaa050abccade6b8748ac2d710a4","unresolved":false,"context_lines":[{"line_number":766,"context_line":"    local kernel_path\u003d$1"},{"line_number":767,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":768,"context_line":"    local distro\u003d$3"},{"line_number":769,"context_line":"    local tempfile\u003d$(mktemp)"},{"line_number":770,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":771,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":772,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_afde496b","line":769,"in_reply_to":"1a26ad4f_610fefe1","updated":"2015-10-29 05:37:26.000000000","message":"Done","commit_id":"ba205e3c905a0f9fe29c5b9b6ce88b2a74918a85"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3a1a30d7799ea40c56c176c5262d70fc2b97944c","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":769,"context_line":"    local distro\u003d$3"},{"line_number":770,"context_line":"    local tempfile"},{"line_number":771,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa80f949_0821974d","line":771,"updated":"2015-11-04 02:10:07.000000000","message":"This don\u0027t need to be divided into above line.\n\nlocal tempfile\u003d$(mktemp --tmpdir\u003d$DEST)","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4556852d3ade3ed9a594992f2d454bbc8cec0323","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":769,"context_line":"    local distro\u003d$3"},{"line_number":770,"context_line":"    local tempfile"},{"line_number":771,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa80f949_c3b93030","line":771,"in_reply_to":"fa80f949_0821974d","updated":"2015-11-04 02:20:07.000000000","message":"Please ignore.","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2bc28fe29c21e524d68485ee53d90bdc8121a233","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":769,"context_line":"    local distro\u003d$3"},{"line_number":770,"context_line":"    local tempfile"},{"line_number":771,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa80f949_d84b5e2a","line":771,"in_reply_to":"fa80f949_c3b93030","updated":"2015-11-04 03:59:10.000000000","message":"Yeah, it was done for bashate.  This E042 was recently introduced.","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6b26a8dcff2d56ee36578547bfffd505b74cd138","unresolved":false,"context_lines":[{"line_number":770,"context_line":"    local tempfile"},{"line_number":771,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":775,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":776,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa80f949_b873fa4c","line":773,"updated":"2015-11-04 04:32:56.000000000","message":"I really don\u0027t know ironic so this is just a question.\n\nI have thought that we create deploy-image by ramdisk-image-create and user-image by disk-image-create but this uses disk-image-create. Should we create user image here?","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"92539dc7ad416ff9abcc60f11c4e690833ccb089","unresolved":false,"context_lines":[{"line_number":770,"context_line":"    local tempfile"},{"line_number":771,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":775,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":776,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa80f949_d86d9e33","line":773,"in_reply_to":"fa80f949_b873fa4c","updated":"2015-11-04 04:38:06.000000000","message":"We create deploy ramdisk image, but the method of creating ramdisk using ramdisk-image-create is deprecated.  ramdisk-image-create used to pull the init scripts from other elements and create a custom ramdisk with the init scripts.  \n\nFor the newer ramdisk (ironic-python-agent), we start the ironic-python-agent as a systemd service.  It keeps running and listens on a particular port for commands from ironic.  Therefore we use disk-image-create, pull an actual cloud image, install the ironic-python-agent as a systemd service and remove all the unwanted stuffs from it, and then bundle it into a cpio gz ramdisk.\n\nReference:\n\nhttp://docs.openstack.org/developer/ironic/deploy/install-guide.html#buildingdibbaseddeployramdisk\nhttps://github.com/openstack/diskimage-builder/tree/master/elements/ironic-agent","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e7cd3c78916fb8862ee600ed03f0ecb0de7fd111","unresolved":false,"context_lines":[{"line_number":770,"context_line":"    local tempfile"},{"line_number":771,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":775,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":776,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa80f949_18b6c68a","line":773,"in_reply_to":"fa80f949_d86d9e33","updated":"2015-11-04 04:44:55.000000000","message":"It makes sense. Thank you :)","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"451af2ac7a7d0bc321364bf7c446b688de8a59f5","unresolved":false,"context_lines":[{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":775,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":776,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":777,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":778,"context_line":"    rm -f \"$tempfile\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da85f559_5aa7844f","line":775,"updated":"2015-11-07 04:30:17.000000000","message":"Dont we need to pass \u0027disable-selinux\u0027 here?","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"77563b693bebaace6750573fe14298099b3d8657","unresolved":false,"context_lines":[{"line_number":772,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":773,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":774,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":775,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":776,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":777,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":778,"context_line":"    rm -f \"$tempfile\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da85f559_2d8351ce","line":775,"in_reply_to":"da85f559_5aa7844f","updated":"2015-11-09 06:20:55.000000000","message":"Even though the first commit (https://review.openstack.org/#/c/103105/) which added the element said we need disable-selinux, I don\u0027t think we need it now.  \n\n* It works without disable-selinux\n* Installation guide also doesn\u0027t say we need disable-selinux.\n\nhttp://docs.openstack.org/developer/ironic/deploy/install-guide.html#buildingdibbaseddeployramdisk","commit_id":"49d7658aeb5826f68efce8657d60db7fe571cd2a"}]}