)]}'
{"lib/ironic":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f4fe7bf65ac1130df9a6cb38589b9b1eb8b6b67e","unresolved":false,"context_lines":[{"line_number":822,"context_line":"    #  iso_required \u003d 1, if iso is not required"},{"line_number":823,"context_line":"    #  iso_exists \u003d 0, if iso exists"},{"line_number":824,"context_line":"    #  iso_exists \u003d 1, if iso doesn\u0027t exist"},{"line_number":825,"context_line":"    iso_required\u003d$(is_deploy_iso_required; echo $?)"},{"line_number":826,"context_line":"    iso_exists\u003d$(test -e $IRONIC_DEPLOY_ISO_PATH; echo $?)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    if [ ! -e \"$IRONIC_DEPLOY_RAMDISK_PATH\" -o \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a26ad4f_01e5db35","line":825,"updated":"2015-10-28 23:11:19.000000000","message":"the idea of the \"is_*\" functions is to be used directly inline (so you don\u0027t need this sort of comment :) \n \ne.g.\n\nif is_deploy_iso_required ; then\n  ...\nfi\n\nso i see you did that below, why not here?","commit_id":"ffc352a6d8dcb87cdba0551b9aa72348b48aa440"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1fa5eea549b6b2bed1b52266bc00fc25d32840f5","unresolved":false,"context_lines":[{"line_number":822,"context_line":"    #  iso_required \u003d 1, if iso is not required"},{"line_number":823,"context_line":"    #  iso_exists \u003d 0, if iso exists"},{"line_number":824,"context_line":"    #  iso_exists \u003d 1, if iso doesn\u0027t exist"},{"line_number":825,"context_line":"    iso_required\u003d$(is_deploy_iso_required; echo $?)"},{"line_number":826,"context_line":"    iso_exists\u003d$(test -e $IRONIC_DEPLOY_ISO_PATH; echo $?)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    if [ ! -e \"$IRONIC_DEPLOY_RAMDISK_PATH\" -o \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a26ad4f_afa409a6","line":825,"in_reply_to":"1a26ad4f_01e5db35","updated":"2015-10-29 05:51:28.000000000","message":"Done","commit_id":"ffc352a6d8dcb87cdba0551b9aa72348b48aa440"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"28bceea5b2bb650fe4cb5eb3c1cd5eaed0f7ad5e","unresolved":false,"context_lines":[{"line_number":794,"context_line":"    fi"},{"line_number":795,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":796,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":797,"context_line":"                    $image_create_args"},{"line_number":798,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":799,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":800,"context_line":"    mv \"${tempfile}.iso\" \"$iso_path\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da85f559_ba3a30e6","line":797,"updated":"2015-11-07 04:42:11.000000000","message":"Need to add disable-selinux as argument","commit_id":"6b2899ab93278e3092861dfcbfa7ba2a6cfca0bc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3d199237b152e0620319f7802bb66ec509ec1f7a","unresolved":false,"context_lines":[{"line_number":794,"context_line":"    fi"},{"line_number":795,"context_line":"    disk-image-create -a amd64 \\"},{"line_number":796,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":797,"context_line":"                    $image_create_args"},{"line_number":798,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":799,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":800,"context_line":"    mv \"${tempfile}.iso\" \"$iso_path\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da85f559_4d5fb572","line":797,"in_reply_to":"da85f559_ba3a30e6","updated":"2015-11-09 06:21:25.000000000","message":"Even though the first commit (https://review.openstack.org/#/c/103105/) which added the element said we need disable-selinux, I don\u0027t think we need it now.  \n\n* It works without disable-selinux\n* Installation guide also doesn\u0027t say we need disable-selinux.\n\nhttp://docs.openstack.org/developer/ironic/deploy/install-guide.html#buildingdibbaseddeployramdisk","commit_id":"6b2899ab93278e3092861dfcbfa7ba2a6cfca0bc"}]}