)]}'
{"lib/zookeeper":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ee859da06fba366f82becf3520e3a93348988c3d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # Starting twice Zookeeper on Ubuntu exits with error code 1. See LP#1513741"},{"line_number":73,"context_line":"    # Match both systemd and sysvinit output"},{"line_number":74,"context_line":"    local running\u003d\"(active \\(running\\)|start/running)\""},{"line_number":75,"context_line":"    if ! is_ubuntu || ! sudo /usr/sbin/service zookeeper status | egrep -q \"$running\"; then"},{"line_number":76,"context_line":"        start_service zookeeper"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_e4fae474","line":75,"updated":"2015-11-10 18:20:12.000000000","message":"Shouldn\u0027t this be if is_ubuntu? As a non devstack core I would sovle this more generally in start_service. If service is running then noop regardless of platform.","commit_id":"04e73e17e8c536abb1ea86e7b0d037aef543da37"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"25e53894ab1e77aefc36a4fccd41ef592851197f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # Starting twice Zookeeper on Ubuntu exits with error code 1. See LP#1513741"},{"line_number":73,"context_line":"    # Match both systemd and sysvinit output"},{"line_number":74,"context_line":"    local running\u003d\"(active \\(running\\)|start/running)\""},{"line_number":75,"context_line":"    if ! is_ubuntu || ! sudo /usr/sbin/service zookeeper status | egrep -q \"$running\"; then"},{"line_number":76,"context_line":"        start_service zookeeper"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_cabfa7a8","line":75,"in_reply_to":"da85f559_0454c850","updated":"2015-11-10 19:07:38.000000000","message":"I don\u0027t want to start an endless loop - originally it was like this, but Sean asked for it to be put here.\n\nI agreee with Clark that this seems like a global thing.  my research indicates any service that you try to start that is already started on Ubuntu will return this.  I think we happen to hit this with zookeeper because it is enabled after install.\n\nsince starting an already running service does nothing with systemd, i think having start_service just equalise the platforms is the right thing","commit_id":"04e73e17e8c536abb1ea86e7b0d037aef543da37"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"591601fcb4e03a78186fe49f316d98086dfc10b2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # Starting twice Zookeeper on Ubuntu exits with error code 1. See LP#1513741"},{"line_number":73,"context_line":"    # Match both systemd and sysvinit output"},{"line_number":74,"context_line":"    local running\u003d\"(active \\(running\\)|start/running)\""},{"line_number":75,"context_line":"    if ! is_ubuntu || ! sudo /usr/sbin/service zookeeper status | egrep -q \"$running\"; then"},{"line_number":76,"context_line":"        start_service zookeeper"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_b57f28aa","line":75,"in_reply_to":"da85f559_cabfa7a8","updated":"2015-11-10 19:35:27.000000000","message":"What services in debian land are not enabled after install?  All checkins and gate jobs are broken for those of us dependent on zookeeper since the addition of zookeeper to devstack, can we get closure on this soon?","commit_id":"04e73e17e8c536abb1ea86e7b0d037aef543da37"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8570cf0f10bfb65607a1196822f9864bdd7c89d5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # Starting twice Zookeeper on Ubuntu exits with error code 1. See LP#1513741"},{"line_number":73,"context_line":"    # Match both systemd and sysvinit output"},{"line_number":74,"context_line":"    local running\u003d\"(active \\(running\\)|start/running)\""},{"line_number":75,"context_line":"    if ! is_ubuntu || ! sudo /usr/sbin/service zookeeper status | egrep -q \"$running\"; then"},{"line_number":76,"context_line":"        start_service zookeeper"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_ea606b03","line":75,"in_reply_to":"da85f559_cabfa7a8","updated":"2015-11-10 19:15:34.000000000","message":"ok, my concern is that would impact a lot more code and status is notorious for being kind of garbage on some services. Which is part of the systemd win, that we\u0027ll get on Ubuntu in the next LTS and be able to dump all these work arounds.","commit_id":"04e73e17e8c536abb1ea86e7b0d037aef543da37"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6c993d6a26fb83139601fedd7acd77fdad2dcb0f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # Starting twice Zookeeper on Ubuntu exits with error code 1. See LP#1513741"},{"line_number":73,"context_line":"    # Match both systemd and sysvinit output"},{"line_number":74,"context_line":"    local running\u003d\"(active \\(running\\)|start/running)\""},{"line_number":75,"context_line":"    if ! is_ubuntu || ! sudo /usr/sbin/service zookeeper status | egrep -q \"$running\"; then"},{"line_number":76,"context_line":"        start_service zookeeper"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_0454c850","line":75,"in_reply_to":"da85f559_e4fae474","updated":"2015-11-10 18:22:31.000000000","message":"Neverind I read the || as an \u0026\u0026 for some reason. But anyways I think a proper fix would be in start_service, but check with devstack cores.","commit_id":"04e73e17e8c536abb1ea86e7b0d037aef543da37"}]}