)]}'
{"lib/neutron-legacy":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a7fc7780b4b141e3f28b0d384f8b93cee16d962b","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        fi"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        if [[ $af \u003d\u003d \"inet6\" ]]; then"},{"line_number":812,"context_line":"            IP_BRD\u003d$(ip -f $af a s dev $from_intf | grep \u0027scope global\u0027 | sed \u0027/temporary/d\u0027 | awk \u0027{ print $2, $3, $4; exit }\u0027)"},{"line_number":813,"context_line":"        fi"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if [[ \"$DEFAULT_ROUTE_V4_GW\" !\u003d \"\" \u0026\u0026 $af \u003d\u003d \"inet\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da85f559_fbdd9fe0","line":812,"updated":"2015-11-10 20:15:39.000000000","message":"You can pass \u0027scope global\u0027 to /sbin/ip and it will filter, although you\u0027ll still need to grep for \u0027inet\u0027.\n\nActually, the \u0027temporary\u0027 is printed when the \u0027secondary\u0027 flag is set (it\u0027s overloaded for IPv6), so I think this would do it all:\n\n$(ip -f $af a s dev $from_intf scope global primary | grep inet | awk \u0027\n{ print $2, $3, $4; exit }\u0027)\n\nThen you can even take away the $af \u003d\u003d inet/inet6 checks too since the code winds-up being the same.\n\nMaybe I should just update this and save you the headache of understanding all that I just said :)","commit_id":"f7b0aaaff8a428a11dd8e7c0d656ff56a537a664"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"1a47fae3e08bd34971eb8a3f71f5005d3808d40e","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        fi"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        if [[ $af \u003d\u003d \"inet6\" ]]; then"},{"line_number":812,"context_line":"            IP_BRD\u003d$(ip -f $af a s dev $from_intf | grep \u0027scope global\u0027 | sed \u0027/temporary/d\u0027 | awk \u0027{ print $2, $3, $4; exit }\u0027)"},{"line_number":813,"context_line":"        fi"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if [[ \"$DEFAULT_ROUTE_V4_GW\" !\u003d \"\" \u0026\u0026 $af \u003d\u003d \"inet\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da85f559_16c4fa8e","line":812,"in_reply_to":"da85f559_fbdd9fe0","updated":"2015-11-10 20:24:48.000000000","message":"Sounds good to me. I\u0027m actually kind of proud that I followed everything you said.","commit_id":"f7b0aaaff8a428a11dd8e7c0d656ff56a537a664"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4cf9e9ac4e13d274ddbcbae4421fe504b6c8b857","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        if [[ $af \u003d\u003d \"inet6\" ]]; then"},{"line_number":810,"context_line":"            IP_BRD\u003d$(ip -f $af a s dev $from_intf | grep \u0027scope global\u0027 | sed \u0027/temporary/d\u0027 | awk \u0027{ print $2, $3, $4; exit }\u0027)"},{"line_number":811,"context_line":"        fi"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        if [ \"$DEFAULT_ROUTE_GW\" !\u003d \"\" ]; then"},{"line_number":814,"context_line":"            ADD_DEFAULT_ROUTE\u003d\"sudo ip -f $af r replace default via $DEFAULT_ROUTE_GW dev $to_intf\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_5ea82220","line":811,"updated":"2015-11-11 20:28:08.000000000","message":"Can\u0027t you delete L805 to here and just use a single:\n\nIP_BRD\u003d$(ip -f $af a s dev $from_intf scope global primary | grep inet | awk \u0027{ print $2, $3, $4; exit }\u0027)\n\nI\u0027m seeing if it works at the moment...","commit_id":"9af81997b543f7634c180b73a036c59456118b50"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a86f769fb35a6c5c266aa1be0666d4de57e77953","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        if [[ $af \u003d\u003d \"inet6\" ]]; then"},{"line_number":810,"context_line":"            IP_BRD\u003d$(ip -f $af a s dev $from_intf | grep \u0027scope global\u0027 | sed \u0027/temporary/d\u0027 | awk \u0027{ print $2, $3, $4; exit }\u0027)"},{"line_number":811,"context_line":"        fi"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        if [ \"$DEFAULT_ROUTE_GW\" !\u003d \"\" ]; then"},{"line_number":814,"context_line":"            ADD_DEFAULT_ROUTE\u003d\"sudo ip -f $af r replace default via $DEFAULT_ROUTE_GW dev $to_intf\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba8a016a_9377f701","line":811,"in_reply_to":"da85f559_427600d8","updated":"2015-11-16 22:10:17.000000000","message":"I\u0027m fine with this, I\u0027ll submit a follow-on to optimize the code path and make it common between the two.\n\nI also filed https://bugs.launchpad.net/devstack/+bug/1516801 for the OVS issue I saw, which I\u0027ll fix in another patch.","commit_id":"9af81997b543f7634c180b73a036c59456118b50"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2b3dfb6dddccbbb1aad99b9d60167e0fc1335f5","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        if [[ $af \u003d\u003d \"inet6\" ]]; then"},{"line_number":810,"context_line":"            IP_BRD\u003d$(ip -f $af a s dev $from_intf | grep \u0027scope global\u0027 | sed \u0027/temporary/d\u0027 | awk \u0027{ print $2, $3, $4; exit }\u0027)"},{"line_number":811,"context_line":"        fi"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        if [ \"$DEFAULT_ROUTE_GW\" !\u003d \"\" ]; then"},{"line_number":814,"context_line":"            ADD_DEFAULT_ROUTE\u003d\"sudo ip -f $af r replace default via $DEFAULT_ROUTE_GW dev $to_intf\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_427600d8","line":811,"in_reply_to":"da85f559_5ea82220","updated":"2015-11-11 22:31:51.000000000","message":"Yeah, this simplification seems to work on my system, it moved my primary IPv4 and IPv6 addresses from eth0 to br-eth0.\n\nThe only problem I saw was on unstack that even though the addresses moved back to eth0, they were unusable.  Unloading the openvswitch kernel module fixed it, so perhaps there is a missing ovs-vsctl del-port call?  Don\u0027t even know if it\u0027s related to this change.","commit_id":"9af81997b543f7634c180b73a036c59456118b50"}]}