)]}'
{"lib/nova":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"652ed1bfead58e6f5d37a850896cae9c03215479","unresolved":false,"context_lines":[{"line_number":583,"context_line":"    # The group **libvirtd** is added to the current user in this script."},{"line_number":584,"context_line":"    # Use \u0027sg\u0027 to execute nova-compute as a member of the **libvirtd** group."},{"line_number":585,"context_line":"    # ``screen_it`` checks ``is_service_enabled``, it is not needed here"},{"line_number":586,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":587,"context_line":"        screen_it n-cond \"cd $NOVA_DIR \u0026\u0026 $NOVA_BIN_DIR/nova-conductor --config-file $NOVA_CONF\""},{"line_number":588,"context_line":"        screen_it n-cond \"cd $NOVA_DIR \u0026\u0026 $NOVA_BIN_DIR/nova-conductor --config-file $NOVA_CELLS_CONF\""},{"line_number":589,"context_line":"        screen_it n-cpu \"cd $NOVA_DIR \u0026\u0026 sg libvirtd \\\"$NOVA_BIN_DIR/nova-compute --config-file $NOVA_CELLS_CONF\\\"\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2FtzY%3D","line":586,"updated":"2013-03-15 11:53:25.000000000","message":"so it feels like there are a set of services which can be extraced out of the if block because --config-file $NOVA_CONF is the default.","commit_id":"f6040d6d58993fff804ed254f3495d818fd3c38a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"652ed1bfead58e6f5d37a850896cae9c03215479","unresolved":false,"context_lines":[{"line_number":616,"context_line":"# stop_nova() - Stop running processes (non-screen)"},{"line_number":617,"context_line":"function stop_nova() {"},{"line_number":618,"context_line":"    # Kill the nova screen windows"},{"line_number":619,"context_line":"    for serv in n-api n-cpu n-crt n-net n-sch n-novnc n-xvnc n-cauth n-cond n-spice n-cell n-api-meta; do"},{"line_number":620,"context_line":"        screen -S $SCREEN_NAME -p $serv -X kill"},{"line_number":621,"context_line":"    done"},{"line_number":622,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2FtzU%3D","line":619,"updated":"2013-03-15 11:53:25.000000000","message":"do we need to do this conditionally?","commit_id":"f6040d6d58993fff804ed254f3495d818fd3c38a"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e1a164cdcae55c71893e2ae6bc3c204cb2bf4ae1","unresolved":false,"context_lines":[{"line_number":616,"context_line":"# stop_nova() - Stop running processes (non-screen)"},{"line_number":617,"context_line":"function stop_nova() {"},{"line_number":618,"context_line":"    # Kill the nova screen windows"},{"line_number":619,"context_line":"    for serv in n-api n-cpu n-crt n-net n-sch n-novnc n-xvnc n-cauth n-cond n-spice n-cell n-api-meta; do"},{"line_number":620,"context_line":"        screen -S $SCREEN_NAME -p $serv -X kill"},{"line_number":621,"context_line":"    done"},{"line_number":622,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2Ftmg%3D","line":619,"in_reply_to":"AAAAN3%2F%2FtzU%3D","updated":"2013-03-15 15:38:48.000000000","message":"I\u0027m not sure it\u0027s any different than any other service, none of them are guaranteed to have been enabled.","commit_id":"f6040d6d58993fff804ed254f3495d818fd3c38a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"716217cf727c2d4ab42546b7b42777541ac6620d","unresolved":false,"context_lines":[{"line_number":616,"context_line":"# stop_nova() - Stop running processes (non-screen)"},{"line_number":617,"context_line":"function stop_nova() {"},{"line_number":618,"context_line":"    # Kill the nova screen windows"},{"line_number":619,"context_line":"    for serv in n-api n-cpu n-crt n-net n-sch n-novnc n-xvnc n-cauth n-cond n-spice n-cell n-api-meta; do"},{"line_number":620,"context_line":"        screen -S $SCREEN_NAME -p $serv -X kill"},{"line_number":621,"context_line":"    done"},{"line_number":622,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2Fteo%3D","line":619,"in_reply_to":"AAAAN3%2F%2FtzU%3D","updated":"2013-03-15 16:45:28.000000000","message":"Its harmless and we want them all dead anyway.  This will be called from unstack.sh or clean.sh and unfortunately localrc may have changed.","commit_id":"f6040d6d58993fff804ed254f3495d818fd3c38a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b31bc26630295b3b79abbf7e4e1121534a09d774","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        screen_it n-cell \"cd $NOVA_DIR \u0026\u0026 $NOVA_BIN_DIR/nova-cells --config-file $NOVA_CONF\""},{"line_number":682,"context_line":"        screen_it n-cell \"cd $NOVA_DIR \u0026\u0026 $NOVA_BIN_DIR/nova-cells --config-file $NOVA_CELLS_CONF\""},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        nova-manage --config-file $NOVA_CELLS_CONF cell create --name\u003dregion --cell_type\u003dparent --username\u003dguest --hostname\u003d$RABBIT_HOST --port\u003d5672 --password\u003d$RABBIT_PASSWORD --virtual_host\u003d/ --woffset\u003d0 --wscale\u003d1"},{"line_number":685,"context_line":"        nova-manage cell create --name\u003dchild --cell_type\u003dchild --username\u003dguest --hostname\u003d$RABBIT_HOST --port\u003d5672 --password\u003d$RABBIT_PASSWORD --virtual_host\u003dchild_cell --woffset\u003d0 --wscale\u003d1"},{"line_number":686,"context_line":"    fi"},{"line_number":687,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOX%2F%2F9Rs%3D","line":684,"updated":"2013-04-04 16:14:25.000000000","message":"Having nova-manage calls inside start_nova() makes me nervous.  start_nova() needs to be able to be called more than once, say after stop_nova() has been called.  IIRC, nova-manage doesn\u0027t generally require any services to be running, it directly operates on the database.","commit_id":"f17ddbf83d2db4de33c1df911c15e26ab07a45c2"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"eea5e272c078b82238e158978a17fe220022f613","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        screen_it n-cell \"cd $NOVA_DIR \u0026\u0026 $NOVA_BIN_DIR/nova-cells --config-file $NOVA_CONF\""},{"line_number":682,"context_line":"        screen_it n-cell \"cd $NOVA_DIR \u0026\u0026 $NOVA_BIN_DIR/nova-cells --config-file $NOVA_CELLS_CONF\""},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        nova-manage --config-file $NOVA_CELLS_CONF cell create --name\u003dregion --cell_type\u003dparent --username\u003dguest --hostname\u003d$RABBIT_HOST --port\u003d5672 --password\u003d$RABBIT_PASSWORD --virtual_host\u003d/ --woffset\u003d0 --wscale\u003d1"},{"line_number":685,"context_line":"        nova-manage cell create --name\u003dchild --cell_type\u003dchild --username\u003dguest --hostname\u003d$RABBIT_HOST --port\u003d5672 --password\u003d$RABBIT_PASSWORD --virtual_host\u003dchild_cell --woffset\u003d0 --wscale\u003d1"},{"line_number":686,"context_line":"    fi"},{"line_number":687,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOX%2F%2F8T0%3D","line":684,"in_reply_to":"AAAAOX%2F%2F9Rs%3D","updated":"2013-04-04 23:53:11.000000000","message":"Good point. I\u0027ve moved it to below the db sync call in init_nova_cells().","commit_id":"f17ddbf83d2db4de33c1df911c15e26ab07a45c2"}]}