)]}'
{"id":"openstack%2Fdevstack~244311","triplet_id":"openstack%2Fdevstack~master~If4795bf70e0c19b423d6e6922ba90c8953d04026","project":"openstack/devstack","branch":"master","topic":"use-is-n-cell-enabled","hashtags":[],"change_id":"If4795bf70e0c19b423d6e6922ba90c8953d04026","subject":"Replace `is_service_enabled n-cell` with `is_n-cell_enabled`","status":"ABANDONED","created":"2015-11-11 21:04:10.000000000","updated":"2015-11-12 18:22:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5a931dd63ccc5121fe12a814679a0e1ab856991b","_number":244311,"virtual_id_number":244311,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-11-11 22:07:31.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2015-11-11 22:39:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-11-11 21:04:22.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":-1,"date":"2015-11-12 05:02:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-11 22:07:31.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-11-11 22:39:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-11-12 05:02:51.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"07ebb3af73e266b0939ac3e1c608de60fc3a1223","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-11-11 21:04:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"885486c36f8d48f148bb77e14a0fa4329e7e2c18","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-11-11 21:04:22.000000000","message":"Patch Set 1:\n\ncheck experimental","accounts_in_message":[],"_revision_number":1},{"id":"2a558d8fc6084cde1637d6fa0b1626e2dad4cb04","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-11-11 22:07:31.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/11/244311/1/15592/index.html : SUCCESS in 01 h 00 m 22 s","accounts_in_message":[],"_revision_number":1},{"id":"8ccf37717820124d7b765830e7fd392715bcf95d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-11 22:39:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-full/80ed789/ : SUCCESS in 39m 21s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-postgres-full/e4d237f/ : SUCCESS in 40m 25s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-neutron-full/1523926/ : SUCCESS in 1h 06m 21s\n- gate-grenade-dsvm http://logs.openstack.org/11/244311/1/check/gate-grenade-dsvm/c629e8e/ : SUCCESS in 45m 47s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-large-ops/ca2df89/ : SUCCESS in 28m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-neutron-large-ops/6633952/ : SUCCESS in 27m 36s\n- gate-devstack-bashate http://logs.openstack.org/11/244311/1/check/gate-devstack-bashate/d830830/ : SUCCESS in 38s\n- gate-devstack-unit-tests http://logs.openstack.org/11/244311/1/check/gate-devstack-unit-tests/88bb748/ : SUCCESS in 38s\n- gate-grenade-dsvm-partial-ncpu http://logs.openstack.org/11/244311/1/check/gate-grenade-dsvm-partial-ncpu/b0de765/ : SUCCESS in 42m 08s\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-ironic-agent_ssh/5894864/ : SUCCESS in 44m 02s\n- gate-devstack-dsvm-updown http://logs.openstack.org/11/244311/1/check/gate-devstack-dsvm-updown/f197521/ : SUCCESS in 25m 46s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-f21/6b5c258/ : FAILURE in 53m 43s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-centos7/aa380b9/ : SUCCESS in 37m 47s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full/732773f/ : SUCCESS in 1h 02m 41s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/11/244311/1/check/gate-devstack-publish-docs/87c090c//doc/build/html/ : SUCCESS in 2m 39s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/11/244311/1/check/gate-swift-dsvm-functional-nv/04138b7/ : SUCCESS in 40m 35s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/11/244311/1/check/gate-grenade-dsvm-neutron/950ac6e/ : SUCCESS in 58m 12s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-multinode-full/dbaa515/ : SUCCESS in 1h 22m 33s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/11/244311/1/check/gate-tempest-dsvm-neutron-multinode-full/5638d40/ : SUCCESS in 1h 06m 34s (non-voting)\n- gate-grenade-dsvm-multinode-nv http://logs.openstack.org/11/244311/1/check/gate-grenade-dsvm-multinode-nv/0aedb37/ : SUCCESS in 48m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c6200ea6924a1b4382a5ca625690c17efab39159","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-11 23:13:42.000000000","message":"Patch Set 1:\n\nBuild failed (experimental pipeline).\n\n- experimental-tempest-dsvm-full-dibtest http://logs.openstack.org/11/244311/1/experimental/experimental-tempest-dsvm-full-dibtest/298e60f/ : FAILURE in 45m 36s\n- experimental-tempest-dsvm-multinode-full-dibtest http://logs.openstack.org/11/244311/1/experimental/experimental-tempest-dsvm-multinode-full-dibtest/78193fc/ : FAILURE in 1h 02m 23s\n- gate-grenade-dsvm-neutron http://logs.openstack.org/11/244311/1/experimental/gate-grenade-dsvm-neutron/a2e75d4/ : SUCCESS in 1h 00m 00s\n- gate-ironic-dsvm-functional http://logs.openstack.org/11/244311/1/experimental/gate-ironic-dsvm-functional/1f96110/ : SUCCESS in 46m 36s\n- gate-neutron-dsvm-functional http://logs.openstack.org/11/244311/1/experimental/gate-neutron-dsvm-functional/19a2bcb/ : SUCCESS in 20m 06s\n- gate-tempest-dsvm-neutron-dvr-multinode-full http://logs.openstack.org/11/244311/1/experimental/gate-tempest-dsvm-neutron-dvr-multinode-full/4c6dd24/ : SUCCESS in 1h 23m 56s (non-voting)\n- gate-tempest-dsvm-cells http://logs.openstack.org/11/244311/1/experimental/gate-tempest-dsvm-cells/9e1df27/ : FAILURE in 1h 44m 53s\n- gate-tempest-dsvm-mongodb-zaqar http://logs.openstack.org/11/244311/1/experimental/gate-tempest-dsvm-mongodb-zaqar/b0b4ac1/ : SUCCESS in 18m 10s\n- gate-tempest-dsvm-f22 http://logs.openstack.org/11/244311/1/experimental/gate-tempest-dsvm-f22/cf7eff2/ : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"47c94437c9355c21611f58d73581414724015fc8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-11-12 05:02:51.000000000","message":"Patch Set 1: Code-Review-1\n\nI think that \n  \n  run_process n-cell-region \"$NOVA_BIN_DIR/nova-cells --config-file $api_cell_conf\"\n\nwill be sending ${service} as \"n-cell-region\" -- there is no \"is_n-cell-region_enabled\" function, so it falls through to that check underneath.\n\ni.e. i don\u0027t think it\u0027s right to remove that\n\nI think the comment might be a bit wrong","accounts_in_message":[],"_revision_number":1},{"id":"734a779f4da10e5c1838b35adfbc0b3e70cc97f2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-11-12 18:22:49.000000000","message":"Abandoned\n\nOK, yeah, the cells job failed hard so I don\u0027t really want to waste time on this.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"90bcf4d464ebcf033ecdf2ab039468c3b1ccca0b","revisions":{"90bcf4d464ebcf033ecdf2ab039468c3b1ccca0b":{"kind":"REWORK","_number":1,"created":"2015-11-11 21:04:10.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/11/244311/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/11/244311/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/11/244311/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/11/244311/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/11/244311/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/11/244311/1"}}},"commit":{"parents":[{"commit":"4622fd682eced182b0b47c64e5ca3779b780ea24","subject":"Merge \"fail if devstack attempts to be run under virtualenv\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4622fd682eced182b0b47c64e5ca3779b780ea24"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-11-11 21:02:59.000000000","tz":-480},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-11-11 21:02:59.000000000","tz":-480},"subject":"Replace `is_service_enabled n-cell` with `is_n-cell_enabled`","message":"Replace `is_service_enabled n-cell` with `is_n-cell_enabled`\n\nPart of the TODO to move the is_service_enabled checks into the\nlib scripts.\n\nChange-Id: If4795bf70e0c19b423d6e6922ba90c8953d04026\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/90bcf4d464ebcf033ecdf2ab039468c3b1ccca0b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/90bcf4d464ebcf033ecdf2ab039468c3b1ccca0b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}