)]}'
{"extras.d/50-ironic.sh":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54ed5ba7a05990efba6b605e7a87252fe25d2fbc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        init_ironic"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if [[ -n \"${IRONIC_PROVISION_NETWORK_NAME}\" ]]; then"},{"line_number":25,"context_line":"            configure_ironic_provision_network"},{"line_number":26,"context_line":"        fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # Start the ironic API and ironic taskmgr components"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7a740942_6727deb6","line":25,"updated":"2015-12-07 08:17:32.000000000","message":"Perhaps would be good to add an:\n\n echo_summary \"Configuring Ironic provisioning network\"\n\nabove.","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"60736d46ad6dcca638199dc479d3cac6e691ed7a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        init_ironic"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        if [[ -n \"${IRONIC_PROVISION_NETWORK_NAME}\" ]]; then"},{"line_number":25,"context_line":"            configure_ironic_provision_network"},{"line_number":26,"context_line":"        fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # Start the ironic API and ironic taskmgr components"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7a740942_4e32f611","line":25,"in_reply_to":"7a740942_6727deb6","updated":"2015-12-07 13:01:32.000000000","message":"Done","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"}],"lib/ironic":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dbac20c6187efbc7fc1c88f00fbf7216c0bf25ef","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    fi"},{"line_number":297,"context_line":"}"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"function configure_provision_network {"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_PREFIX \"You must specify the IRONIC_PROVISION_SUBNET_PREFIX\""},{"line_number":302,"context_line":"    die_if_not_set $LINENO PHYSICAL_NETWORK \"You must specify the PHYSICAL_NETWORK\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a8ffd7b_7a950485","line":299,"updated":"2015-11-27 03:29:23.000000000","message":"please add an \"_ironic_\" in here to namespace it better","commit_id":"9898aeab3462950a06f9efab523d97803076a6af"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dbac20c6187efbc7fc1c88f00fbf7216c0bf25ef","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    net_id\u003d$(neutron net-create --provider:network_type $IRONIC_PROVISION_PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" ${IRONIC_PROVISION_SEGMENTATION_ID:+--provider:segmentation_id $IRONIC_PROVISION_SEGMENTATION_ID} ${IRONIC_PROVISION_NETWORK_NAME} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":309,"context_line":"    subnet_id\u003d$(neutron subnet-create --ip_version 4 ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":312,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a8ffd7b_9af0e8fe","line":309,"updated":"2015-11-27 03:29:23.000000000","message":"make this a local","commit_id":"9898aeab3462950a06f9efab523d97803076a6af"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"dbac20c6187efbc7fc1c88f00fbf7216c0bf25ef","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT provisioning_network_uuid $net_id"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    local segmentation_id\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":316,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    # Set provision network GW on physycal interface"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a8ffd7b_9a79c884","line":315,"updated":"2015-11-27 03:29:23.000000000","message":"please move this out of the \"local\" definition so we catch errors if it doesn\u0027t work","commit_id":"9898aeab3462950a06f9efab523d97803076a6af"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"052f1a1cb44c6c8d62c4abbb55edbfd483896f30","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    local net_id"},{"line_number":306,"context_line":"    net_id\u003d$(neutron net-create --provider:network_type $IRONIC_PROVISION_PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" ${IRONIC_PROVISION_SEGMENTATION_ID:+--provider:segmentation_id $IRONIC_PROVISION_SEGMENTATION_ID} ${IRONIC_PROVISION_NETWORK_NAME} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":309,"context_line":"    local subnet_id\u003d\"$(neutron subnet-create --ip_version 4 ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)\""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a8ffd7b_7002c5b5","line":308,"updated":"2015-11-30 04:31:44.000000000","message":"since you have pipefail enabled here, and we should be running under \"set -e\", I don\u0027t see that you can actually hit this?","commit_id":"a54cf3cb7ff9f96e4d7a40159e4c6e744fe19e0c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54ed5ba7a05990efba6b605e7a87252fe25d2fbc","unresolved":false,"context_lines":[{"line_number":151,"context_line":"# to ironic port-create command. LLC info is obtained from"},{"line_number":152,"context_line":"# IRONIC_{VM,HW}_NODES_FILE"},{"line_number":153,"context_line":"IRONIC_LLC_ENABLED\u003d$(trueorfalse False IRONIC_LLC_ENABLED)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"IRONIC_PROVISION_NETWORK_NAME\u003d${IRONIC_PROVISION_NETWORK_NAME:-}"},{"line_number":156,"context_line":"IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d${IRONIC_PROVISION_PROVIDER_NETWORK_TYPE:-\u0027vlan\u0027}"},{"line_number":157,"context_line":"IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7a740942_a74ce670","line":154,"updated":"2015-12-07 08:17:32.000000000","message":"Please add some comments to all of the below variables indicating their proper use.","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"60736d46ad6dcca638199dc479d3cac6e691ed7a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"# to ironic port-create command. LLC info is obtained from"},{"line_number":152,"context_line":"# IRONIC_{VM,HW}_NODES_FILE"},{"line_number":153,"context_line":"IRONIC_LLC_ENABLED\u003d$(trueorfalse False IRONIC_LLC_ENABLED)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"IRONIC_PROVISION_NETWORK_NAME\u003d${IRONIC_PROVISION_NETWORK_NAME:-}"},{"line_number":156,"context_line":"IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d${IRONIC_PROVISION_PROVIDER_NETWORK_TYPE:-\u0027vlan\u0027}"},{"line_number":157,"context_line":"IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7a740942_a19da867","line":154,"in_reply_to":"7a740942_a74ce670","updated":"2015-12-07 13:01:32.000000000","message":"Added short comments. I\u0027ve added detailed explanation to the docs in next commit.","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54ed5ba7a05990efba6b605e7a87252fe25d2fbc","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_GATEWAY \"You must specify the IRONIC_PROVISION_SUBNET_GATEWAY\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    local net_id"},{"line_number":306,"context_line":"    net_id\u003d$(neutron net-create --provider:network_type $IRONIC_PROVISION_PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" ${IRONIC_PROVISION_SEGMENTATION_ID:+--provider:segmentation_id $IRONIC_PROVISION_SEGMENTATION_ID} ${IRONIC_PROVISION_NETWORK_NAME} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":309,"context_line":"    local subnet_id\u003d\"$(neutron subnet-create --ip_version 4 ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)\""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7a740942_47ce62b5","line":306,"updated":"2015-12-07 08:17:32.000000000","message":"Might be nice to break the above and below long neutron CLI commands onto multiple lines using \\","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"60736d46ad6dcca638199dc479d3cac6e691ed7a","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_GATEWAY \"You must specify the IRONIC_PROVISION_SUBNET_GATEWAY\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    local net_id"},{"line_number":306,"context_line":"    net_id\u003d$(neutron net-create --provider:network_type $IRONIC_PROVISION_PROVIDER_NETWORK_TYPE --provider:physical_network \"$PHYSICAL_NETWORK\" ${IRONIC_PROVISION_SEGMENTATION_ID:+--provider:segmentation_id $IRONIC_PROVISION_SEGMENTATION_ID} ${IRONIC_PROVISION_NETWORK_NAME} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":309,"context_line":"    local subnet_id\u003d\"$(neutron subnet-create --ip_version 4 ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)\""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7a740942_8963f8db","line":306,"in_reply_to":"7a740942_47ce62b5","updated":"2015-12-07 13:01:32.000000000","message":"Done","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"54ed5ba7a05990efba6b605e7a87252fe25d2fbc","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":316,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    # Set provision network GW on physycal interface"},{"line_number":319,"context_line":"    # Add vlan on br interface in case of IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d\u003dvlan"},{"line_number":320,"context_line":"    # othervise assign ip to br interface directly."},{"line_number":321,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7a740942_67383ea1","line":318,"updated":"2015-12-07 08:17:32.000000000","message":"s/physycal/physical/","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"60736d46ad6dcca638199dc479d3cac6e691ed7a","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":316,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    # Set provision network GW on physycal interface"},{"line_number":319,"context_line":"    # Add vlan on br interface in case of IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d\u003dvlan"},{"line_number":320,"context_line":"    # othervise assign ip to br interface directly."},{"line_number":321,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7a740942_c96900c0","line":318,"in_reply_to":"7a740942_67383ea1","updated":"2015-12-07 13:01:32.000000000","message":"Done","commit_id":"0f64c93ca6697bdef376696f8e6c59e1ef19e036"}]}