)]}'
{"id":"openstack%2Fdevstack~250634","triplet_id":"openstack%2Fdevstack~master~Ieb7b0cdbeb162495d222b84b01888827412b9393","project":"openstack/devstack","branch":"master","topic":"with_open","hashtags":[],"change_id":"Ieb7b0cdbeb162495d222b84b01888827412b9393","subject":"Trivial: Optimize the open method with context manager","status":"ABANDONED","created":"2015-11-27 07:02:22.000000000","updated":"2015-11-27 09:40:13.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"05aa765240a1d68570669ff35ebb845186048a0b","_number":250634,"virtual_id_number":250634,"owner":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-11-27 07:59:11.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"date":"2015-11-27 09:39:42.000000000","_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":1,"date":"2015-11-27 08:36:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-11-27 07:41:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-27 07:41:06.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2015-11-27 07:59:11.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-11-27 08:36:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5cad81b471539d5c2d43bfe8f9be3e4f8836f3f7","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-27 07:02:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"39dda60e6b103fcdd33bb263f33c74da48a2bbbb","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2015-11-27 07:41:06.000000000","message":"Patch Set 1: Code-Review-1\n\nYou moved more code inside to the loop and you name the change as trivial optimization ?\n\nMore code inside a loop is trivially more expensive!\nopening + closing at every iteration is trivially more expensive.","accounts_in_message":[],"_revision_number":1},{"id":"9c227acdda952a0f745379ad618928f60c66c030","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2015-11-27 07:59:11.000000000","message":"Patch Set 1:\n\nTesting completed on Citrix Xenserver. For rechecking only on the Citrix Xenserver CI,add a review comment with \"xenserver: recheck\". Contact info: openstack@citrix.com.\nFor debugging suggestions, see https://wiki.openstack.org/wiki/Debugging_XenServer_CI_failures\n\n- check-citrix-xenserver http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/34/250634/1/17250/index.html : SUCCESS in 54 m 08 s","accounts_in_message":[],"_revision_number":1},{"id":"33cf18376c71d6620ca5bf069f61d8ae3cb67bb8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-27 08:36:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-full http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-full/2efe570/ : SUCCESS in 57m 14s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-postgres-full/3eaed6b/ : SUCCESS in 50m 27s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-neutron-full/8913a3a/ : SUCCESS in 55m 12s\n- gate-grenade-dsvm http://logs.openstack.org/34/250634/1/check/gate-grenade-dsvm/852c6e5/ : SUCCESS in 51m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-large-ops/6ce6be8/ : SUCCESS in 39m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-neutron-large-ops/b6604ad/ : SUCCESS in 27m 53s\n- gate-devstack-bashate http://logs.openstack.org/34/250634/1/check/gate-devstack-bashate/088e2e1/ : SUCCESS in 24s\n- gate-devstack-unit-tests http://logs.openstack.org/34/250634/1/check/gate-devstack-unit-tests/ebc4d23/ : SUCCESS in 45s\n- gate-tempest-dsvm-ironic-agent_ssh http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-ironic-agent_ssh/24daf35/ : SUCCESS in 46m 17s\n- gate-devstack-dsvm-updown http://logs.openstack.org/34/250634/1/check/gate-devstack-dsvm-updown/0106161/ : SUCCESS in 26m 55s\n- gate-tempest-dsvm-f21 http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-f21/1683f59/ : FAILURE in 6m 22s (non-voting)\n- gate-tempest-dsvm-centos7 http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-centos7/8d849bc/ : SUCCESS in 36m 39s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full/55c8162/ : SUCCESS in 1h 07m 51s (non-voting)\n- gate-devstack-publish-docs http://docs-draft.openstack.org/34/250634/1/check/gate-devstack-publish-docs/a5fbb44//doc/build/html/ : SUCCESS in 1m 51s\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/34/250634/1/check/gate-swift-dsvm-functional-nv/1789f4c/ : SUCCESS in 36m 47s (non-voting)\n- gate-grenade-dsvm-neutron http://logs.openstack.org/34/250634/1/check/gate-grenade-dsvm-neutron/df0e825/ : SUCCESS in 40m 36s\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-multinode-full/1a45f81/ : FAILURE in 51m 50s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/34/250634/1/check/gate-tempest-dsvm-neutron-multinode-full/385cb25/ : SUCCESS in 1h 18m 43s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/34/250634/1/check/gate-grenade-dsvm-multinode/086b9bd/ : SUCCESS in 45m 24s","accounts_in_message":[],"_revision_number":1},{"id":"d0f66b9c30bffb2c50dc1e40901c667b128218ce","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-27 09:39:42.000000000","message":"Patch Set 1:\n\nyeah, I missed the \"while\". Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"021e9c8dbdcf78b5d6d7b54366c8e5da00491d48","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2015-11-27 09:40:13.000000000","message":"Abandoned\n\nbad idea for this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e7ee2c93636157a098393771101446be9f4ae132","revisions":{"e7ee2c93636157a098393771101446be9f4ae132":{"kind":"REWORK","_number":1,"created":"2015-11-27 07:02:22.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/34/250634/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/34/250634/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/34/250634/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/34/250634/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/34/250634/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/34/250634/1"}}},"commit":{"parents":[{"commit":"e9326ee6384b0429270f90d66e20a54e982aecc3","subject":"Merge \"Add create stack user to quickstart document\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e9326ee6384b0429270f90d66e20a54e982aecc3"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-11-27 06:56:09.000000000","tz":-300},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2015-11-27 06:56:15.000000000","tz":-300},"subject":"Trivial: Optimize the open method with context manager","message":"Trivial: Optimize the open method with context manager\n\nUse opening context manager to open a file.\n\nChange-Id: Ieb7b0cdbeb162495d222b84b01888827412b9393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e7ee2c93636157a098393771101446be9f4ae132"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e7ee2c93636157a098393771101446be9f4ae132"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}