)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"1673fdbb1d110cf4f675d7f9bec5c379f343cc6a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check for network id before create probe for neutron\u0027s network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some cases, like when using provider network or when we are"},{"line_number":10,"context_line":"not using q-l3, where we don\u0027t create public or private network, thus we"},{"line_number":11,"context_line":"need to check if such network\u0027s id exist before to create its probes,"},{"line_number":12,"context_line":"otherwise devstack terminates prematurely."},{"line_number":13,"context_line":"Also add such probes for physical network."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba0121b8_4f180a85","line":10,"updated":"2016-03-29 11:54:49.000000000","message":"So, why are you not setting NEUTRON_CREATE_INITIAL_NETWORKS to False?\n\nhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/stack.sh#n1246\n\nThe point is, if you are not creating the public or private network, disable that functionality.\n\nAre you using these probes? My suggestion would be to set it in your local.sh if you are doing something vastly different, or a devstack plugin in your own repo.","commit_id":"9f02f4d7dd3d99a46133f09bd715b668bc793be9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"425393f6c08515cc55c78cb54e5aabab4d9e3668","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check for network id before create probe for neutron\u0027s network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some cases, like when using provider network or when we are"},{"line_number":10,"context_line":"not using q-l3, where we don\u0027t create public or private network, thus we"},{"line_number":11,"context_line":"need to check if such network\u0027s id exist before to create its probes,"},{"line_number":12,"context_line":"otherwise devstack terminates prematurely."},{"line_number":13,"context_line":"Also add such probes for physical network."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba0121b8_ea7e2cad","line":10,"in_reply_to":"ba0121b8_4f180a85","updated":"2016-03-29 12:10:20.000000000","message":"NEUTRON_CREATE_INITIAL_NETWORKS default value is True. And only private network is created by default. I think it is a bug that we do probes to public network when it is not enabled.","commit_id":"9f02f4d7dd3d99a46133f09bd715b668bc793be9"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f9b56c1de258583ef7df2cb9687a467b23421e27","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check for network id before create probe for neutron\u0027s network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are some cases, like when using provider network or when we are"},{"line_number":10,"context_line":"not using q-l3, where we don\u0027t create public or private network, thus we"},{"line_number":11,"context_line":"need to check if such network\u0027s id exist before to create its probes,"},{"line_number":12,"context_line":"otherwise devstack terminates prematurely."},{"line_number":13,"context_line":"Also add such probes for physical network."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba0121b8_09c28b85","line":10,"in_reply_to":"ba0121b8_ea7e2cad","updated":"2016-03-29 13:11:57.000000000","message":"\u003e And only private network is created by default\n\nThis is not accurate. By default, the L3 service is set up and enabled, which also has a side effect of creating a public network.\n\nIf you are creating a provider network, why aren\u0027t you using the variables we have for doing that in DevStack?\n\n\n\u003eNEUTRON_CREATE_INITIAL_NETWORKS default value is True\n\nThis is correct. So what I am suggesting is - for your specific need, you may want to either set this variable to false, or consult our documentation about creating a provider network.\n\nWe also have a hook neutron_plugin_create_initial_network_profile that is available.","commit_id":"9f02f4d7dd3d99a46133f09bd715b668bc793be9"}],"lib/neutron-legacy":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c0fbaf005fe43b15c50c1a0842647f6f3793aa87","unresolved":false,"context_lines":[{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"function delete_probe {"},{"line_number":1424,"context_line":"    local from_net\u003d\"$1\""},{"line_number":1425,"context_line":"    net_id\u003d`_get_net_id $from_net`"},{"line_number":1426,"context_line":"    if [-n net_id ]; then"},{"line_number":1427,"context_line":"        probe_id\u003d`neutron-debug --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD probe-list -c id -c network_id | grep $net_id | awk \u0027{print $2}\u0027`"},{"line_number":1428,"context_line":"        neutron-debug --os-tenant-name admin --os-username admin probe-delete $probe_id"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da0c15f0_84ecccc8","line":1425,"range":{"start_line":1425,"start_character":4,"end_line":1425,"end_character":10},"updated":"2016-03-25 12:23:15.000000000","message":"net_id should be defined as local variable.","commit_id":"62ffcc4f48ac31ffdc6c003600af4e7a760f15c2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"10be8eddb65d03dfef185404b833663a210b08f0","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"function delete_probe {"},{"line_number":1424,"context_line":"    local from_net\u003d\"$1\""},{"line_number":1425,"context_line":"    net_id\u003d`_get_net_id $from_net`"},{"line_number":1426,"context_line":"    if [-n net_id ]; then"},{"line_number":1427,"context_line":"        probe_id\u003d`neutron-debug --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD probe-list -c id -c network_id | grep $net_id | awk \u0027{print $2}\u0027`"},{"line_number":1428,"context_line":"        neutron-debug --os-tenant-name admin --os-username admin probe-delete $probe_id"},{"line_number":1429,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a5ae5dd_92baa6bf","line":1426,"updated":"2016-02-09 12:20:57.000000000","message":"mooaaarrrr $$$$","commit_id":"62ffcc4f48ac31ffdc6c003600af4e7a760f15c2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c0fbaf005fe43b15c50c1a0842647f6f3793aa87","unresolved":false,"context_lines":[{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":"function create_probe {"},{"line_number":1434,"context_line":"    local from_net\u003d\"$1\""},{"line_number":1435,"context_line":"    net_id\u003d`_get_net_id $from_net`"},{"line_number":1436,"context_line":"    if [ -n \"$public_net_id\" ]; then"},{"line_number":1437,"context_line":"        neutron-debug --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD probe-create --device-owner compute $net_id"},{"line_number":1438,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da0c15f0_e4d148fd","line":1435,"range":{"start_line":1435,"start_character":4,"end_line":1435,"end_character":10},"updated":"2016-03-25 12:23:15.000000000","message":"Ditto it should be local.","commit_id":"62ffcc4f48ac31ffdc6c003600af4e7a760f15c2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c0fbaf005fe43b15c50c1a0842647f6f3793aa87","unresolved":false,"context_lines":[{"line_number":1433,"context_line":"function create_probe {"},{"line_number":1434,"context_line":"    local from_net\u003d\"$1\""},{"line_number":1435,"context_line":"    net_id\u003d`_get_net_id $from_net`"},{"line_number":1436,"context_line":"    if [ -n \"$public_net_id\" ]; then"},{"line_number":1437,"context_line":"        neutron-debug --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD probe-create --device-owner compute $net_id"},{"line_number":1438,"context_line":"    fi"},{"line_number":1439,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da0c15f0_648ff823","line":1436,"range":{"start_line":1436,"start_character":14,"end_line":1436,"end_character":27},"updated":"2016-03-25 12:23:15.000000000","message":"here should be $net_id","commit_id":"62ffcc4f48ac31ffdc6c003600af4e7a760f15c2"}]}