)]}'
{"lib/cinder_backends/lvm":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1fb01b889a06a24cec35465491b052cb929b3310","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        iniset $CINDER_CONF $be_name volume_clear none"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage {VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a8ffd7b_57d94082","line":60,"updated":"2015-12-01 22:22:20.000000000","message":"Currently, is_service_enabled tempest is returning 0.  Hrm...","commit_id":"4ac40b4adb8da2b7814c9a84c0239fce679e4713"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93afa903057bd0bac8d0eeee572a975eb821526b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        iniset $CINDER_CONF $be_name volume_clear none"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage {VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a8ffd7b_a6960eee","line":60,"in_reply_to":"9a8ffd7b_57d94082","updated":"2015-12-02 17:00:27.000000000","message":"What do mean ?","commit_id":"4ac40b4adb8da2b7814c9a84c0239fce679e4713"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"723d09eed5fd8d2fea15bc10314af4869aa5af47","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        iniset $CINDER_CONF $be_name volume_clear none"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage {VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a8ffd7b_10ab8b76","line":60,"in_reply_to":"9a8ffd7b_7dcd1084","updated":"2015-12-02 17:38:12.000000000","message":"It returns 0 because Tempest is enabled. It\u0027s shell script man :)","commit_id":"4ac40b4adb8da2b7814c9a84c0239fce679e4713"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"35fd4dc5dfd63886f2307d6a896932b739b18fad","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        iniset $CINDER_CONF $be_name volume_clear none"},{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage {VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a8ffd7b_7dcd1084","line":60,"in_reply_to":"9a8ffd7b_a6960eee","updated":"2015-12-02 17:21:22.000000000","message":"This call returns 0 in the run, not sure why:\n\nhttp://logs.openstack.org/56/252056/1/check/gate-tempest-dsvm-full/3aa4e50/logs/devstacklog.txt.gz#_2015-12-01_21_05_19_987","commit_id":"4ac40b4adb8da2b7814c9a84c0239fce679e4713"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93afa903057bd0bac8d0eeee572a975eb821526b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage {VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a8ffd7b_06f7da59","line":61,"updated":"2015-12-02 17:00:27.000000000","message":"You\u0027re missing a $ here","commit_id":"4ac40b4adb8da2b7814c9a84c0239fce679e4713"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"35fd4dc5dfd63886f2307d6a896932b739b18fad","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage {VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a8ffd7b_1dc64468","line":61,"in_reply_to":"9a8ffd7b_06f7da59","updated":"2015-12-02 17:21:22.000000000","message":"Done","commit_id":"4ac40b4adb8da2b7814c9a84c0239fce679e4713"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"101c3ad667f1aedddbffbe3e363467892603a428","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage ${VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_bddf3d39","line":61,"updated":"2015-12-10 15:52:09.000000000","message":"Why not just have this unconditionally export VOLUME_MANAGE_AVAILABLE as True? You already added this line to lib/tempest so if you set VOLUME_MANAGE_AVAILABLE that should be enough to trigger it in lib/tempest.\n\nI also think it\u0027s a little weird for the lvm driver to write to the tempest config file.","commit_id":"96ad798f29118e120e5a85174a5ec68581230b8c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c05925ce072a538fb1b1e1471bf7297535be6177","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    fi"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if is_service_enabled tempest; then"},{"line_number":61,"context_line":"        iniset $TEMPEST_CONFIG volume-feature-enabled manage ${VOLUME_MANAGE_AVAILABLE:-True}"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_bdb89d76","line":61,"in_reply_to":"7a740942_bddf3d39","updated":"2015-12-10 15:59:02.000000000","message":"Matthew is right here. Because you don\"t set VOLUME_MANAGE_AVAILABLE to true here, then \"volume-feature-enabled manage\" will be set to False because of https://review.openstack.org/#/c/223188","commit_id":"96ad798f29118e120e5a85174a5ec68581230b8c"}]}