)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"657206af98e83020413a1672b97f707fb2c3e8cf","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (XenServer) ]]; then"},{"line_number":412,"context_line":"        DISTRO\u003d\"xs$os_RELEASE\""},{"line_number":413,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (KVMforIBMzSystems) ]]; then"},{"line_number":414,"context_line":"        DISTRO\u003d\"kvmibm${os_RELEASE%.*}\""},{"line_number":415,"context_line":"    else"},{"line_number":416,"context_line":"        # Catch-all for now is Vendor + Release + Update"},{"line_number":417,"context_line":"        DISTRO\u003d\"$os_VENDOR-$os_RELEASE.$os_UPDATE\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_93c3f788","line":414,"updated":"2015-12-08 04:44:24.000000000","message":"in the other check you do kvmibm1.1\n\nI think DISTRO should be setting the value as \"high\" as possible (e.g. ignoring point releases) for maximum compatibility; i.e. this feels like it should just be kvmibm${os_RELEASE::1} or whatever to get the major version  \n\nif something in the code is so specific that it can only happen on a point release, we can match on sub-parts of $os_RELEASE there","commit_id":"0300c3e18f4e134542a4517e30d71d9a25edf0ce"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"6f5ec5d6d12441e5e072ecb299981837e11962af","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (XenServer) ]]; then"},{"line_number":412,"context_line":"        DISTRO\u003d\"xs$os_RELEASE\""},{"line_number":413,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (KVMforIBMzSystems) ]]; then"},{"line_number":414,"context_line":"        DISTRO\u003d\"kvmibm${os_RELEASE%.*}\""},{"line_number":415,"context_line":"    else"},{"line_number":416,"context_line":"        # Catch-all for now is Vendor + Release + Update"},{"line_number":417,"context_line":"        DISTRO\u003d\"$os_VENDOR-$os_RELEASE.$os_UPDATE\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_9541063c","line":414,"in_reply_to":"7a740942_93c3f788","updated":"2015-12-10 15:39:19.000000000","message":"Done","commit_id":"0300c3e18f4e134542a4517e30d71d9a25edf0ce"}],"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"657206af98e83020413a1672b97f707fb2c3e8cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        #pip_install_gr \u003cthere-si-no-guestfs-in-pypi\u003e"},{"line_number":40,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":41,"context_line":"        # On \"KVM for IBM z Systems\", kvm does not have its own package"},{"line_number":42,"context_line":"        if [[ ! ${DISTRO} \u003d~ \"kvmibm1.1\" ]]; then"},{"line_number":43,"context_line":"            install_package kvm"},{"line_number":44,"context_line":"        fi"},{"line_number":45,"context_line":"        # there is a dependency issue with kvm (which is really just a"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_13894775","line":42,"updated":"2015-12-08 04:44:24.000000000","message":"is this really only in the 1.1 release?  see other comment","commit_id":"0300c3e18f4e134542a4517e30d71d9a25edf0ce"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"6f5ec5d6d12441e5e072ecb299981837e11962af","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        #pip_install_gr \u003cthere-si-no-guestfs-in-pypi\u003e"},{"line_number":40,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":41,"context_line":"        # On \"KVM for IBM z Systems\", kvm does not have its own package"},{"line_number":42,"context_line":"        if [[ ! ${DISTRO} \u003d~ \"kvmibm1.1\" ]]; then"},{"line_number":43,"context_line":"            install_package kvm"},{"line_number":44,"context_line":"        fi"},{"line_number":45,"context_line":"        # there is a dependency issue with kvm (which is really just a"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_554b9e59","line":42,"in_reply_to":"7a740942_13894775","updated":"2015-12-10 15:39:19.000000000","message":"Done","commit_id":"0300c3e18f4e134542a4517e30d71d9a25edf0ce"}],"stack.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"657206af98e83020413a1672b97f707fb2c3e8cf","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"# Warn users who aren\u0027t on an explicitly supported distro, but allow them to"},{"line_number":194,"context_line":"# override check and attempt installation with ``FORCE\u003dyes ./stack``"},{"line_number":195,"context_line":"if [[ ! ${DISTRO} \u003d~ (trusty|vivid|wily|7.0|wheezy|sid|testing|jessie|f21|f22|f23|rhel7|kvmibm1) ]]; then"},{"line_number":196,"context_line":"    echo \"WARNING: this script has not been tested on $DISTRO\""},{"line_number":197,"context_line":"    if [[ \"$FORCE\" !\u003d \"yes\" ]]; then"},{"line_number":198,"context_line":"        die $LINENO \"If you wish to run this script anyway run with FORCE\u003dyes\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a740942_335323e4","line":195,"updated":"2015-12-08 04:44:24.000000000","message":"We don\u0027t really have strict rules around this ... but I\u0027d at least like to know what CI is running to somewhat justify us saying we support it","commit_id":"0300c3e18f4e134542a4517e30d71d9a25edf0ce"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"6f5ec5d6d12441e5e072ecb299981837e11962af","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"# Warn users who aren\u0027t on an explicitly supported distro, but allow them to"},{"line_number":194,"context_line":"# override check and attempt installation with ``FORCE\u003dyes ./stack``"},{"line_number":195,"context_line":"if [[ ! ${DISTRO} \u003d~ (trusty|vivid|wily|7.0|wheezy|sid|testing|jessie|f21|f22|f23|rhel7|kvmibm1) ]]; then"},{"line_number":196,"context_line":"    echo \"WARNING: this script has not been tested on $DISTRO\""},{"line_number":197,"context_line":"    if [[ \"$FORCE\" !\u003d \"yes\" ]]; then"},{"line_number":198,"context_line":"        die $LINENO \"If you wish to run this script anyway run with FORCE\u003dyes\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a740942_75fedaaf","line":195,"in_reply_to":"7a740942_335323e4","updated":"2015-12-10 15:39:19.000000000","message":"We are currently building a CI for nova on libvirt/kvm on s390x, but it is not reporting results yet. The test results are good but we are still working on the infrastructure. Let me know if this is good enough to include kvmibm here.","commit_id":"0300c3e18f4e134542a4517e30d71d9a25edf0ce"}]}