)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e017917de2b629ffc8a761d63f506eb37d14c833","unresolved":false,"context_lines":[{"line_number":11,"context_line":"replace the static example configuration files."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Once the generation code is delivered, the static config files"},{"line_number":14,"context_line":"will be removed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Icef8f7e8f0e8e78bfffa7a5af3f9f2300376b115"},{"line_number":17,"context_line":"Related-blueprint: autogen-neutron-conf-file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_cc414b0d","line":14,"updated":"2015-12-04 15:37:34.000000000","message":"Not quite. The neutron-vpnaas repo uses a plugin now for setup via devstack. The code here is just for legacy purposes. So, although it is OK to change this, we must change the plugin, before removing static config files.","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"c347b287d3784320ddbcf4803db86f48194c0123","unresolved":false,"context_lines":[{"line_number":11,"context_line":"replace the static example configuration files."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Once the generation code is delivered, the static config files"},{"line_number":14,"context_line":"will be removed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Icef8f7e8f0e8e78bfffa7a5af3f9f2300376b115"},{"line_number":17,"context_line":"Related-blueprint: autogen-neutron-conf-file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_0ca9457b","line":14,"in_reply_to":"7a740942_cc414b0d","updated":"2015-12-07 16:13:13.000000000","message":"Sure, thanks for informing me on IRC. I have added the necessary changes to the VPNaaS patch.","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"}],"lib/neutron-legacy":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a88b609b2af6471bae099a9ac954b88a1010af47","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"}"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"function _configure_neutron_vpn {"},{"line_number":1080,"context_line":"    # Uses oslo config generator to generate LBaaS sample configuration files"},{"line_number":1081,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":1082,"context_line":"    if [ -f $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample ]; then"},{"line_number":1083,"context_line":"        cp $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample $NEUTRON_CONF_DIR/neutron-vpnaas.conf"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a740942_baa575a2","line":1080,"updated":"2015-12-14 14:24:12.000000000","message":"VPNaaS","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"03d5bb2069faad8c82ff5da8b90151fe57f946ab","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"}"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"function _configure_neutron_vpn {"},{"line_number":1080,"context_line":"    # Uses oslo config generator to generate LBaaS sample configuration files"},{"line_number":1081,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":1082,"context_line":"    if [ -f $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample ]; then"},{"line_number":1083,"context_line":"        cp $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample $NEUTRON_CONF_DIR/neutron-vpnaas.conf"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a740942_3d017f05","line":1080,"in_reply_to":"7a740942_baa575a2","updated":"2015-12-14 14:35:56.000000000","message":"Done.","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a88b609b2af6471bae099a9ac954b88a1010af47","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"    # Uses oslo config generator to generate LBaaS sample configuration files"},{"line_number":1081,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":1082,"context_line":"    if [ -f $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample ]; then"},{"line_number":1083,"context_line":"        cp $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample $NEUTRON_CONF_DIR/neutron-vpnaas.conf"},{"line_number":1084,"context_line":"    fi"},{"line_number":1085,"context_line":"    neutron_vpn_install_agent_packages"},{"line_number":1086,"context_line":"    neutron_vpn_configure_common"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a740942_fae45de0","line":1083,"updated":"2015-12-14 14:24:12.000000000","message":"Note you change the filename (replacing underscore with dash). Is it intended?","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"03d5bb2069faad8c82ff5da8b90151fe57f946ab","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"    # Uses oslo config generator to generate LBaaS sample configuration files"},{"line_number":1081,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":1082,"context_line":"    if [ -f $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample ]; then"},{"line_number":1083,"context_line":"        cp $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample $NEUTRON_CONF_DIR/neutron-vpnaas.conf"},{"line_number":1084,"context_line":"    fi"},{"line_number":1085,"context_line":"    neutron_vpn_install_agent_packages"},{"line_number":1086,"context_line":"    neutron_vpn_configure_common"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a740942_9d167347","line":1083,"in_reply_to":"7a740942_fae45de0","updated":"2015-12-14 14:35:56.000000000","message":"It is not, thanks. Updated.","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"}],"lib/neutron_plugins/services/vpn":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a88b609b2af6471bae099a9ac954b88a1010af47","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function neutron_vpn_configure_agent {"},{"line_number":32,"context_line":"    # Uses oslo config generator to generate LBaaS sample configuration files"},{"line_number":33,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":34,"context_line":"    cp $NEUTRON_VPNAAS_DIR/etc/vpn_agent.ini.sample $Q_VPN_CONF_FILE"},{"line_number":35,"context_line":"    if [[ \"$IPSEC_PACKAGE\" \u003d\u003d \"strongswan\" ]]; then"},{"line_number":36,"context_line":"        iniset_multiline $Q_VPN_CONF_FILE vpnagent vpn_device_driver neutron_vpnaas.services.vpn.device_drivers.strongswan_ipsec.StrongSwanDriver"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a740942_3a62e53e","line":33,"updated":"2015-12-14 14:24:12.000000000","message":"Does it mean we call it twice for a node that runs a server and an agent? Can we avoid it?","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"03d5bb2069faad8c82ff5da8b90151fe57f946ab","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function neutron_vpn_configure_agent {"},{"line_number":32,"context_line":"    # Uses oslo config generator to generate LBaaS sample configuration files"},{"line_number":33,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":34,"context_line":"    cp $NEUTRON_VPNAAS_DIR/etc/vpn_agent.ini.sample $Q_VPN_CONF_FILE"},{"line_number":35,"context_line":"    if [[ \"$IPSEC_PACKAGE\" \u003d\u003d \"strongswan\" ]]; then"},{"line_number":36,"context_line":"        iniset_multiline $Q_VPN_CONF_FILE vpnagent vpn_device_driver neutron_vpnaas.services.vpn.device_drivers.strongswan_ipsec.StrongSwanDriver"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a740942_9deaf3d6","line":33,"in_reply_to":"7a740942_3a62e53e","updated":"2015-12-14 14:35:56.000000000","message":"AFIK, the agent is run now and the server path is deprecated. So it is not called twice.","commit_id":"bca111057fc40b6ee9e152ededc3cbb1d5dfc4e8"}]}