)]}'
{"id":"openstack%2Fdevstack~25362","triplet_id":"openstack%2Fdevstack~master~I4ca8b8e69c0fb05a7c9cf2fd4643eac2f7643aa9","project":"openstack/devstack","branch":"master","topic":"stackrc_repo_config","hashtags":[],"change_id":"I4ca8b8e69c0fb05a7c9cf2fd4643eac2f7643aa9","subject":"Increase flexibility of stackrc repo config.","status":"MERGED","created":"2013-03-26 04:40:46.000000000","updated":"2013-04-09 17:05:57.000000000","submitted":"2013-04-09 17:05:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"223e89a0fb41deb64a58cd3ec0ad867d60ef3609","_number":25362,"virtual_id_number":25362,"owner":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-04-09 17:05:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-04-02 22:59:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":2,"date":"2013-04-09 16:10:03.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":1,"date":"2013-04-03 17:22:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":1,"date":"2013-04-09 16:10:03.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-26 14:38:01.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2013-04-03 17:22:43.000000000","updated_by":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"reviewer":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"state":"REVIEWER"},{"updated":"2013-04-09 16:10:03.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-04-09 17:05:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3f3cceb5422e8661a8dade1944c8336210bedf5d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 05:18:35.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25362/1/check/gate-tempest-devstack-vm-full/10448 : SUCCESS\n- http://logs.openstack.org/25362/1/check/gate-tempest-devstack-vm-postgres-full/10164 : SUCCESS\n- http://logs.openstack.org/25362/1/check/gate-tempest-devstack-vm-quantum/15991 : SUCCESS\n- http://logs.openstack.org/25362/1/check/gate-grenade-devstack-vm/57 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"fa41b438d7c9753f70874a0b92af3f7ae72c56ca","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-03-26 17:43:04.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7cb2af58868177fa015c79dc0cf2368095b13a53","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-03-26 20:29:22.000000000","message":"Patch Set 1: Do not merge\n\nThis makes a change in the assumptions about the REPO and BRANCH variables in that if they happen to be set when stackrc is sourced, their values will not be reset as they are today.  I don\u0027t know yet if this is a problem or not but it needs to be checked out.  My primary worry right now is in Grenade, although there are times when stackrc is sourced more than once in DevStack.\n\nI think it will be likely that the only time OS_BRANCH will have the same value for all repos is for \u0027master\u0027.  Specifically, the clients do not have \u0027milestone/proposed\u0027 or \u0027stable/grizzly\u0027 or whatever.\n\nAlso, thus far DevStack does not use any variables prefixed \u0027OS_\u0027, those are generally expected to be consumed by the command-line clients.","accounts_in_message":[],"_revision_number":1},{"id":"c90370e24ce37f083e63748114ba79f9543a4d5b","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-03-26 20:42:12.000000000","message":"Patch Set 1:\n\nDean: It sounds like the OS_BRANCH is undesirable, so I\u0027ll revert that part of the change.   And though I can\u0027t see how the changes to repo definition would impact code that wasn\u0027t simply terrible, I\u0027ll cross my fingers and defer to your superior wisdom.","accounts_in_message":[],"_revision_number":1},{"id":"ef51e43b801cea8f81de79ae44ee64c86eb44f36","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-04-02 05:17:00.000000000","message":"Patch Set 1:\n\nI like this change but agree with dean\u0027s point how about change it to like this: \n\n-CEILOMETER_BRANCH\u003d${CEILOMETER_BRANCH:-$OS_BRANCH}\nCEILOMETER_BRANCH\u003d${CEILOMETER_BRANCH:-\"master\"}\n\netc...","accounts_in_message":[],"_revision_number":1},{"id":"282ca9562433c42fd2e5d37d4249a9086f998a52","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-04-02 22:57:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"86d2f5d574e88628574fc425cf0f2b14c7683a6a","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-04-02 22:59:20.000000000","message":"Patch Set 2:\n\nDean: Removed the branch config as per your suggestion.  Any word on whether the repo config changes are acceptable?","accounts_in_message":[],"_revision_number":2},{"id":"d440dbfcc14f9a1d436577b5ab4ad8bd8d799163","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 23:02:07.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25362/2/check/gate-tempest-devstack-vm-full/11325 : FAILURE\n- http://logs.openstack.org/25362/2/check/gate-tempest-devstack-vm-postgres-full/11041 : FAILURE\n- http://logs.openstack.org/25362/2/check/gate-tempest-devstack-vm-quantum/17018 : FAILURE\n- http://logs.openstack.org/25362/2/check/gate-grenade-devstack-vm/180 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"afa6d266ef7d5f4bd7116c2d6b71741f90e2976b","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-04-03 17:22:43.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"20af87d09af4253c4cd9c41d3bcd4dae591a3a9b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-03 18:02:57.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25362/2/check/gate-tempest-devstack-vm-full/11474 : SUCCESS\n- http://logs.openstack.org/25362/2/check/gate-tempest-devstack-vm-postgres-full/11189 : SUCCESS\n- http://logs.openstack.org/25362/2/check/gate-tempest-devstack-vm-quantum/17175 : SUCCESS\n- http://logs.openstack.org/25362/2/check/gate-grenade-devstack-vm/192 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c7bb147df6c390ac6428be97467cb6341c6644aa","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2013-04-08 17:37:53.000000000","message":"Patch Set 2:\n\nDean: ping","accounts_in_message":[],"_revision_number":2},{"id":"db628479b50f6283d9c2e732cec5318390ca9e19","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-04-09 16:10:03.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nOK, I think I\u0027m OK with this.  My concern is with Grenade moreso than DevStack itself.","accounts_in_message":[],"_revision_number":2},{"id":"2e3a6bb4c685ecd73653036ba9e5758b511e2227","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-09 16:10:05.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f10b16b74e3fe099485e632637758d52d1217c7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-09 17:05:56.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/25362/2/gate/gate-tempest-devstack-vm-full/12072 : SUCCESS\n- http://logs.openstack.org/25362/2/gate/gate-tempest-devstack-vm-postgres-full/11787 : SUCCESS\n- http://logs.openstack.org/25362/2/gate/gate-tempest-devstack-vm-quantum/17868 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"60b70f1b82c1ebeb9cbb27de8b794a2e2d24a717","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-09 17:05:57.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a81dcaa62466d6f1260895fd08d1de607f34da21","revisions":{"c893b8a36f602abd96f2ec270e32db4509723d3e":{"kind":"REWORK","_number":1,"created":"2013-03-26 04:40:46.000000000","uploader":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"ref":"refs/changes/62/25362/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/62/25362/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/62/25362/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/62/25362/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/62/25362/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/62/25362/1"}}},"commit":{"parents":[{"commit":"b6a86dbe0f598536c576e6aafe0d493d108b9094","subject":"Merge \"Multi-node setup: Fix keystone host\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b6a86dbe0f598536c576e6aafe0d493d108b9094"}]}],"author":{"name":"Maru Newby","email":"marun@redhat.com","date":"2013-03-26 04:15:34.000000000","tz":-240},"committer":{"name":"Maru Newby","email":"marun@redhat.com","date":"2013-03-26 04:33:34.000000000","tz":-240},"subject":"Increase flexibility of stackrc repo config.","message":"Increase flexibility of stackrc repo config.\n\n * Offline use of devstack previously required defining individual\n   repo overrides.  This change maintains support for individual\n   overrides while adding the ability to override GIT_BASE.\n * Add new variable OS_BRANCH denoting the default git branch to use\n   for core projects.\n\nChange-Id: I4ca8b8e69c0fb05a7c9cf2fd4643eac2f7643aa9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c893b8a36f602abd96f2ec270e32db4509723d3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c893b8a36f602abd96f2ec270e32db4509723d3e"}]},"branch":"refs/heads/master"},"a81dcaa62466d6f1260895fd08d1de607f34da21":{"kind":"REWORK","_number":2,"created":"2013-04-02 22:57:33.000000000","uploader":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"ref":"refs/changes/62/25362/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/62/25362/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/62/25362/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/62/25362/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/62/25362/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/62/25362/2"}}},"commit":{"parents":[{"commit":"4b1dbb5dabb6a30097030c0a625830a17c5c065f","subject":"Keystone doesn\u0027t depend on bcrypt any more","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4b1dbb5dabb6a30097030c0a625830a17c5c065f"}]}],"author":{"name":"Maru Newby","email":"marun@redhat.com","date":"2013-03-26 04:15:34.000000000","tz":-240},"committer":{"name":"Maru Newby","email":"marun@redhat.com","date":"2013-04-02 22:57:02.000000000","tz":0},"subject":"Increase flexibility of stackrc repo config.","message":"Increase flexibility of stackrc repo config.\n\n * Offline use of devstack previously required defining individual\n   repo overrides.  This change maintains support for individual\n   overrides while adding the ability to override GIT_BASE.\n\nChange-Id: I4ca8b8e69c0fb05a7c9cf2fd4643eac2f7643aa9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a81dcaa62466d6f1260895fd08d1de607f34da21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a81dcaa62466d6f1260895fd08d1de607f34da21"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}