)]}'
{"functions":[{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"9587ea8a5df3f622346278d88a6c3ce2d416489c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    local pkg_dir"},{"line_number":159,"context_line":"    if is_ubuntu; then"},{"line_number":160,"context_line":"        pkg_dir\u003d$FILES/apts"},{"line_number":161,"context_line":"    elif is_fedora || is_RHEL6; then"},{"line_number":162,"context_line":"        pkg_dir\u003d$FILES/rpms"},{"line_number":163,"context_line":"    elif is_suse; then"},{"line_number":164,"context_line":"        pkg_dir\u003d$FILES/rpms-suse"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzGA%3D","line":161,"updated":"2013-03-27 03:42:20.000000000","message":"I think this could be avoided by retaining the old behavior","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8548aaf46c17c40db6e994d59dcfec5c7fb44bc8","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        else"},{"line_number":409,"context_line":"            DISTRO\u003d\"sle${os_RELEASE}sp${os_UPDATE}\""},{"line_number":410,"context_line":"        fi"},{"line_number":411,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red Hat) ]]; then"},{"line_number":412,"context_line":"\t# we drop the . release; it should be fine"},{"line_number":413,"context_line":"\tDISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":414,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FwxQ%3D","line":411,"updated":"2013-03-28 15:55:47.000000000","message":"Unless there is a specific reason not to, please add CentOS to this check.  I\u0027m not aware of any reason to distinguish the two for devstack/openstack purposes.","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"b2610f92b93b544baad1fdf74bea42f03afa000f","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            DISTRO\u003d\"sle${os_RELEASE}sp${os_UPDATE}\""},{"line_number":410,"context_line":"        fi"},{"line_number":411,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red Hat) ]]; then"},{"line_number":412,"context_line":"\t# we drop the . release; it should be fine"},{"line_number":413,"context_line":"\tDISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":414,"context_line":"    else"},{"line_number":415,"context_line":"        # Catch-all for now is Vendor + Release + Update"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzOU%3D","line":412,"updated":"2013-03-27 01:16:55.000000000","message":"tabs -\u003e spaces","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"9587ea8a5df3f622346278d88a6c3ce2d416489c","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"# Determine if current distribution is a Fedora-based distribution"},{"line_number":436,"context_line":"# (Fedora, RHEL, CentOS)."},{"line_number":437,"context_line":"# is_fedora"},{"line_number":438,"context_line":"function is_fedora {"},{"line_number":439,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzJQ%3D","line":436,"updated":"2013-03-27 03:42:20.000000000","message":"I feel it would be better to maintain the old behavior and treat RHEL as  specialisation of Fedora. Meaning, is_fedora is a superset of {RHEL, Fedora and CentOS}. and is_rhel6 answers the specific case if the distro is RHEL6. \n\nso then, instead of writing:\n\nif is_ubuntu || is_fedora || is_rhel; then\n ...\nfi\n\none could treat the is_fedora as the common denominator for all the 33 fedora based OS and write\n\nif is_ubuntu || is_fedora; then \n  ...\nfi\n\nand special cases can be address in  a nested if\n\nif is_fedora; then \n  common stuff\n  if is_rhel6; then\n     rhel specific\n  fi\n  more common stuff\nfi\n\nMay be is_fedora is more is_fedora_based","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8548aaf46c17c40db6e994d59dcfec5c7fb44bc8","unresolved":false,"context_lines":[{"line_number":433,"context_line":""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"# Determine if current distribution is a Fedora-based distribution"},{"line_number":436,"context_line":"# (Fedora, RHEL, CentOS)."},{"line_number":437,"context_line":"# is_fedora"},{"line_number":438,"context_line":"function is_fedora {"},{"line_number":439,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2Fwww%3D","line":436,"in_reply_to":"AAAAOH%2F%2FzJQ%3D","updated":"2013-03-28 15:55:47.000000000","message":"+1/2\n\nCorrect on the meaning of is_fedora being a family test.  If you need the specific family member, test $os_VENDOR.  If you need the specific release test $os_RELEASE.","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"9587ea8a5df3f622346278d88a6c3ce2d416489c","unresolved":false,"context_lines":[{"line_number":444,"context_line":"}"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"# Determine if current distribution is RHEL6/CentOS"},{"line_number":447,"context_line":"function is_RHEL6 {"},{"line_number":448,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"},{"line_number":449,"context_line":"\tGetOSVersion"},{"line_number":450,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzJU%3D","line":447,"updated":"2013-03-27 03:42:20.000000000","message":"is_rhel6: to align with the naming convention used","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"96b6f96dfdf5820569d3b517cf3edecdbb909d9f","unresolved":false,"context_lines":[{"line_number":444,"context_line":"}"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"# Determine if current distribution is RHEL6/CentOS"},{"line_number":447,"context_line":"function is_RHEL6 {"},{"line_number":448,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"},{"line_number":449,"context_line":"\tGetOSVersion"},{"line_number":450,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2Fys8%3D","line":447,"in_reply_to":"AAAAOH%2F%2FzJU%3D","updated":"2013-03-27 11:42:08.000000000","message":"+1","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fa0b51f05577a3acc30ad9d56935e587251eaa8c","unresolved":false,"context_lines":[{"line_number":444,"context_line":"}"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"# Determine if current distribution is RHEL6/CentOS"},{"line_number":447,"context_line":"function is_RHEL6 {"},{"line_number":448,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"},{"line_number":449,"context_line":"\tGetOSVersion"},{"line_number":450,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FxoU%3D","line":447,"in_reply_to":"AAAAOH%2F%2FzJU%3D","updated":"2013-03-27 23:07:53.000000000","message":"Done","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"96b6f96dfdf5820569d3b517cf3edecdbb909d9f","unresolved":false,"context_lines":[{"line_number":446,"context_line":"# Determine if current distribution is RHEL6/CentOS"},{"line_number":447,"context_line":"function is_RHEL6 {"},{"line_number":448,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"},{"line_number":449,"context_line":"\tGetOSVersion"},{"line_number":450,"context_line":"    fi"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    ( [ \"$os_VENDOR\" \u003d \"Red Hat\" ] || [ \"$os_VENDOR\" \u003d \"CentOS\" ] ) \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FytA%3D","line":449,"updated":"2013-03-27 11:42:08.000000000","message":"hard tab","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"9587ea8a5df3f622346278d88a6c3ce2d416489c","unresolved":false,"context_lines":[{"line_number":449,"context_line":"\tGetOSVersion"},{"line_number":450,"context_line":"    fi"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    ( [ \"$os_VENDOR\" \u003d \"Red Hat\" ] || [ \"$os_VENDOR\" \u003d \"CentOS\" ] ) \\"},{"line_number":453,"context_line":"\t\u0026\u0026 [ \"${os_RELEASE::1}\" \u003d \"6\" ]"},{"line_number":454,"context_line":"}"},{"line_number":455,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzFs%3D","line":452,"updated":"2013-03-27 03:42:20.000000000","message":"How about a is_rhel([version]) where version is optional and if supplied checks the version too.","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"96b6f96dfdf5820569d3b517cf3edecdbb909d9f","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        NO_UPDATE_REPOS\u003dTrue"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        apt_get install \"$@\""},{"line_number":781,"context_line":"    elif is_fedora || is_RHEL6; then"},{"line_number":782,"context_line":"        yum_install \"$@\""},{"line_number":783,"context_line":"    elif is_suse; then"},{"line_number":784,"context_line":"        zypper_install \"$@\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2Fys0%3D","line":781,"updated":"2013-03-27 11:42:08.000000000","message":"with so many of these, can we come up with is_rh which is is_fedora || is_rhel6 ?","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e7e9060fc94f41c927e63fc529bf5a508e175b23","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            DISTRO\u003d\"sle${os_RELEASE}sp${os_UPDATE}\""},{"line_number":410,"context_line":"        fi"},{"line_number":411,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red Hat) ]]; then"},{"line_number":412,"context_line":"\t# we drop the . release; it should be fine"},{"line_number":413,"context_line":"\tDISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":414,"context_line":"    else"},{"line_number":415,"context_line":"        # Catch-all for now is Vendor + Release + Update"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAOH%2F%2FtiY%3D","line":412,"updated":"2013-04-02 00:01:50.000000000","message":"hard tabs","commit_id":"c2c805db734c16da398d3869d9bb07a78176a510"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e7e9060fc94f41c927e63fc529bf5a508e175b23","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    fi"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    is_fedora \u0026\u0026 \\"},{"line_number":456,"context_line":"\t( [ \"$os_VENDOR\" \u003d \"Red Hat\" ] || [ \"$os_VENDOR\" \u003d \"CentOS\" ] ) \\"},{"line_number":457,"context_line":"\t\u0026\u0026 [ \"${os_RELEASE::1}\" \u003d \"6\" ]"},{"line_number":458,"context_line":"}"},{"line_number":459,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAOH%2F%2FtiU%3D","line":456,"updated":"2013-04-02 00:01:50.000000000","message":"hard tabs","commit_id":"c2c805db734c16da398d3869d9bb07a78176a510"}],"lib/rpc_backend":[{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"b2610f92b93b544baad1fdf74bea42f03afa000f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    if is_service_enabled qpid \u0026\u0026 ! qpid_is_supported; then"},{"line_number":42,"context_line":"        die $LINENO \"Qpid support is not available for this version of your distribution.\""},{"line_number":43,"context_line":"\t# XXX : check if RHEL6 is using qpid?"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzOY%3D","line":43,"updated":"2013-03-27 01:16:55.000000000","message":"qpid is supported on rhel6 (return true from qpid_is_supported())","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e3d2dc86a2d0a33ef8a197043adae76dfa65151b","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    if is_service_enabled qpid \u0026\u0026 ! qpid_is_supported; then"},{"line_number":42,"context_line":"        die $LINENO \"Qpid support is not available for this version of your distribution.\""},{"line_number":43,"context_line":"\t# XXX : check if RHEL6 is using qpid?"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOH%2F%2FzIA%3D","line":43,"in_reply_to":"AAAAOH%2F%2FzOY%3D","updated":"2013-03-27 03:11:01.000000000","message":"What I mean here is that RHEL6 will only support qpid (well, will only be tested with qpid, anyway, even if something else works), so maybe if on RHEL6 we should enforce qpid as the only choice?  or at least warn you strongly if you chose something else","commit_id":"774b4e641d7605bff7ab2c7ad02012866591bab4"}]}