)]}'
{"lib/glance":[{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"c57a207334ec6a40fa548912940aac9c00b0c8c2","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    if [ \"$LOG_COLOR\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$SYSLOG\" \u003d\u003d \"False\" ]; then"},{"line_number":211,"context_line":"        setup_colorized_logging $GLANCE_API_CONF DEFAULT tenant user"},{"line_number":212,"context_line":"        setup_colorized_logging $GLANCE_REGISTRY_CONF DEFAULT tenant user"},{"line_number":213,"context_line":"\tsetup_colorized_logging $GLANCE_ARTIFACTS_CONF DEFAULT tenant user"},{"line_number":214,"context_line":"    fi"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    cp -p $GLANCE_DIR/etc/glance-registry-paste.ini $GLANCE_REGISTRY_PASTE_INI"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a710552_fa8635da","line":213,"updated":"2015-12-15 18:33:10.000000000","message":"This should not be done unless g-artifacts is enabled: this creates a config file containing just this logging thing","commit_id":"6fc080480d5adb0f1468a6a68ee5bc9b1298e152"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"bd52558fdecf0caa4f39739eedaf1a94777eff66","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"file, http, swift\""},{"line_number":157,"context_line":"        iniset $GLANCE_API_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # if glare enabled"},{"line_number":160,"context_line":"        if is_service_enabled g-artifacts; then"},{"line_number":161,"context_line":"           iniset $GLANCE_ARTIFACTS glance_store default_store swift"},{"line_number":162,"context_line":"           iniset $GLANCE_ARTIFACTS glance_store swift_store_create_container_on_put True"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a710552_64baa725","line":159,"updated":"2015-12-15 19:27:02.000000000","message":"Useless comment","commit_id":"64b194ca6b1be8f7cde6c3a6d5eaa3ccc2d6cff2"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"bd52558fdecf0caa4f39739eedaf1a94777eff66","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        iniset $GLANCE_API_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # if glare enabled"},{"line_number":160,"context_line":"        if is_service_enabled g-artifacts; then"},{"line_number":161,"context_line":"           iniset $GLANCE_ARTIFACTS glance_store default_store swift"},{"line_number":162,"context_line":"           iniset $GLANCE_ARTIFACTS glance_store swift_store_create_container_on_put True"},{"line_number":163,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a710552_44868b66","line":160,"updated":"2015-12-15 19:27:02.000000000","message":"Please, fix the indent, or say the work, if this will work only if s-proxy enabled.","commit_id":"64b194ca6b1be8f7cde6c3a6d5eaa3ccc2d6cff2"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"a72c6ce855521e074bb46fbcd0169b0f0637eb83","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        iniset $GLANCE_API_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # if glare enabled"},{"line_number":160,"context_line":"        if is_service_enabled g-artifacts; then"},{"line_number":161,"context_line":"           iniset $GLANCE_ARTIFACTS glance_store default_store swift"},{"line_number":162,"context_line":"           iniset $GLANCE_ARTIFACTS glance_store swift_store_create_container_on_put True"},{"line_number":163,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a710552_87723548","line":160,"in_reply_to":"5a710552_44868b66","updated":"2015-12-15 19:44:12.000000000","message":"This is evident from the above comment (updated on 6 patchset)","commit_id":"64b194ca6b1be8f7cde6c3a6d5eaa3ccc2d6cff2"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"bd52558fdecf0caa4f39739eedaf1a94777eff66","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        setup_colorized_logging $GLANCE_API_CONF DEFAULT tenant user"},{"line_number":212,"context_line":"        setup_colorized_logging $GLANCE_REGISTRY_CONF DEFAULT tenant user"},{"line_number":213,"context_line":"        if is_service_enabled g-search; then"},{"line_number":214,"context_line":"\t         setup_colorized_logging $GLANCE_ARTIFACTS_CONF DEFAULT tenant user"},{"line_number":215,"context_line":"        fi"},{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a710552_24381fa0","line":214,"updated":"2015-12-15 19:27:02.000000000","message":"Please fix the indent","commit_id":"64b194ca6b1be8f7cde6c3a6d5eaa3ccc2d6cff2"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"bd52558fdecf0caa4f39739eedaf1a94777eff66","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    # Configure GLANCE_ARTIFACTS (Glance Artifacts)"},{"line_number":278,"context_line":"    if is_service_enabled g-artifacts; then"},{"line_number":279,"context_line":"      cp $GLANCE_DIR/etc/glance-artifacts.conf $GLANCE_ARTIFACTS_CONF"},{"line_number":280,"context_line":"      local dburl"},{"line_number":281,"context_line":"      dburl\u003d`database_connection_url glance`"},{"line_number":282,"context_line":"      iniset $GLANCE_ARTIFACTS_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a710552_041083a7","line":279,"updated":"2015-12-15 19:27:02.000000000","message":"Fix the indent please","commit_id":"64b194ca6b1be8f7cde6c3a6d5eaa3ccc2d6cff2"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"bd52558fdecf0caa4f39739eedaf1a94777eff66","unresolved":false,"context_lines":[{"line_number":305,"context_line":"# SERVICE_TENANT_NAME  glance          service"},{"line_number":306,"context_line":"# SERVICE_TENANT_NAME  glance-swift    ResellerAdmin (if Swift is enabled)"},{"line_number":307,"context_line":"# SERVICE_TENANT_NAME  glance-search   search (if Search is enabled)"},{"line_number":308,"context_line":"# SERVICE_TENANT_NAME  glare           artifacts (if enabled)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"function create_glance_accounts {"},{"line_number":311,"context_line":"    if is_service_enabled g-api; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a710552_242c9f01","line":308,"updated":"2015-12-15 19:27:02.000000000","message":"artifacts -\u003e service","commit_id":"64b194ca6b1be8f7cde6c3a6d5eaa3ccc2d6cff2"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"5da2fb0231121697192be664aed5ea41313ee4d1","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        setup_colorized_logging $GLANCE_API_CONF DEFAULT tenant user"},{"line_number":212,"context_line":"        setup_colorized_logging $GLANCE_REGISTRY_CONF DEFAULT tenant user"},{"line_number":213,"context_line":"        if is_service_enabled g-search; then"},{"line_number":214,"context_line":"\t          setup_colorized_logging $GLANCE_ARTIFACTS_CONF DEFAULT tenant user"},{"line_number":215,"context_line":"        fi"},{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5a710552_826d439a","line":214,"updated":"2015-12-15 20:04:09.000000000","message":"Fix indent, please","commit_id":"bf9b1d7cd021b81e3a60fa932d555a041e732669"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"c797317e0e4963df7517933ce8c806a86acb7aa7","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    if [ \"$LOG_COLOR\" \u003d\u003d \"True\" ] \u0026\u0026 [ \"$SYSLOG\" \u003d\u003d \"False\" ]; then"},{"line_number":211,"context_line":"        setup_colorized_logging $GLANCE_API_CONF DEFAULT tenant user"},{"line_number":212,"context_line":"        setup_colorized_logging $GLANCE_REGISTRY_CONF DEFAULT tenant user"},{"line_number":213,"context_line":"        if is_service_enabled g-search; then"},{"line_number":214,"context_line":"            setup_colorized_logging $GLANCE_ARTIFACTS_CONF DEFAULT tenant user"},{"line_number":215,"context_line":"        fi"},{"line_number":216,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a710552_f85ab882","line":213,"updated":"2015-12-15 21:04:39.000000000","message":"this has nothing to do with g-search. You probably mean g-artifacts.\n\nAlso note, that this one will colorize the GLANCE_ARTIFACTS_CONF file before it gets copied by the cp command on line 279 below. So, this colorizing will eventually get lost.\nI suggest to move this fragment into the \"configure glance artifacts\" below","commit_id":"0f4a47f0b43142721870b2e37609822226718813"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"f35f6ff2a1934967bc81aec72c6ef99d6d88bb82","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # commenting is not strictly necessary but it\u0027s confusing to have bad values in conf"},{"line_number":170,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_user"},{"line_number":171,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_key"},{"line_number":172,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_auth_address"},{"line_number":173,"context_line":"        fi"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user $SERVICE_TENANT_NAME:glance-swift"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3a7e1126_b6e54ca9","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":40},"updated":"2015-12-17 08:26:51.000000000","message":"These three lines should be $GLANCE_ARTIFACTS_CONF. The script fails otherwise.","commit_id":"da73b9c1456d74f15e992fcde2309e8f683e826d"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"adef1581daa14e045bcf98154dd316e45670aa24","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # commenting is not strictly necessary but it\u0027s confusing to have bad values in conf"},{"line_number":170,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_user"},{"line_number":171,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_key"},{"line_number":172,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_auth_address"},{"line_number":173,"context_line":"        fi"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user $SERVICE_TENANT_NAME:glance-swift"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3a7e1126_197a5325","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":40},"in_reply_to":"3a7e1126_39262f69","updated":"2015-12-17 08:32:47.000000000","message":"Done","commit_id":"da73b9c1456d74f15e992fcde2309e8f683e826d"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"55ea52c313c3087825112a43317c36fb8d863ae7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # commenting is not strictly necessary but it\u0027s confusing to have bad values in conf"},{"line_number":170,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_user"},{"line_number":171,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_key"},{"line_number":172,"context_line":"            inicomment $GLANCE_ARTIFACTS glance_store swift_store_auth_address"},{"line_number":173,"context_line":"        fi"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user $SERVICE_TENANT_NAME:glance-swift"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3a7e1126_39262f69","line":172,"range":{"start_line":172,"start_character":24,"end_line":172,"end_character":40},"in_reply_to":"3a7e1126_b6e54ca9","updated":"2015-12-17 08:31:08.000000000","message":"i\u0027m sorry, was mistaken, correct it right now","commit_id":"da73b9c1456d74f15e992fcde2309e8f683e826d"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"629e245bcd32f07e7e69ffb6d3f424210a48cd36","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    fi"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # Store specific configs"},{"line_number":144,"context_line":"    iniset $GLANCE_API_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":145,"context_line":"    iniset $GLANCE_API_CONF DEFAULT registry_host $GLANCE_SERVICE_HOST"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a7e1126_849b3ac9","line":144,"updated":"2015-12-17 08:41:02.000000000","message":"This one also needs to be done for $GLANCE_ARTIFACTS_CONF as well - to configure the filesystem store of it. Don\u0027t forget that it should be done after the config is copied, i.e. after the line 276","commit_id":"823b09ec0cde2d56d9ec7a2d294694ae7bf3d7c3"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"df5a70e17bb7fd7df57f7b23f1476038331ec6d2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    fi"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # Store specific configs"},{"line_number":144,"context_line":"    iniset $GLANCE_API_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":145,"context_line":"    iniset $GLANCE_API_CONF DEFAULT registry_host $GLANCE_SERVICE_HOST"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a7e1126_c4adc289","line":144,"in_reply_to":"3a7e1126_849b3ac9","updated":"2015-12-17 08:45:58.000000000","message":"Done","commit_id":"823b09ec0cde2d56d9ec7a2d294694ae7bf3d7c3"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"63037e4ce949b577d296b6a121a3134f9da6858d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        iniset $GLANCE_API_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # Store the artifacts in swift if enabled."},{"line_number":160,"context_line":"        if is_service_enabled g-artifacts; then"},{"line_number":161,"context_line":"            iniset $GLANCE_ARTIFACTS_CONF glance_store default_store swift"},{"line_number":162,"context_line":"            iniset $GLANCE_ARTIFACTS_CONF glance_store swift_store_create_container_on_put True"},{"line_number":163,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a7e1126_792b57ec","line":160,"updated":"2015-12-17 08:33:46.000000000","message":"This configuration happens before the $GLANCE_ARTIFACTS_CONF config file is copied (which is done at line 276). As a result, all the changes in this block get lost. This blocks should me moved down, below the line 276","commit_id":"823b09ec0cde2d56d9ec7a2d294694ae7bf3d7c3"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"df5a70e17bb7fd7df57f7b23f1476038331ec6d2","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        iniset $GLANCE_API_CONF DEFAULT graceful_shutdown_timeout \"$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT\""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        # Store the artifacts in swift if enabled."},{"line_number":160,"context_line":"        if is_service_enabled g-artifacts; then"},{"line_number":161,"context_line":"            iniset $GLANCE_ARTIFACTS_CONF glance_store default_store swift"},{"line_number":162,"context_line":"            iniset $GLANCE_ARTIFACTS_CONF glance_store swift_store_create_container_on_put True"},{"line_number":163,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a7e1126_84b6dada","line":160,"in_reply_to":"3a7e1126_792b57ec","updated":"2015-12-17 08:45:58.000000000","message":"Done","commit_id":"823b09ec0cde2d56d9ec7a2d294694ae7bf3d7c3"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"ff43e02476c9b8228f44aa86345c3e473142e8ef","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # Copy over our glance configurations and update them"},{"line_number":109,"context_line":"    if is_service_enabled g-artifacts; then"},{"line_number":110,"context_line":"        cp $GLANCE_DIR/etc/glance-artifacts.conf $GLANCE_ARTIFACTS_CONF"},{"line_number":111,"context_line":"    cp $GLANCE_DIR/etc/glance-registry.conf $GLANCE_REGISTRY_CONF"},{"line_number":112,"context_line":"    iniset $GLANCE_REGISTRY_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":113,"context_line":"    iniset $GLANCE_REGISTRY_CONF DEFAULT bind_host $GLANCE_SERVICE_LISTEN_ADDRESS"},{"line_number":114,"context_line":"    inicomment $GLANCE_REGISTRY_CONF DEFAULT log_file"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3a7e1126_822b1530","line":111,"updated":"2015-12-17 12:59:06.000000000","message":"you forgot fi here","commit_id":"cd832bbb7e54b0b4d55789c96d62e0447f67d68a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e3bc623c323cd565981bafc8980688eeabb61b08","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Store specific configs"},{"line_number":138,"context_line":"    iniset $GLANCE_API_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":139,"context_line":"    iniset $GLANCE_GLARE_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":140,"context_line":"    iniset $GLANCE_API_CONF DEFAULT registry_host $GLANCE_SERVICE_HOST"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    iniset $GLANCE_API_CONF DEFAULT workers \"$API_WORKERS\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3a57f1b5_6c42416a","line":139,"updated":"2016-02-11 23:42:06.000000000","message":"seems like this should be behind the \"if service\" check too, otherwise $GLANCE_GLARE_CONF won\u0027t be there (it looks like we just go ahead and create the blank file [1] which is a bit confusing)\n\n[1] http://logs.openstack.org/88/257888/13/check/gate-tempest-dsvm-full/1010aa6/logs/etc/glance/glance-glare.conf.txt.gz","commit_id":"26527232656e3055eea10afe69545d6b4b45a0d4"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"336c6feb36aa19ffe936c725cb1237eadc888c00","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Add glance-glare service and endpoints"},{"line_number":308,"context_line":"    if is_service_enabled g-glare; then"},{"line_number":309,"context_line":"        if [[ \"$KEYSTONE_CATALOG_BACKEND\" \u003d \u0027sql\u0027 ]]; then"},{"line_number":310,"context_line":"            create_service_user \"glare\""},{"line_number":311,"context_line":"            get_or_create_service \"glare\" \"artifact\" \"Glance Artifact Service\""},{"line_number":312,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9aed3d3a_2375cd97","line":309,"range":{"start_line":309,"start_character":0,"end_line":309,"end_character":58},"updated":"2016-02-26 16:38:03.000000000","message":"This variable has been removed in I4e5c7e86aefe72fc21c77d423033e9b169318fec as far as I know","commit_id":"3a6f6f990b6c85cdf86b426016175fe971fc1998"}]}