)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6390048c34998e2960074371eb39da2caee5fc40","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-18 11:08:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron VPNaaS: Set default service provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default value needs to be set for service_provide config item in"},{"line_number":10,"context_line":"neutron_vpnaas.conf."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_cb5fb83f","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":14},"updated":"2015-12-18 12:19:13.000000000","message":"Can you elaborate on why this is needed?\n\nQuite some time back neutron-vpnaas moved to a devstack plugin, and IIRC, the only reason there is VPN setup still in devstack, is to support older releases (like kilo) that did not have plugin support, and possibly grenade tests (I vaguely recall grenade doesn\u0027t work with the plugin).\n\n\nIt would be good for the commit message to explain the purpose for this change. I\u0027m concerned about whether we need to continue supporting the legacy setup.\n\nIt\u0027s a bit different from LBaaS, which created a plugin, but still uses the older devstack setup, IIRC.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1dcbf9bddc206d7dddc2106e3e47ab6faf835802","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-18 11:08:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron VPNaaS: Set default service provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default value needs to be set for service_provide config item in"},{"line_number":10,"context_line":"neutron_vpnaas.conf."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_71eb0a14","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":14},"in_reply_to":"3a7e1126_2ba99590","updated":"2015-12-18 14:23:58.000000000","message":"I\u0027m cool with the patch, once the commit message is updated.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a17c8446af5f202abe3bd39167a7f8235bb84835","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Hickey \u003cmartin.hickey@ie.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-18 11:08:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron VPNaaS: Set default service provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default value needs to be set for service_provide config item in"},{"line_number":10,"context_line":"neutron_vpnaas.conf."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_2ba99590","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":14},"in_reply_to":"3a7e1126_cb5fb83f","updated":"2015-12-18 14:02:39.000000000","message":"It looks like deployment was done using enable_service q-vpn and not the devstack plugin.\n\nIt should probably be fixed for the old method as well.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9352ee75ba094a23a72f78528b520074bd45e079","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron VPNaaS: Set default service provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default value needs to be set for service_provide config item in"},{"line_number":10,"context_line":"neutron_vpnaas.conf."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0d5960c81c47a138087d480527eff2a8eef59445"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_157ddd6d","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":49},"updated":"2015-12-18 11:20:17.000000000","message":"service_provider","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a17c8446af5f202abe3bd39167a7f8235bb84835","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron VPNaaS: Set default service provider"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default value needs to be set for service_provide config item in"},{"line_number":10,"context_line":"neutron_vpnaas.conf."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0d5960c81c47a138087d480527eff2a8eef59445"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_50d4ccbb","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":49},"in_reply_to":"3a7e1126_157ddd6d","updated":"2015-12-18 14:02:39.000000000","message":"I can update if there is another spin.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"}],"lib/neutron-legacy":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6390048c34998e2960074371eb39da2caee5fc40","unresolved":false,"context_lines":[{"line_number":116,"context_line":"DEFAULT_LB_PROVIDER\u003dLOADBALANCER:Haproxy:neutron_lbaas.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Default provider for VPN service"},{"line_number":119,"context_line":"DEFAULT_VPN_PROVIDER\u003dVPN:openswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Agent binaries.  Note, binary paths for other agents are set in per-service"},{"line_number":122,"context_line":"# scripts in lib/neutron_plugins/services/"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a7e1126_06585531","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":33},"updated":"2015-12-18 12:19:13.000000000","message":"We probably want strongswan to be the default. Openswan isn\u0027t supported/provided in Ubuntu\u0027s newer releases.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a17c8446af5f202abe3bd39167a7f8235bb84835","unresolved":false,"context_lines":[{"line_number":116,"context_line":"DEFAULT_LB_PROVIDER\u003dLOADBALANCER:Haproxy:neutron_lbaas.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Default provider for VPN service"},{"line_number":119,"context_line":"DEFAULT_VPN_PROVIDER\u003dVPN:openswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Agent binaries.  Note, binary paths for other agents are set in per-service"},{"line_number":122,"context_line":"# scripts in lib/neutron_plugins/services/"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a7e1126_f056185b","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":33},"in_reply_to":"3a7e1126_06585531","updated":"2015-12-18 14:02:39.000000000","message":"Ok, will it be as follows:\nVPN:strongswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default   ?","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1dcbf9bddc206d7dddc2106e3e47ab6faf835802","unresolved":false,"context_lines":[{"line_number":116,"context_line":"DEFAULT_LB_PROVIDER\u003dLOADBALANCER:Haproxy:neutron_lbaas.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Default provider for VPN service"},{"line_number":119,"context_line":"DEFAULT_VPN_PROVIDER\u003dVPN:openswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Agent binaries.  Note, binary paths for other agents are set in per-service"},{"line_number":122,"context_line":"# scripts in lib/neutron_plugins/services/"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a7e1126_71846a5d","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":33},"in_reply_to":"3a7e1126_f056185b","updated":"2015-12-18 14:23:58.000000000","message":"Reversing my suggestion. Since plugin uses openswan still and this is more for backwards compatibility.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9352ee75ba094a23a72f78528b520074bd45e079","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"function _configure_neutron_vpn {"},{"line_number":1094,"context_line":"    # Uses oslo config generator to generate VPNaaS sample configuration files"},{"line_number":1095,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":1096,"context_line":"    if [ -f $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample ]; then"},{"line_number":1097,"context_line":"        cp $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample $NEUTRON_CONF_DIR/neutron_vpnaas.conf"},{"line_number":1098,"context_line":"        iniset $NEUTRON_CONF_DIR/neutron_vpnaas.conf service_providers service_provider $DEFAULT_VPN_PROVIDER"},{"line_number":1099,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a7e1126_b5e3a932","line":1096,"updated":"2015-12-18 11:20:17.000000000","message":"btw not sure why we don\u0027t fail here and instead silently proceed.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a17c8446af5f202abe3bd39167a7f8235bb84835","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"function _configure_neutron_vpn {"},{"line_number":1094,"context_line":"    # Uses oslo config generator to generate VPNaaS sample configuration files"},{"line_number":1095,"context_line":"    (cd $NEUTRON_VPNAAS_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":1096,"context_line":"    if [ -f $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample ]; then"},{"line_number":1097,"context_line":"        cp $NEUTRON_VPNAAS_DIR/etc/neutron_vpnaas.conf.sample $NEUTRON_CONF_DIR/neutron_vpnaas.conf"},{"line_number":1098,"context_line":"        iniset $NEUTRON_CONF_DIR/neutron_vpnaas.conf service_providers service_provider $DEFAULT_VPN_PROVIDER"},{"line_number":1099,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a7e1126_8b96893d","line":1096,"in_reply_to":"3a7e1126_b5e3a932","updated":"2015-12-18 14:02:39.000000000","message":"Not sure.","commit_id":"a361d4cb8186eec24cd897853b354bd5582d2cf2"}]}