)]}'
{"tools/xen/install_os_domU.sh":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"9aa477f9fb701db4f0e5d949292af7bd1cafa8a9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            fi"},{"line_number":42,"context_line":"        fi"},{"line_number":43,"context_line":"    done"},{"line_number":44,"context_line":"fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Source params - override xenrc params in your localrc to suit your taste"},{"line_number":47,"context_line":"source $THIS_DIR/xenrc"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a7b0d38_3e09312d","line":44,"updated":"2015-12-23 09:44:22.000000000","message":"This looks like it\u0027s a copy of what\u0027s done in stackrc? We shouldn\u0027t be copying code.  Perhaps we should have code in xenrc that will just source the sections from local.conf if it exists, rather than trying to generate a new .localrc.auto\n\nI also don\u0027t think this will work as xenrc uses localrc directly?","commit_id":"f0ce454c80461994cd382e13240adeddfaf44e3a"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"d0a5ad61f35270fd7cf37f2962d502e02111905d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            fi"},{"line_number":42,"context_line":"        fi"},{"line_number":43,"context_line":"    done"},{"line_number":44,"context_line":"fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Source params - override xenrc params in your localrc to suit your taste"},{"line_number":47,"context_line":"source $THIS_DIR/xenrc"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a7b0d38_b23d36bd","line":44,"in_reply_to":"1a7b0d38_3e09312d","updated":"2015-12-24 02:56:15.000000000","message":"1. yep, this is copied from stackrc for analyzing [local|localrc] part, local.conf is an INI file, we cannot source it directly and when we are trying to install domU, we need some variables defined in local.conf. I will try to see how to use variables without copying this part code\n2. xenrc use localrc file directly when localrc file exists, so if both localrc and local.conf exist, localrc will be used which is what we want. But if localrc doesn\u0027t exist, xenrc will source .local.auto which is generated from local.conf, so xenrc are using local.conf at this situation","commit_id":"f0ce454c80461994cd382e13240adeddfaf44e3a"}]}