)]}'
{"id":"openstack%2Fdevstack~26558","triplet_id":"openstack%2Fdevstack~master~Ifb6412f6860ceb28b724644fb9b618638f552102","project":"openstack/devstack","branch":"master","topic":"bug/1072121","hashtags":[],"change_id":"Ifb6412f6860ceb28b724644fb9b618638f552102","subject":"link /etc/tgt/stack.d to cinder volumes directory","status":"MERGED","created":"2013-04-10 00:21:04.000000000","updated":"2013-04-15 13:20:28.000000000","submitted":"2013-04-15 13:20:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"48df645b6f3615b201324ff059cce141954171ef","_number":26558,"virtual_id_number":26558,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-04-15 13:20:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-04-15 04:50:34.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2013-04-15 12:36:34.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-04-15 04:50:34.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":1,"date":"2013-04-15 12:36:34.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-15 04:50:34.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-04-15 12:36:34.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-04-15 13:20:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7ab9c318a1900e64f2a274f16ca202853dbdc38a","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2013-04-10 00:39:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b860ee828179774740ffe69100136d503bbd7967","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-10 01:21:15.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26558/2/check/gate-tempest-devstack-vm-full/12123 : SUCCESS\n- http://logs.openstack.org/26558/2/check/gate-tempest-devstack-vm-postgres-full/11838 : SUCCESS\n- http://logs.openstack.org/26558/2/check/gate-tempest-devstack-vm-quantum/17924 : SUCCESS\n- http://logs.openstack.org/26558/2/check/gate-grenade-devstack-vm/237 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"a20eb67d2e7839d4453614e082575de97b452d91","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-04-12 20:44:54.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nIf you can\u0027t use /etc/tgt/conf.d I don\u0027t see a reason to have both stack.conf and add a line to targets.conf to include it.  Just add the include for $CINDER_STATE_PATH/volumes/* directly to targets.conf.  You\u0027ll need to make sure that you don\u0027t add it more than once on succeeding runs of stack.sh","accounts_in_message":[],"_revision_number":2},{"id":"a7cbfc0181d73f5a14bf0a6c212a08060d2fd36f","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2013-04-14 19:50:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f82819acae010a8ccd55643cc0abc872332243cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-14 20:33:42.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/26558/3/check/gate-tempest-devstack-vm-full/12638 : SUCCESS\n- http://logs.openstack.org/26558/3/check/gate-tempest-devstack-vm-postgres-full/12353 : SUCCESS\n- http://logs.openstack.org/26558/3/check/gate-tempest-devstack-vm-quantum/18491 : SUCCESS\n- http://logs.openstack.org/26558/3/check/gate-grenade-devstack-vm/582 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"ec4b49a4db5e43103a119b251aa70d89c3a58cd8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-04-15 04:50:34.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nOh that\u0027s nice and clean.  Thanks","accounts_in_message":[],"_revision_number":3},{"id":"093dbf9f77b1697f0c1e40a6e5d8b3a06810ad4f","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-04-15 12:36:34.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"86390ae21a9d74554844670912fc141d951fb519","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-15 12:36:36.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"b713273718124eeddbca077958ade058b0609e4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-15 13:20:28.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"122f984d7dec1f014f35491479799183b43dbdd7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-15 13:20:28.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/26558/3/gate/gate-tempest-devstack-vm-full/12688 : SUCCESS\n- http://logs.openstack.org/26558/3/gate/gate-tempest-devstack-vm-postgres-full/12403 : SUCCESS\n- http://logs.openstack.org/26558/3/gate/gate-tempest-devstack-vm-quantum/18542 : SUCCESS\n- http://logs.openstack.org/26558/3/gate/gate-grenade-devstack-vm/623 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"18225d92c0ef8d56dc7df3177eaed4860d97604b","revisions":{"d11c29b6e747e91e09a66df607b0d9c118fb4cc3":{"kind":"REWORK","_number":1,"created":"2013-04-10 00:21:04.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/58/26558/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/58/26558/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/58/26558/1"}}},"commit":{"parents":[{"commit":"c4193b22f3ef30c9975e53562c02173c638f5631","subject":"Use baremetal-interface-add, not baremetal-add-interface","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c4193b22f3ef30c9975e53562c02173c638f5631"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-04-10 00:14:56.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-04-10 00:14:56.000000000","tz":720},"subject":"tgt include stack.conf via targets.conf, not conf.d","message":"tgt include stack.conf via targets.conf, not conf.d\n\nputting stack.conf in conf.d results in tgtd not starting with:\nConfig::General The file \"/var/lib/cinder/volumes/*\"\ndoes not exist within ConfigPath: /etc/tgt! at /usr/sbin/tgt-admin line 172\n\nThis patch puts stack.conf in /etc/tgt and includes it explicitly\nin targets.conf\n\nChange-Id: Ifb6412f6860ceb28b724644fb9b618638f552102\nFixes: bug #1072121\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d11c29b6e747e91e09a66df607b0d9c118fb4cc3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d11c29b6e747e91e09a66df607b0d9c118fb4cc3"}]},"branch":"refs/heads/master"},"3a51bb2e573d322891732ba62733479ce611a23e":{"kind":"REWORK","_number":2,"created":"2013-04-10 00:39:21.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/58/26558/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/58/26558/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/58/26558/2"}}},"commit":{"parents":[{"commit":"c4193b22f3ef30c9975e53562c02173c638f5631","subject":"Use baremetal-interface-add, not baremetal-add-interface","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c4193b22f3ef30c9975e53562c02173c638f5631"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-04-10 00:14:56.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-04-10 00:38:41.000000000","tz":720},"subject":"tgt include stack.conf via targets.conf, not conf.d","message":"tgt include stack.conf via targets.conf, not conf.d\n\nputting stack.conf in conf.d results in tgtd not starting with:\nConfig::General The file \"/var/lib/cinder/volumes/*\"\ndoes not exist within ConfigPath: /etc/tgt! at /usr/sbin/tgt-admin line 172\n\nThis patch puts stack.conf in /etc/tgt and includes it explicitly\nin targets.conf\n\nChange-Id: Ifb6412f6860ceb28b724644fb9b618638f552102\nFixes: bug #1072121\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3a51bb2e573d322891732ba62733479ce611a23e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3a51bb2e573d322891732ba62733479ce611a23e"}]},"branch":"refs/heads/master"},"18225d92c0ef8d56dc7df3177eaed4860d97604b":{"kind":"REWORK","_number":3,"created":"2013-04-14 19:50:59.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/58/26558/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/58/26558/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/58/26558/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/58/26558/3"}}},"commit":{"parents":[{"commit":"c4193b22f3ef30c9975e53562c02173c638f5631","subject":"Use baremetal-interface-add, not baremetal-add-interface","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c4193b22f3ef30c9975e53562c02173c638f5631"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-04-14 19:48:41.000000000","tz":-420},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2013-04-14 19:48:41.000000000","tz":-420},"subject":"link /etc/tgt/stack.d to cinder volumes directory","message":"link /etc/tgt/stack.d to cinder volumes directory\n\nThis creates /etc/tgt/stack.d as a symlink to the cinder volumes\ndirectory and includes it in /etc/tgt/targets.conf in a similar way\nto /etc/tgt/conf.d\n\ntargets.conf only gets appended to when the symlink is created.\nAny old /etc/tgt/conf.d/stack.conf is deleted\n\nChange-Id: Ifb6412f6860ceb28b724644fb9b618638f552102\nFixes: bug #1072121\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/18225d92c0ef8d56dc7df3177eaed4860d97604b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/18225d92c0ef8d56dc7df3177eaed4860d97604b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}