)]}'
{"lib/nova_plugins/hypervisor-libvirt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"049b3e2554858db0f655741e787cf7bb9bf558d6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # Due to bz https://bugzilla.redhat.com/show_bug.cgi?id\u003d1378242 if"},{"line_number":51,"context_line":"        # we\u0027re using the Pike UCA and multiattach, we must use raw images."},{"line_number":52,"context_line":"        # TODO(mriedem): Remove this once we\u0027re using UCA with libvirt\u003e\u003d3.10."},{"line_number":53,"context_line":"        iniset $NOVA_CONF libvirt images_type raw"},{"line_number":54,"context_line":"        iniset $NOVA_CONF DEFAULT use_cow_images False"},{"line_number":55,"context_line":"    fi"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f91af0f_7cc6194b","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"updated":"2018-01-04 22:27:31.000000000","message":"This is redundant if use_cow_images\u003dFalse.","commit_id":"2a9f733bc1f5995f7b10a86535cbf9b039106cf6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"38f0c9de7d5fe6b0a77e5563187e173f27c5b6b3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # Due to bz https://bugzilla.redhat.com/show_bug.cgi?id\u003d1378242 if"},{"line_number":51,"context_line":"        # we\u0027re using the Pike UCA and multiattach, we must use raw images."},{"line_number":52,"context_line":"        # TODO(mriedem): Remove this once we\u0027re using UCA with libvirt\u003e\u003d3.10."},{"line_number":53,"context_line":"        iniset $NOVA_CONF libvirt images_type raw"},{"line_number":54,"context_line":"        iniset $NOVA_CONF DEFAULT use_cow_images False"},{"line_number":55,"context_line":"    fi"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f91af0f_0b61b7a9","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":49},"in_reply_to":"9f91af0f_7cc6194b","updated":"2018-01-05 14:46:18.000000000","message":"This doesn\u0027t make any difference since these options are only used with ephemeral disks, not block devices for volumes.","commit_id":"2a9f733bc1f5995f7b10a86535cbf9b039106cf6"}],"lib/tempest":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee6b2c812b686e57c0fd8fe544e74a0610227489","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled snapshot False"},{"line_number":527,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":528,"context_line":"        else"},{"line_number":529,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled volume_multiattach True"},{"line_number":530,"context_line":"        fi"},{"line_number":531,"context_line":"    fi"},{"line_number":532,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_9aedb4f1","line":529,"updated":"2016-01-13 02:03:29.000000000","message":"This needs to be further filtered by the cinder backend being lvm.","commit_id":"e68b2dc555367e085b39bab4d1c21f77d8f21c2c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e60d196f6c3672089092c870a2d3bec598f3252c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# Configures the compute-feature-enabled.volume_multiattach flag based on the"},{"line_number":106,"context_line":"# virt driver and cinder backend used."},{"line_number":107,"context_line":"function set_compute_feature_volume_multiattach_flag {"},{"line_number":108,"context_line":"    if [ \"$VIRT_DRIVER\" \u003d \"libvirt\" ] \u0026\u0026 [ \"$LIBVIRT_TYPE\" !\u003d \"lxc\" ]; then"},{"line_number":109,"context_line":"        # Only enable multi-attach for volumes with libvirt when using the"},{"line_number":110,"context_line":"        # lvm backend in Cinder."},{"line_number":111,"context_line":"        if is_service_enabled c-vol \u0026\u0026 [[ -n \"$CINDER_ENABLED_BACKENDS\" ]]; then"},{"line_number":112,"context_line":"            local be be_name be_type"},{"line_number":113,"context_line":"            for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":114,"context_line":"                be_type\u003d${be%%:*}"},{"line_number":115,"context_line":"                be_name\u003d${be##*:}"},{"line_number":116,"context_line":"                if [[ \"$be_type\" \u003d\u003d \"lvm\" ]]; then"},{"line_number":117,"context_line":"                    iniset $TEMPEST_CONFIG compute-feature-enabled volume_multiattach True"},{"line_number":118,"context_line":"                fi"},{"line_number":119,"context_line":"            done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9f91af0f_6870a0dd","line":116,"range":{"start_line":108,"start_character":4,"end_line":116,"end_character":50},"updated":"2018-01-04 16:11:50.000000000","message":"This is very backend specific, and we should just have a global variable to say if your env supports multiattach or not. If not defined, we can try to figure it out using defaults here.","commit_id":"98b7ffd674fb7a922b10c8ed4a9429e266245c0e"}],"stackrc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e92617c63342583b3a3ae7b354192869b20d8977","unresolved":false,"context_lines":[{"line_number":657,"context_line":"# Global flag used to configure Tempest and potentially other services if"},{"line_number":658,"context_line":"# volume multiattach is supported. In Queens, only the libvirt compute driver"},{"line_number":659,"context_line":"# and lvm volume driver support multiattach, and there are qemu/libvirt"},{"line_number":660,"context_line":"# version conditions for multiattach support if raw images are not used."},{"line_number":661,"context_line":"# First determine if the default compute driver and volume backend are being"},{"line_number":662,"context_line":"# used."},{"line_number":663,"context_line":"MULTIATTACH_DEFAULT\u003dFalse"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f91af0f_ab1d2b10","line":660,"range":{"start_line":660,"start_character":37,"end_line":660,"end_character":71},"updated":"2018-01-05 14:50:50.000000000","message":"This doesn\u0027t make a difference for block devices.","commit_id":"2a9f733bc1f5995f7b10a86535cbf9b039106cf6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e92617c63342583b3a3ae7b354192869b20d8977","unresolved":false,"context_lines":[{"line_number":661,"context_line":"# First determine if the default compute driver and volume backend are being"},{"line_number":662,"context_line":"# used."},{"line_number":663,"context_line":"MULTIATTACH_DEFAULT\u003dFalse"},{"line_number":664,"context_line":"if [ \"$VIRT_DRIVER\" \u003d \"libvirt\" ] \u0026\u0026 [ \"$LIBVIRT_TYPE\" !\u003d \"lxc\" ]; then"},{"line_number":665,"context_line":"    # Only enable multi-attach for volumes with libvirt when using the"},{"line_number":666,"context_line":"    # lvm backend in Cinder."},{"line_number":667,"context_line":"    if [[ \"$CINDER_ENABLED_BACKENDS\" \u003d\u003d *\"lvm\"* ]]; then"},{"line_number":668,"context_line":"        MULTIATTACH_DEFAULT\u003dTrue"},{"line_number":669,"context_line":"    fi"},{"line_number":670,"context_line":"fi"},{"line_number":671,"context_line":"ENABLE_VOLUME_MULTIATTACH\u003d$(trueorfalse $MULTIATTACH_DEFAULT ENABLE_VOLUME_MULTIATTACH)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9f91af0f_8be70713","line":670,"range":{"start_line":664,"start_character":0,"end_line":670,"end_character":2},"updated":"2018-01-05 14:50:50.000000000","message":"We can probably remove this. We basically depend on the qemu/libvirt versions now, which means a CI job is going to have to be specific about multiattach support and if it sets multiattach\u003dtrue, we\u0027ll need to not use the Pike UCA.","commit_id":"2a9f733bc1f5995f7b10a86535cbf9b039106cf6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"54664c01c9d1d74c426175e340abe117de51efd6","unresolved":false,"context_lines":[{"line_number":651,"context_line":"ENABLE_VOLUME_MULTIATTACH\u003d$(trueorfalse False ENABLE_VOLUME_MULTIATTACH)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"# By default, devstack will use Ubuntu Cloud Archive."},{"line_number":654,"context_line":"ENABLE_UBUNTU_CLOUD_ARCHIVE\u003d$(trueorfalse $UCA_DEFAULT ENABLE_UBUNTU_CLOUD_ARCHIVE)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"# Images"},{"line_number":657,"context_line":"# ------"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9f91af0f_cb0e6f8c","line":654,"range":{"start_line":654,"start_character":43,"end_line":654,"end_character":54},"updated":"2018-01-05 15:07:02.000000000","message":"True","commit_id":"d4087188394ceb2b9cf1da41d155c61eab7e32e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9e607bd7cc771391d4aa7916d226f7d073f55a61","unresolved":false,"context_lines":[{"line_number":652,"context_line":"# volume multiattach is supported. In Queens, only the libvirt compute driver"},{"line_number":653,"context_line":"# and lvm volume driver support multiattach, and qemu must be less than 2.10"},{"line_number":654,"context_line":"# or libvirt must be greater than or equal to 3.10."},{"line_number":655,"context_line":"ENABLE_VOLUME_MULTIATTACH\u003d$(trueorfalse False ENABLE_VOLUME_MULTIATTACH)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"# By default, devstack will use Ubuntu Cloud Archive."},{"line_number":658,"context_line":"ENABLE_UBUNTU_CLOUD_ARCHIVE\u003d$(trueorfalse True ENABLE_UBUNTU_CLOUD_ARCHIVE)"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9f91af0f_733aad34","line":655,"range":{"start_line":655,"start_character":0,"end_line":655,"end_character":25},"updated":"2018-01-06 02:06:33.000000000","message":"Need to define this before it\u0027s used.","commit_id":"8b7b7413f6b6aab26a773ac7715164cf27d08981"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"caabfb8249e0987e25652bd17abeca92f821eed9","unresolved":false,"context_lines":[{"line_number":654,"context_line":"esac"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"# By default, devstack will use Ubuntu Cloud Archive."},{"line_number":657,"context_line":"ENABLE_UBUNTU_CLOUD_ARCHIVE\u003d$(trueorfalse True ENABLE_UBUNTU_CLOUD_ARCHIVE)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"# Images"},{"line_number":660,"context_line":"# ------"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f91af0f_73686d20","line":657,"range":{"start_line":657,"start_character":0,"end_line":657,"end_character":27},"updated":"2018-01-06 02:11:09.000000000","message":"Maybe we should just set this to False if ENABLE_VOLUME_MULTIATTACH is True?","commit_id":"0d2c0f399601e7f8f36ab7cdcd6fac3e224bc7bb"}]}