)]}'
{"lib/horizon":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9eef69a9f7a18d448f5d9fa93d86d76fe0d62901","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # appropriate at some future point, but for now direct download is"},{"line_number":73,"context_line":"    # the simplest way.  The version barely matters for lesscss which"},{"line_number":74,"context_line":"    # doesn\u0027t use anything fancy."},{"line_number":75,"context_line":"    local ver\u003d0.10.1"},{"line_number":76,"context_line":"    local nodejs\u003dnode-v${ver}-linux-x64"},{"line_number":77,"context_line":"    local tar\u003d$nodejs.tar.gz"},{"line_number":78,"context_line":"    local nodejs_url\u003dhttp://nodejs.org/dist/v${ver}/${tar}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOn%2F%2FzRQ%3D","line":75,"updated":"2013-04-22 21:17:25.000000000","message":"I\u0027d probably pin this to a 0.8 version which seems to be what the distros that package it mostly have.","commit_id":"18bc2dcccc6d927c068c8ad7f43345fa9e0e0584"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"71b63db5320f5b121506ef593ce71e140bf14dea","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    fi"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # /usr/bin so it gets found in the PATH available to horizon"},{"line_number":87,"context_line":"    sudo ln -s $DEST/$nodejs/bin/node /usr/bin/node"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Entry Points"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAOn%2F%2FyA4%3D","line":87,"updated":"2013-04-23 15:58:45.000000000","message":"There should be a corresponding cleanup for this in cleanup_horizon() for future upgrades.","commit_id":"f0afc7ac883f0fcc71513c81140c1f5f7a8dac29"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"618372365bdb3dacab0b279e652e0457a13d2c09","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    fi"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # /usr/bin so it gets found in the PATH available to horizon"},{"line_number":87,"context_line":"    sudo ln -s $DEST/$nodejs/bin/node /usr/bin/node"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Entry Points"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAOn%2F%2Fr3g%3D","line":87,"in_reply_to":"AAAAOn%2F%2FyA4%3D","updated":"2013-04-29 06:21:27.000000000","message":"Done","commit_id":"f0afc7ac883f0fcc71513c81140c1f5f7a8dac29"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"6bbd6a0776019c8f5cdb1d400c3b486d05d7dfcb","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        exit_distro_not_supported \"apache installation\""},{"line_number":191,"context_line":"    fi"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    if [[ is_fedora \u0026\u0026 $DISTRO \u003d~ (rhel6) ]]; then"},{"line_number":194,"context_line":"        # RHEL6 currently has no native way to get nodejs, so we do a"},{"line_number":195,"context_line":"        # basic install here (see cleanup_horizon too)."},{"line_number":196,"context_line":"        # TODO: does nova have a better way that we can limit"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2FqcA%3D","line":193,"updated":"2013-04-30 00:07:59.000000000","message":"I think this should move to the if..elf.. below.\n\nAnd since we consider is_fedora as  a more is_fedora_based a, nested if makes more sense, (IMHO)\n\nif is_ubuntu; then\n  [...]\nelif is_fedora; then\n   if f18; then\n       [...]\n   else rhel6; then\n       [...]\n   fi\nfi\n\nI believe this leads to a more maintainable code since the portions related to fedora can be easily moved elsewhere say to another function.","commit_id":"ad43b3957ee8082c1e27568de1070edb81734181"},{"author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"change_message_id":"1045b4317e2579c1883abb057b3ad6a83f379e5f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        exit_distro_not_supported \"apache installation\""},{"line_number":191,"context_line":"    fi"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    if [[ is_fedora \u0026\u0026 $DISTRO \u003d~ (rhel6) ]]; then"},{"line_number":194,"context_line":"        # RHEL6 currently has no native way to get nodejs, so we do a"},{"line_number":195,"context_line":"        # basic install here (see cleanup_horizon too)."},{"line_number":196,"context_line":"        # TODO: does nova have a better way that we can limit"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2FqYY%3D","line":193,"in_reply_to":"AAAAOn%2F%2FqZg%3D","updated":"2013-04-30 01:45:14.000000000","message":"Even if you want to keep it flat, doesn\u0027t it belong to the if.elif..elfi.. below?","commit_id":"ad43b3957ee8082c1e27568de1070edb81734181"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"4ce9df0601f8e877c4afc86fd41d3de132db8689","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        exit_distro_not_supported \"apache installation\""},{"line_number":191,"context_line":"    fi"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    if [[ is_fedora \u0026\u0026 $DISTRO \u003d~ (rhel6) ]]; then"},{"line_number":194,"context_line":"        # RHEL6 currently has no native way to get nodejs, so we do a"},{"line_number":195,"context_line":"        # basic install here (see cleanup_horizon too)."},{"line_number":196,"context_line":"        # TODO: does nova have a better way that we can limit"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2FqZg%3D","line":193,"in_reply_to":"AAAAOn%2F%2FqcA%3D","updated":"2013-04-30 00:51:19.000000000","message":"I think that\u0027s ok if there\u0027s branching going on, but in this case I think in this case less code is better.","commit_id":"ad43b3957ee8082c1e27568de1070edb81734181"}]}